From c0fc661c1de40a6d8ee3705b53baa071113b495b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Huan=20LI=20=28=E6=9D=8E=E5=8D=93=E6=A1=93=29?= Date: Sat, 22 Aug 2020 19:35:13 +0800 Subject: [PATCH] remove deprecated methods (#2049) --- package.json | 46 +++++++++++++++---------------- src/user/contact.ts | 55 +------------------------------------ src/user/friendship.ts | 10 ------- src/user/message.ts | 32 --------------------- src/user/room-invitation.ts | 29 ------------------- src/user/room.ts | 29 ------------------- src/wechaty.ts | 18 ------------ 7 files changed, 24 insertions(+), 195 deletions(-) diff --git a/package.json b/package.json index 259ec820..b6523ad3 100644 --- a/package.json +++ b/package.json @@ -83,59 +83,59 @@ }, "homepage": "https://github.com/wechaty/", "dependencies": { - "brolog": "^1.8.3", + "brolog": "^1.12.4", "clone-class": "^0.7.3", "cuid": "^2.1.8", "dotenv": "^8.2.0", "in-gfw": "^1.2.0", - "json-rpc-peer": "^0.15.5", + "json-rpc-peer": "^0.16.0", "npm-programmatic": "0.0.12", "open-graph": "^0.2.4", "opencollective": "^1.0.3", - "opencollective-postinstall": "^2.0.2", + "opencollective-postinstall": "^2.0.3", "pkg-dir": "^4.2.0", - "portfinder": "^1.0.25", - "promise-retry": "^1.1.1", + "portfinder": "^1.0.28", + "promise-retry": "^2.0.1", "raven": "^2.6.4", "read-pkg-up": "^7.0.1", "state-switch": "^0.9.9", - "typed-emitter": "^1.2.0", + "typed-emitter": "^1.3.0", "watchdog": "^0.8.17", "wechaty-puppet-hostie": "^0.9.13", - "wechaty-puppet": "^0.31.5", - "ws": "^7.2.3" + "wechaty-puppet": "^0.32.3", + "ws": "^7.3.1" }, "devDependencies": { - "@babel/core": "^7.8.7", - "@babel/node": "^7.8.7", - "@babel/preset-env": "^7.8.7", - "@chatie/eslint-config": "^0.11.5", - "@chatie/git-scripts": "^0.5.2", + "@babel/core": "^7.11.4", + "@babel/node": "^7.10.5", + "@babel/preset-env": "^7.11.0", + "@chatie/eslint-config": "^0.12.1", + "@chatie/git-scripts": "^0.6.2", "@chatie/semver": "^0.4.7", - "@chatie/tsconfig": "^0.8.0", - "@types/cuid": "^1.3.0", + "@chatie/tsconfig": "^0.10.1", + "@types/cuid": "^1.3.1", "@types/dotenv": "^8.2.0", - "@types/glob": "^7.1.1", + "@types/glob": "^7.1.3", "@types/open-graph": "^0.2.0", "@types/promise-retry": "^1.1.3", "@types/raven": "^2.5.3", "@types/retry": "^0.12.0", - "@types/ws": "^7.2.2", + "@types/ws": "^7.2.6", "apiai": "^4.0.3", - "check-node-version": "^4.0.2", - "coveralls": "^3.0.9", + "check-node-version": "^4.0.3", + "coveralls": "^3.1.0", "cross-env": "^7.0.2", "finis": "^0.4.4", "glob": "^7.1.6", - "jsdoc-to-markdown": "^5.0.3", - "markdownlint-cli": "^0.22.0", - "nyc": "^15.0.0", + "jsdoc-to-markdown": "^6.0.1", + "markdownlint-cli": "^0.23.2", + "nyc": "^15.1.0", "pkg-jq": "^0.2.4", "qrcode-terminal": "^0.12.0", "shx": "^0.3.2", "sloc": "^0.2.1", "tstest": "^0.4.10", - "typedoc": "^0.16.11", + "typedoc": "^0.18.0", "wechaty-puppet-mock": "^0.27.2" }, "files_comment__whitelist_npm_publish": "http://stackoverflow.com/a/8617868/1123955", diff --git a/src/user/contact.ts b/src/user/contact.ts index e89088c1..df6ab063 100644 --- a/src/user/contact.ts +++ b/src/user/contact.ts @@ -570,7 +570,7 @@ class Contact extends ContactEventEmitter implements Sayable { } if (typeof phoneList === 'undefined') { - return this.wechaty.puppet.contactPhone(this.id) + return this.payload.phone } try { @@ -583,20 +583,6 @@ class Contact extends ContactEventEmitter implements Sayable { } } - /** - * - * @description - * Should use {@link Contact#friend} instead - * - * @deprecated - * @ignore - */ - public stranger (): null | boolean { - log.warn('Contact', 'stranger() DEPRECATED. use friend() instead.') - if (!this.payload) return null - return !this.friend() - } - /** * Check if contact is friend * @@ -618,33 +604,6 @@ class Contact extends ContactEventEmitter implements Sayable { return this.payload.friend || null } - /** - * @ignore - * @see {@link https://github.com/Chatie/webwx-app-tracker/blob/7c59d35c6ea0cff38426a4c5c912a086c4c512b2/formatted/webwxApp.js#L3243|webwxApp.js#L324} - * @see {@link https://github.com/Urinx/WeixinBot/blob/master/README.md|Urinx/WeixinBot/README} - */ - /** - * @description - * Check if it's a official account, should use {@link Contact#type} instead - * @deprecated - * @ignore - */ - public official (): boolean { - log.warn('Contact', 'official() DEPRECATED. use type() instead') - return !!this.payload && (this.payload.type === ContactType.Official) - } - - /** - * @description - * Check if it's a personal account, should use {@link Contact#type} instead - * @deprecated - * @ignore - */ - public personal (): boolean { - log.warn('Contact', 'personal() DEPRECATED. use type() instead') - return !!this.payload && this.payload.type === ContactType.Personal - } - /** * Enum for ContactType * @enum {number} @@ -768,18 +727,6 @@ class Contact extends ContactEventEmitter implements Sayable { } } - /** - * @description - * Force reload(re-ready()) data for Contact, use {@link Contact#sync} instead - * - * @deprecated - * @ignore - */ - public refresh (): Promise { - log.warn('Contact', 'refresh() DEPRECATED. use sync() instead.') - return this.sync() - } - /** * Force reload data for Contact, Sync data from low-level API again. * diff --git a/src/user/friendship.ts b/src/user/friendship.ts index fb28fd6c..3b36179b 100644 --- a/src/user/friendship.ts +++ b/src/user/friendship.ts @@ -105,16 +105,6 @@ class Friendship extends EventEmitter implements Acceptable { return contact } - /** - * @description - * use {@link Friendship#add} instead - * @deprecated - */ - public static async send (contact: Contact, hello: string) { - log.warn('Friendship', 'static send() DEPRECATED， use add() instead.') - return this.add(contact, hello) - } - /** * Send a Friend Request to a `contact` with message `hello`. * diff --git a/src/user/message.ts b/src/user/message.ts index 457edf24..2d3d887f 100644 --- a/src/user/message.ts +++ b/src/user/message.ts @@ -327,17 +327,6 @@ class Message extends EventEmitter implements Sayable { return room } - /** - * @description - * use {@link Message#text} instead - * - * @deprecated - */ - public content (): string { - log.warn('Message', 'content() DEPRECATED. use text() instead.') - return this.text() - } - /** * Get the text content of the message * @@ -777,17 +766,6 @@ class Message extends EventEmitter implements Sayable { return textWithoutMention.trim() } - /** - * @description - * should use {@link Message#mention} instead - * @deprecated - * @ignore - */ - public async mentioned (): Promise { - log.warn('Message', 'mentioned() DEPRECATED. use mention() instead.') - return this.mentionList() - } - /** * Check if a message is mention self. * @@ -938,16 +916,6 @@ class Message extends EventEmitter implements Sayable { return ageSeconds } - /** - * @description - * use {@link Message#toFileBox} instead - * @deprecated - */ - public async file (): Promise { - log.warn('Message', 'file() DEPRECATED. use toFileBox() instead.') - return this.toFileBox() - } - /** * Extract the Media File from the Message, and put it into the FileBox. * > Tips: diff --git a/src/user/room-invitation.ts b/src/user/room-invitation.ts index e4e3e221..17f36c03 100644 --- a/src/user/room-invitation.ts +++ b/src/user/room-invitation.ts @@ -177,36 +177,17 @@ class RoomInvitation implements Acceptable { public async topic (): Promise { const payload = await this.wechaty.puppet.roomInvitationPayload(this.id) - // roomTopic deprecated. use topic instead: return payload.topic || payload.topic || '' } - /** - * @deprecated: use topic() instead - * @ignore - */ - public async roomTopic (): Promise { - return this.topic() - } - public async memberCount (): Promise { log.verbose('RoomInvitation', 'memberCount()') const payload = await this.wechaty.puppet.roomInvitationPayload(this.id) - // roomMemberCount deprecated. use memberCount instead: return payload.memberCount || payload.memberCount || 0 } - /** - * @deprecated: use memberCount() instead - * @ignore - */ - public async roomMemberCount (): Promise { - log.warn('RoomInvitation', 'roomMemberCount() DEPRECATED. use memberCount() instead.') - return this.memberCount() - } - /** * List of Room Members that you known(is friend) * @ignore @@ -216,7 +197,6 @@ class RoomInvitation implements Acceptable { const payload = await this.wechaty.puppet.roomInvitationPayload(this.id) - // roomMemberIdList deprecated. use memberIdList isntead. const contactIdList = payload.memberIdList || payload.memberIdList || [] const contactList = contactIdList.map( @@ -231,15 +211,6 @@ class RoomInvitation implements Acceptable { return contactList } - /** - * @deprecated: use memberList() instead. - * @ignore - */ - public async roomMemberList (): Promise { - log.warn('RoomInvitation', 'roomMemberList() DEPRECATED. use memberList() instead.') - return this.roomMemberList() - } - /** * Get the invitation time * diff --git a/src/user/room.ts b/src/user/room.ts index 7d73824d..fa18a1f9 100644 --- a/src/user/room.ts +++ b/src/user/room.ts @@ -302,15 +302,6 @@ class Room extends RoomEventEmitter implements Sayable { } } - /** - * @ignore - * @ignore - * @deprecated: Use `sync()` instead - */ - public async refresh (): Promise { - await this.sync() - } - /** * Force reload data for Room, Sync data from puppet API again. * @@ -959,14 +950,6 @@ class Room extends RoomEventEmitter implements Sayable { } } - /** - * @deprecated: use qrCode() instead - */ - public async qrcode () { - log.warn('Room', 'qrcode() is deprecated. use qrCode() instead.') - return this.qrCode() - } - /** * Get QR Code Value of the Room from the room, which can be used as scan and join the room. * > Tips: @@ -1007,18 +990,6 @@ class Room extends RoomEventEmitter implements Sayable { return null } - /** - * Same as function alias - * @param {Contact} contact - * @returns {Promise} - * @deprecated: use room.alias() instead - * @ignore - */ - public async roomAlias (contact: Contact): Promise { - log.warn('Room', 'roomAlias() DEPRECATED. use room.alias() instead') - return this.alias(contact) - } - /** * Check if the room has member `contact`, the return is a Promise and must be `await`-ed * diff --git a/src/wechaty.ts b/src/wechaty.ts index b5500bc9..e1a5c246 100644 --- a/src/wechaty.ts +++ b/src/wechaty.ts @@ -101,9 +101,6 @@ export interface WechatyOptions { memory? : MemoryCard, name? : string, // Wechaty Name - // @deprecated: use `name` instead of `profile` - profile? : null | string, // DEPRECATED: use name instead - puppet? : PuppetModuleName | Puppet, // Puppet name or instance puppetOptions? : PuppetOptions, // Puppet TOKEN ioToken? : string, // Io TOKEN @@ -287,10 +284,6 @@ export class Wechaty extends WechatyEventEmitter implements Sayable { super() log.verbose('Wechaty', 'constructor()') - if (!options.name && options.profile) { - log.verbose('Wechaty', 'constructor() WechatyOptions.profile DEPRECATED. use WechatyOptions.name instead.') - options.name = options.profile - } this.memory = this.options.memory this.id = cuid() @@ -838,17 +831,6 @@ export class Wechaty extends WechatyEventEmitter implements Sayable { } } - /** - * @description - * Should use {@link Wechaty#userSelf} instead - * @deprecated Use `userSelf()` instead - * @ignore - */ - public self (): Contact { - log.warn('Wechaty', 'self() DEPRECATED. use userSelf() instead.') - return this.userSelf() - } - /** * Get current user * -- GitLab