From 11ea4be87ec361c12ad71feb831424d42bca35ec Mon Sep 17 00:00:00 2001 From: cyberdak Date: Wed, 21 Mar 2018 13:51:43 +0800 Subject: [PATCH] fix #939 (#969) * fix #939 fix #939 * fixcheckstyle --- .../collector/storage/es/dao/ui/InstanceMetricEsUIDAO.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/apm-collector/apm-collector-storage/collector-storage-es-provider/src/main/java/org/apache/skywalking/apm/collector/storage/es/dao/ui/InstanceMetricEsUIDAO.java b/apm-collector/apm-collector-storage/collector-storage-es-provider/src/main/java/org/apache/skywalking/apm/collector/storage/es/dao/ui/InstanceMetricEsUIDAO.java index 701550b968..81cde47c78 100644 --- a/apm-collector/apm-collector-storage/collector-storage-es-provider/src/main/java/org/apache/skywalking/apm/collector/storage/es/dao/ui/InstanceMetricEsUIDAO.java +++ b/apm-collector/apm-collector-storage/collector-storage-es-provider/src/main/java/org/apache/skywalking/apm/collector/storage/es/dao/ui/InstanceMetricEsUIDAO.java @@ -144,7 +144,12 @@ public class InstanceMetricEsUIDAO extends EsDAO implements IInstanceMetricUIDAO long errorCallTimes = ((Number)response.getResponse().getSource().get(InstanceMetricTable.COLUMN_TRANSACTION_ERROR_CALLS)).longValue(); long durationSum = ((Number)response.getResponse().getSource().get(InstanceMetricTable.COLUMN_TRANSACTION_DURATION_SUM)).longValue(); long errorDurationSum = ((Number)response.getResponse().getSource().get(InstanceMetricTable.COLUMN_BUSINESS_TRANSACTION_ERROR_DURATION_SUM)).longValue(); - responseTimeTrends.add((int)((durationSum - errorDurationSum) / (callTimes - errorCallTimes))); + long correctCallTimes = callTimes - errorCallTimes; + if (correctCallTimes != 0L) { + responseTimeTrends.add((int)((durationSum - errorDurationSum) / correctCallTimes)); + } else { + responseTimeTrends.add(0); + } } else { responseTimeTrends.add(0); } -- GitLab