From 40024efc700a2ece0e30402ec5a9c512ed4d9b5b Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Thu, 3 Sep 2020 12:08:47 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .rubocop_todo.yml | 22 - GITALY_SERVER_VERSION | 2 +- .../components/inline_diff_table_row.vue | 153 +++++-- .../notes/components/note_header.vue | 12 +- .../notes/components/noteable_note.vue | 8 +- .../packages/details/components/app.vue | 32 +- .../details/components/code_instruction.vue | 2 +- .../details/components/dependency_row.vue | 2 +- .../list/components/packages_list.vue | 4 +- .../list/components/packages_list_app.vue | 4 +- .../shared/components/package_tags.vue | 4 +- .../components/packages_list_loader.vue | 4 +- .../shared/components/publish_method.vue | 20 +- .../accessibility_report/store/index.js | 15 +- .../reports/codequality_report/store/index.js | 15 +- app/assets/javascripts/reports/store/index.js | 15 +- .../stylesheets/_page_specific_files.scss | 1 - app/assets/stylesheets/pages/packages.scss | 11 - app/assets/stylesheets/utilities.scss | 17 + app/controllers/projects/blob_controller.rb | 9 + app/finders/issuable_finder.rb | 1 + app/finders/labels_finder.rb | 9 +- .../resolvers/board_list_issues_resolver.rb | 10 +- .../concerns/board_issue_filterable.rb | 24 ++ app/graphql/types/board_list_type.rb | 2 +- .../boards/board_issue_input_base_type.rb | 35 ++ .../types/boards/board_issue_input_type.rb | 24 ++ .../optimized_issuable_label_filter.rb | 107 +++++ ... => create_downstream_pipeline_service.rb} | 6 +- .../composer/create_package_service.rb | 7 +- .../packages/conan/create_package_service.rb | 5 +- .../packages/create_package_service.rb | 30 ++ .../packages/maven/create_package_service.rb | 7 +- .../packages/npm/create_package_service.rb | 12 +- .../packages/nuget/create_package_service.rb | 4 +- .../packages/pypi/create_package_service.rb | 7 +- app/views/projects/find_file/show.html.haml | 2 +- .../creations/_new_compare.html.haml | 4 +- app/views/shared/web_hooks/_form.html.haml | 52 +-- .../create_cross_project_pipeline_worker.rb | 2 +- ...ts-javascripts-notes-components-note_h.yml | 5 + ...inner-for-app-views-projects-find_file.yml | 5 + .../232840-fj-track-sfe-actions.yml | 5 + .../232844-fj-add-ide-actions-usage-data.yml | 5 + .../233475-source-branch-dropdown-empty.yml | 5 + .../235699-graphql-board-issue-filters.yml | 5 + changelogs/unreleased/i18n-webhook-form.yml | 5 + .../jdb-refactor-inline-diff-table-row.yml | 5 + .../unreleased/let-before-examples-cop.yml | 5 + .../optimized-issuable-label-search-pt1.yml | 5 + changelogs/unreleased/single-line-cop.yml | 5 + .../optimized_issuable_label_filter.yml | 7 + ...29134747_add_extra_index_to_label_links.rb | 26 ++ ...ulnerabilities_for_background_migration.rb | 18 + ...ulate_resolved_on_default_branch_column.rb | 28 ++ db/schema_migrations/20200629134747 | 1 + db/schema_migrations/20200826220745 | 1 + db/schema_migrations/20200826220746 | 1 + db/structure.sql | 6 +- .../graphql/reference/gitlab_schema.graphql | 140 ++++++- doc/api/graphql/reference/gitlab_schema.json | 390 ++++++++++++++++-- doc/api/graphql/reference/index.md | 4 +- ...ulate_resolved_on_default_branch_column.rb | 12 + lib/gitlab/ci/ansi2html.rb | 200 ++++++--- lib/gitlab/usage_data.rb | 48 +-- locale/gitlab.pot | 78 ++++ qa/qa/support/json_formatter.rb | 2 +- .../projects/blob_controller_spec.rb | 35 ++ spec/controllers/search_controller_spec.rb | 6 +- spec/finders/issues_finder_spec.rb | 157 ++++--- spec/finders/merge_requests_finder_spec.rb | 66 +-- .../components/inline_diff_table_row_spec.js | 355 ++++++++++++---- .../code_instruction_spec.js.snap | 2 +- .../__snapshots__/dependency_row_spec.js.snap | 2 +- .../packages_list_app_spec.js.snap | 2 +- .../__snapshots__/publish_method_spec.js.snap | 14 +- .../shared/components/publish_method_spec.js | 6 +- .../grouped_accessibility_reports_app_spec.js | 11 +- .../grouped_codequality_reports_app_spec.js | 33 +- .../grouped_test_reports_app_spec.js | 13 +- .../board_list_issues_resolver_spec.rb | 36 +- .../resolvers/merge_requests_resolver_spec.rb | 2 +- .../boards/board_issue_input_type_spec.rb | 15 + .../filter/issue_reference_filter_spec.rb | 70 ++-- .../filter/user_reference_filter_spec.rb | 16 +- .../handler/create_issue_handler_spec.rb | 22 +- .../create_merge_request_handler_spec.rb | 24 +- .../email/handler/create_note_handler_spec.rb | 20 +- spec/lib/gitlab/usage_data_spec.rb | 23 +- spec/models/commit_range_spec.rb | 23 +- spec/models/milestone_spec.rb | 10 +- .../packagist_service_spec.rb | 28 +- .../boards/board_list_issues_query_spec.rb | 8 +- .../graphql/project/merge_requests_spec.rb | 2 +- .../api/issues/get_group_issues_spec.rb | 97 +++-- .../update_column_in_batches_spec.rb | 4 +- .../pipeline_details_entity_spec.rb | 8 +- ...reate_downstream_pipeline_service_spec.rb} | 6 +- .../controllers/unique_hll_events_examples.rb | 52 ++- ...eate_cross_project_pipeline_worker_spec.rb | 4 +- 100 files changed, 2207 insertions(+), 684 deletions(-) delete mode 100644 app/assets/stylesheets/pages/packages.scss create mode 100644 app/graphql/resolvers/concerns/board_issue_filterable.rb create mode 100644 app/graphql/types/boards/board_issue_input_base_type.rb create mode 100644 app/graphql/types/boards/board_issue_input_type.rb create mode 100644 app/models/concerns/optimized_issuable_label_filter.rb rename app/services/ci/{create_cross_project_pipeline_service.rb => create_downstream_pipeline_service.rb} (94%) create mode 100644 app/services/packages/create_package_service.rb create mode 100644 changelogs/unreleased/202270-migrate-spinner-for-app-assets-javascripts-notes-components-note_h.yml create mode 100644 changelogs/unreleased/202582-migrate-spinner-for-app-views-projects-find_file.yml create mode 100644 changelogs/unreleased/232840-fj-track-sfe-actions.yml create mode 100644 changelogs/unreleased/232844-fj-add-ide-actions-usage-data.yml create mode 100644 changelogs/unreleased/233475-source-branch-dropdown-empty.yml create mode 100644 changelogs/unreleased/235699-graphql-board-issue-filters.yml create mode 100644 changelogs/unreleased/i18n-webhook-form.yml create mode 100644 changelogs/unreleased/jdb-refactor-inline-diff-table-row.yml create mode 100644 changelogs/unreleased/let-before-examples-cop.yml create mode 100644 changelogs/unreleased/optimized-issuable-label-search-pt1.yml create mode 100644 changelogs/unreleased/single-line-cop.yml create mode 100644 config/feature_flags/development/optimized_issuable_label_filter.yml create mode 100644 db/migrate/20200629134747_add_extra_index_to_label_links.rb create mode 100644 db/post_migrate/20200826220745_add_compound_index_on_vulnerabilities_for_background_migration.rb create mode 100644 db/post_migrate/20200826220746_schedule_populate_resolved_on_default_branch_column.rb create mode 100644 db/schema_migrations/20200629134747 create mode 100644 db/schema_migrations/20200826220745 create mode 100644 db/schema_migrations/20200826220746 create mode 100644 lib/gitlab/background_migration/populate_resolved_on_default_branch_column.rb create mode 100644 spec/graphql/types/boards/board_issue_input_type_spec.rb rename spec/services/ci/{create_cross_project_pipeline_service_spec.rb => create_downstream_pipeline_service_spec.rb} (98%) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 6609868689d..cafba1c6149 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -199,21 +199,6 @@ RSpec/ExpectChange: RSpec/ExpectInHook: Enabled: false -# Offense count: 68 -# Cop supports --auto-correct. -RSpec/LetBeforeExamples: - Exclude: - - 'spec/lib/banzai/filter/issue_reference_filter_spec.rb' - - 'spec/lib/banzai/filter/user_reference_filter_spec.rb' - - 'spec/lib/gitlab/email/handler/create_issue_handler_spec.rb' - - 'spec/lib/gitlab/email/handler/create_merge_request_handler_spec.rb' - - 'spec/lib/gitlab/email/handler/create_note_handler_spec.rb' - - 'spec/models/commit_range_spec.rb' - - 'spec/models/milestone_spec.rb' - - 'spec/models/project_services/packagist_service_spec.rb' - - 'spec/rubocop/cop/migration/update_column_in_batches_spec.rb' - - 'spec/serializers/pipeline_details_entity_spec.rb' - # Offense count: 2188 # Cop supports --auto-correct. # Configuration parameters: Strict, EnforcedStyle, AllowedExplicitMatchers. @@ -679,13 +664,6 @@ Style/RescueModifier: Style/RescueStandardError: Enabled: false -# Offense count: 50 -# Cop supports --auto-correct. -# Configuration parameters: AllowIfMethodIsEmpty. -Style/SingleLineMethods: - Exclude: - - 'lib/gitlab/ci/ansi2html.rb' - # Offense count: 102 # Cop supports --auto-correct. # Configuration parameters: . diff --git a/GITALY_SERVER_VERSION b/GITALY_SERVER_VERSION index e7ceb275bc4..edc9f9d47b2 100644 --- a/GITALY_SERVER_VERSION +++ b/GITALY_SERVER_VERSION @@ -1 +1 @@ -a783958be5ae0797dac9041bdfb884440e0e6306 +02ae27efafdf367d991eac43df02b892be378a1b diff --git a/app/assets/javascripts/diffs/components/inline_diff_table_row.vue b/app/assets/javascripts/diffs/components/inline_diff_table_row.vue index e6ea441c95a..15a22d1767c 100644 --- a/app/assets/javascripts/diffs/components/inline_diff_table_row.vue +++ b/app/assets/javascripts/diffs/components/inline_diff_table_row.vue @@ -1,8 +1,7 @@ @@ -109,25 +189,52 @@ export default { @mouseover="handleMouseMove" @mouseout="handleMouseMove" > - - + + + + + + + + + + + + /* eslint-disable vue/no-v-html */ import { mapActions } from 'vuex'; -import { GlIcon, GlTooltipDirective } from '@gitlab/ui'; +import { GlIcon, GlLoadingIcon, GlTooltipDirective } from '@gitlab/ui'; import timeAgoTooltip from '~/vue_shared/components/time_ago_tooltip.vue'; export default { @@ -10,6 +10,7 @@ export default { GitlabTeamMemberBadge: () => import('ee_component/vue_shared/components/user_avatar/badges/gitlab_team_member_badge.vue'), GlIcon, + GlLoadingIcon, }, directives: { GlTooltip: GlTooltipDirective, @@ -195,13 +196,12 @@ export default { class="gl-ml-1 gl-text-gray-700 align-middle" /> - + class="editing-spinner" + :label="__('Comment is being updated')" + /> diff --git a/app/assets/javascripts/notes/components/noteable_note.vue b/app/assets/javascripts/notes/components/noteable_note.vue index 7116a007ebe..e5f1fbff687 100644 --- a/app/assets/javascripts/notes/components/noteable_note.vue +++ b/app/assets/javascripts/notes/components/noteable_note.vue @@ -1,9 +1,8 @@