From 5f558042b25eacfbbcd0e1c2b8c1f41820436986 Mon Sep 17 00:00:00 2001 From: Megvii Engine Team Date: Fri, 23 Jul 2021 16:23:15 +0800 Subject: [PATCH] fix(imperative/ops): use tblgen to generate FastpathCopy GitOrigin-RevId: b02157dacb8c08e8ee06b47cd442229832f15c94 --- imperative/python/src/tensor.cpp | 1 + imperative/src/impl/ops/utility.cpp | 2 -- .../src/include/megbrain/imperative/ops/utility.h | 14 -------------- src/core/include/megbrain/ir/ops.td | 2 ++ 4 files changed, 3 insertions(+), 16 deletions(-) diff --git a/imperative/python/src/tensor.cpp b/imperative/python/src/tensor.cpp index ee28d8fd2..73d3c2697 100644 --- a/imperative/python/src/tensor.cpp +++ b/imperative/python/src/tensor.cpp @@ -13,6 +13,7 @@ #include "megbrain/common.h" #include "megbrain/imperative/ops/utility.h" #include "megbrain/imperative/ops/backward_graph.h" +#include "megbrain/imperative/ops/autogen.h" #include "megbrain/imperative/profiler.h" #include "megbrain/opr/io.h" diff --git a/imperative/src/impl/ops/utility.cpp b/imperative/src/impl/ops/utility.cpp index d4e8deefa..14654134b 100644 --- a/imperative/src/impl/ops/utility.cpp +++ b/imperative/src/impl/ops/utility.cpp @@ -31,8 +31,6 @@ OP_TRAIT_REG(FastpathCopy,FastpathCopy) .fallback(); }} // fastpathcopy -MGB_DYN_TYPE_OBJ_FINAL_IMPL(FastpathCopy); - namespace { namespace identity { auto apply_on_var_node( const OpDef& def, diff --git a/imperative/src/include/megbrain/imperative/ops/utility.h b/imperative/src/include/megbrain/imperative/ops/utility.h index ab58283c6..dc327d08d 100644 --- a/imperative/src/include/megbrain/imperative/ops/utility.h +++ b/imperative/src/include/megbrain/imperative/ops/utility.h @@ -35,18 +35,4 @@ struct GenericPyOp final : OpDefImplBase { MGB_DYN_TYPE_OBJ_FINAL_DECL; }; -struct FastpathCopy final : OpDefImplBase { - FastpathCopy() = default; - - size_t hash() const override { - return mgb::hash(this->dyn_typeinfo()); - } - - bool is_same_st(const Hashable& rhs) const override { - return this->dyn_typeinfo() == rhs.dyn_typeinfo(); - } - - MGB_DYN_TYPE_OBJ_FINAL_DECL; -}; - } // namespace mgb::imperative diff --git a/src/core/include/megbrain/ir/ops.td b/src/core/include/megbrain/ir/ops.td index a74af609a..7bb892e2e 100644 --- a/src/core/include/megbrain/ir/ops.td +++ b/src/core/include/megbrain/ir/ops.td @@ -375,4 +375,6 @@ def CvtColor: MgbHashableOp<"CvtColor", [CvtColorParam]>; def CheckHasInf: MgbHashableOp<"CheckHasInf", [EmptyParam]>; +def FastpathCopy: MgbHashableOp<"FastpathCopy">; + #endif // MGB_OPS -- GitLab