diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 382f36d430cf7f36e8d72768f51c1e6c7d80026a..331637f7725eb1379fccaec394b94bfa5505f703 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -203,8 +203,8 @@ add_library(megengine) target_link_libraries(megengine PRIVATE ${MGE_CUDA_LIBS}) target_link_libraries(megengine PUBLIC megbrain megdnn) if (UNIX AND NOT APPLE) - # TODO: Use target_link_options after upgrading to CMake 3.13 target_link_options(megengine PRIVATE -Wl,--no-undefined -Wl,--version-script=${_VER_FILE}) + set_target_properties(megengine PROPERTIES LINK_DEPENDS ${_VER_FILE}) endif() set_target_properties(megengine PROPERTIES CXX_VISIBILITY_PRESET default) set_target_properties(megengine PROPERTIES WINDOWS_EXPORT_ALL_SYMBOLS TRUE) diff --git a/src/version.ld b/src/version.ld index 876e7ddb6103e26c2b79f24a926f33f9b5dcb373..d8952e511c1325d6ce3a949064fbd5bd360476ec 100644 --- a/src/version.ld +++ b/src/version.ld @@ -10,6 +10,7 @@ global: *megdnn::*; *megcore::*; megcore*; + base_exceptions*; }; megcore*;