From acf28603411235041b5663be29900861d778810d Mon Sep 17 00:00:00 2001 From: Megvii Engine Team Date: Thu, 8 Apr 2021 18:38:37 +0800 Subject: [PATCH] fix(cmake): export more sym caused by we change exception namespace when disable rtti GitOrigin-RevId: c42f5adffde3c3cfaddda8ff73550b1ff5ab6e63 --- src/CMakeLists.txt | 2 +- src/version.ld | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 382f36d43..331637f77 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -203,8 +203,8 @@ add_library(megengine) target_link_libraries(megengine PRIVATE ${MGE_CUDA_LIBS}) target_link_libraries(megengine PUBLIC megbrain megdnn) if (UNIX AND NOT APPLE) - # TODO: Use target_link_options after upgrading to CMake 3.13 target_link_options(megengine PRIVATE -Wl,--no-undefined -Wl,--version-script=${_VER_FILE}) + set_target_properties(megengine PROPERTIES LINK_DEPENDS ${_VER_FILE}) endif() set_target_properties(megengine PROPERTIES CXX_VISIBILITY_PRESET default) set_target_properties(megengine PROPERTIES WINDOWS_EXPORT_ALL_SYMBOLS TRUE) diff --git a/src/version.ld b/src/version.ld index 876e7ddb6..d8952e511 100644 --- a/src/version.ld +++ b/src/version.ld @@ -10,6 +10,7 @@ global: *megdnn::*; *megcore::*; megcore*; + base_exceptions*; }; megcore*; -- GitLab