1. 09 1月, 2021 5 次提交
  2. 08 1月, 2021 2 次提交
  3. 07 1月, 2021 4 次提交
  4. 06 1月, 2021 5 次提交
  5. 05 1月, 2021 1 次提交
    • R
      gopls/internal/regtest: support multiple workspace folders · b0ab187a
      Rob Findley 提交于
      This change both simplifies the options used to configure workspace
      folders in regtests, and allows for configuring multiple workspace
      folders. The WithoutWorkspaceFolders, RootPath, and NestWorkdir options
      are all replaced by a single WorkspaceFolders option.
      
      NestWorkdir was always a bit too magical, modifying the execution
      directory within the runner itself. Instead, just explicitly move files
      down into a nested directory.
      
      runModfileTests was also a bit too much of a special case. Eliminate it
      by adding functionality to run multiple times with different options.
      Upon the way I started using literals to configure runs, and I think
      this is cleaner. Let me know what you think about runMultiple, etc.
      This overlaps with the execution modes, which could probably be
      eliminated in a later CL.
      
      For golang/go#42111
      
      Change-Id: I56915d8930bc47561cc827b918621cff4b994226
      Reviewed-on: https://go-review.googlesource.com/c/tools/+/276975
      Run-TryBot: Robert Findley <rfindley@google.com>
      gopls-CI: kokoro <noreply+kokoro@google.com>
      TryBot-Result: Go Bot <gobot@golang.org>
      Trust: Robert Findley <rfindley@google.com>
      Reviewed-by: NHeschi Kreinick <heschi@google.com>
      Reviewed-by: NRebecca Stambler <rstambler@golang.org>
      b0ab187a
  6. 04 1月, 2021 1 次提交
  7. 03 1月, 2021 1 次提交
  8. 02 1月, 2021 1 次提交
  9. 31 12月, 2020 6 次提交
    • R
      Revert "[gopls-release-branch.0.6] all: merge master into gopls-release-branch.0.6" · 63754364
      Rebecca Stambler 提交于
      This reverts commit 481d425b.
      
      Reason for revert: Merged to the wrong branch
      
      Change-Id: I1bed47cd0857c22af0238b6c6c8b87781c7ac49e
      Reviewed-on: https://go-review.googlesource.com/c/tools/+/280707
      Trust: Rebecca Stambler <rstambler@golang.org>
      Run-TryBot: Rebecca Stambler <rstambler@golang.org>
      gopls-CI: kokoro <noreply+kokoro@google.com>
      TryBot-Result: Go Bot <gobot@golang.org>
      Reviewed-by: NPeter Weinberger <pjw@google.com>
      Reviewed-by: NSuzy Mueller <suzmue@golang.org>
      63754364
    • R
      internal/lsp: save all possible keys for analyses, codelenses · 0af0626a
      Rebecca Stambler 提交于
      The possible keys for analyses and codelenses are too long to enumerate
      in settings, and we'd need to create enums for all possible analyzer
      and code lens names, which is probably not feasible. Instead, collect
      the list of possible values from the analyzers and command settings
      generation and add them to enum values.
      
      Also, handle default values by setting them in the enum keys instead of
      one big default value. Quite a few hacks to get this right, but maybe
      there are other better alternatives we can consider in the future.
      
      Fixes golang/go#42961
      
      Change-Id: I5c096862b5e8fb89fe5d6639b4f46c06492e49c4
      Reviewed-on: https://go-review.googlesource.com/c/tools/+/280355
      Trust: Rebecca Stambler <rstambler@golang.org>
      Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
      Run-TryBot: Rebecca Stambler <rstambler@golang.org>
      gopls-CI: kokoro <noreply+kokoro@google.com>
      TryBot-Result: Go Bot <gobot@golang.org>
      Reviewed-by: NHyang-Ah Hana Kim <hyangah@gmail.com>
      Reviewed-by: NSuzy Mueller <suzmue@golang.org>
      0af0626a
    • R
      internal/lsp: restructure user options (CL 278433 continued) · ee6d6aff
      Rebecca Stambler 提交于
      This CL copies Heschi's structural changes to the options from CL 278433
      and makes the necessary adjustments in the JSON and documentation
      generation. Nested settings are grouped together and the "status" of a
      given setting is also listed. Currently the only possible statuses are
      "experimental" and "debug", but I will add "advanced" in a follow-up (to
      indicate that a setting is only for advanced users).
      
      The options "set" function still expects flattened settings to avoid
      fundamentally changing people's current configurations, so VS Code Go
      will just have to make sure to flatten the settings before sending them
      to gopls (which should be easy enough).
      
      No names of any settings are changed (Heschi's earlier CL adjusted the
      experimental prefixes). As discussed offline, we've decided to prefix
      any setting that we expect to delete with "experimental", and so we'll
      leave existing setting names as they are.
      
      Updates golang/go#43101
      
      Change-Id: I55cf7ef09ce7b5b1f8af06fcadb4ba2a44ec9b17
      Reviewed-on: https://go-review.googlesource.com/c/tools/+/280192
      Trust: Rebecca Stambler <rstambler@golang.org>
      Run-TryBot: Rebecca Stambler <rstambler@golang.org>
      gopls-CI: kokoro <noreply+kokoro@google.com>
      TryBot-Result: Go Bot <gobot@golang.org>
      Reviewed-by: NSuzy Mueller <suzmue@golang.org>
      ee6d6aff
    • G
    • R
      gopls/internal/regtest: await file changes in TestUseGoplsMod · 4a19ffb6
      Rebecca Stambler 提交于
      Make sure metadata is reloaded after each file changed.
      
      Change-Id: If3900f6fc2f99ff4eaf81b82d39e01e9f5dcb68e
      Reviewed-on: https://go-review.googlesource.com/c/tools/+/280695
      Trust: Rebecca Stambler <rstambler@golang.org>
      Run-TryBot: Rebecca Stambler <rstambler@golang.org>
      gopls-CI: kokoro <noreply+kokoro@google.com>
      Reviewed-by: NRobert Findley <rfindley@google.com>
      TryBot-Result: Go Bot <gobot@golang.org>
      4a19ffb6
    • R
      [gopls-release-branch.0.6] all: merge master into gopls-release-branch.0.6 · 481d425b
      Rebecca Stambler 提交于
      ef3185ba internal/lsp/cache: add a check for snapshot invariants
      b8413747 internal/lsp: fix autocomplete appends on imports
      929a8494 internal/lsp: restructure the way we report critical errors
      fbbba25c gopls/doc: generate documentation for analyzers
      84d76fe3 internal/lsp: fix unimported completions with -mod=readonly
      0661ca7e gopls/internal/regtest: show line numbers if TestUseGoplsMod fails
      13ff2212 internal/lsp/cmd: include new name in rename help message
      0f6027f0 gopls/doc/vim.md: add table of contents, improve neovim docs
      34cd474b internal/lsp: use an enum for GC annotations settings
      b1c90890 internal/lsp/source: do not panic in "var func" outgoing callhierarchy
      2b0845dc gopls/release: add a command to validate the gopls release process
      57089f8f internal/lsp: remove dependencies using text edits when necessary
      834755c7 internal/lsp: add tests to set configuration options
      bdbb3c91 internal/lsp/cache: only reload the workspace on saved changes
      3e0a2b75 gopls/internal/regtest: skip a some new builders where regtests time out
      f6952e40 internal/lsp/cache: fix some package event tags
      9cbb1efa internal/lsp/source: add the shadow analyzer
      3fa0e8f8 gopls: disable TestTemplate on Android
      f2e330f4 gopls/test: add type checking for debug server templates
      19653561 internal/lsp/mod: fix misplaced code lens with individual requires
      b57d1c5b internal/lsp: return an error if code action has no title
      ae774e97 internal/lsp: don't show duplicate diagnostics for go.mod errors
      5b06639e internal/lsp/source: only show "run file benchmarks" if available
      11a5667e gopls/internal/regtest: test metadata validation only on save for go.mod
      5b43ef93 go/analysis/passes/fieldalignment: filter comments from suggested fix
      4b31ac34 gopls/internal/regtest: test that accepting fix removes diagnostics
      008e4774 internal/lsp, gopls: recover from go-diff panics
      48e5bd11 internal/lsp: add titles to `go mod tidy` and update go.sum fixes
      fa10ef0b internal/lsp/source: update codelenses example
      6307297f go/analysis/passes/fieldalignment: support fields without name
      
      Change-Id: I449fee8301240637662f60930fe8b20e133fdd81
      481d425b
  10. 30 12月, 2020 2 次提交
  11. 29 12月, 2020 7 次提交
  12. 27 12月, 2020 1 次提交
  13. 24 12月, 2020 4 次提交
    • R
      gopls/release: add a command to validate the gopls release process · 2b0845dc
      Rebecca Stambler 提交于
      The gopls release process has a number of steps which can be easily
      forgotten, but they are also easy enough to check. In the future, we can
      certainly automate this process further, but this basic program will
      validate that mistakes like golang/go#43256 are not made again in the
      future.
      
      Change-Id: I04641ae202bc6615f2e4c8810b5dab4885d37fd4
      Reviewed-on: https://go-review.googlesource.com/c/tools/+/279715
      Trust: Rebecca Stambler <rstambler@golang.org>
      Run-TryBot: Rebecca Stambler <rstambler@golang.org>
      gopls-CI: kokoro <noreply+kokoro@google.com>
      TryBot-Result: Go Bot <gobot@golang.org>
      Reviewed-by: NRobert Findley <rfindley@google.com>
      2b0845dc
    • R
      internal/lsp: remove dependencies using text edits when necessary · 57089f8f
      Rebecca Stambler 提交于
      golang/go#43335 explains the issues with using `go get module@none`,
      which will only be resolved in Go 1.17. In the meantime, we use the
      go command whenever possible, but if the module is not tidied, we
      have to use textual edits instead. This means the go.sum file will not
      be accurately updated to remove the dependency, but unfortunately, I
      don't believe there is anything that we can do in that case.
      
      Fixes golang/go#43335
      
      Change-Id: I771f68f34a6136e73e9dd82b692ed4c235c3b293
      Reviewed-on: https://go-review.googlesource.com/c/tools/+/279716
      Trust: Rebecca Stambler <rstambler@golang.org>
      Run-TryBot: Rebecca Stambler <rstambler@golang.org>
      gopls-CI: kokoro <noreply+kokoro@google.com>
      Reviewed-by: NRobert Findley <rfindley@google.com>
      57089f8f
    • M
      internal/lsp: add tests to set configuration options · 834755c7
      Matheus Alcantara 提交于
      Added some tests to hoverKind, matcher, env and directoryFilters
      of configuration options.
      
      I'm also add a validation on `env`configuration, to initialize the map if is nil to avoid the risk of inserting the values in a nil map. Please let me know if this validation is unnecessary.
      
      Fixes golang/go#34244
      
      Change-Id: I387ad0a393d981d070002c7e3736acad7b2191bf
      GitHub-Last-Rev: 4fe354754323471f3260f990a264807525b3571b
      GitHub-Pull-Request: golang/tools#261
      Reviewed-on: https://go-review.googlesource.com/c/tools/+/278072
      Trust: Robert Findley <rfindley@google.com>
      Trust: Rebecca Stambler <rstambler@golang.org>
      Run-TryBot: Rebecca Stambler <rstambler@golang.org>
      gopls-CI: kokoro <noreply+kokoro@google.com>
      TryBot-Result: Go Bot <gobot@golang.org>
      Reviewed-by: NRebecca Stambler <rstambler@golang.org>
      834755c7
    • R
      internal/lsp/cache: only reload the workspace on saved changes · bdbb3c91
      Rob Findley 提交于
      Invalidating the workspace on any change to a go.mod can render a
      workspace unusable. Only invalidate when changes are saved.
      
      Additionally, invalidate the workspace if there is a saved change to
      tracked go.sum changes.
      
      Fixes golang/go#42529
      Fixes golang/go#42815
      
      Change-Id: I5d903013b33b932eca4998513e3d0a534b2e5a61
      Reviewed-on: https://go-review.googlesource.com/c/tools/+/279720
      Run-TryBot: Robert Findley <rfindley@google.com>
      gopls-CI: kokoro <noreply+kokoro@google.com>
      TryBot-Result: Go Bot <gobot@golang.org>
      Trust: Robert Findley <rfindley@google.com>
      Reviewed-by: NRebecca Stambler <rstambler@golang.org>
      bdbb3c91