1. 16 5月, 2021 12 次提交
    • F
      Merge branch '5.2' into 5.x · bbb0a694
      Fabien Potencier 提交于
      * 5.2:
        [Finder] Fix gitignore regex build with "**"
        Fixed deprecation warnings about passing null as parameter
        [Security] Keep Bulgarian wording consistent across all texts.
        Migrate configuration file for PHP CS Fixer 2.19/3.0
        [Form] Replace broken ServerParams mock
        [Mailer] Fix SES API call with UTF-8 Addresses
      bbb0a694
    • F
      Merge branch '4.4' into 5.2 · e7692c50
      Fabien Potencier 提交于
      * 4.4:
        [Finder] Fix gitignore regex build with "**"
        Fixed deprecation warnings about passing null as parameter
        [Security] Keep Bulgarian wording consistent across all texts.
        Migrate configuration file for PHP CS Fixer 2.19/3.0
        [Form] Replace broken ServerParams mock
      e7692c50
    • F
      minor #41244 [Security] Keep Bulgarian wording consistent across all texts (Warxcell) · 907f1033
      Fabien Potencier 提交于
      This PR was merged into the 4.4 branch.
      
      Discussion
      ----------
      
      [Security] Keep Bulgarian wording consistent across all texts
      
      | Q             | A
      | ------------- | ---
      | Branch?       | 4.4
      | Bug fix?      | no
      | New feature?  | no
      | Deprecations? | no
      | Tickets       |
      | License       | MIT
      | Doc PR        |
      
      Keep wording consistent across all texts in translations:
      
      Trans unit id=17:
      Too many === Твърде много
      Trans unit id=19:
      Too many === Прекалено много
      
      I put word "Твърде", because it was used before.
      
      Commits
      -------
      
      4f1b4f99 [Security] Keep Bulgarian wording consistent across all texts.
      907f1033
    • F
      minor #41243 Migrate configuration file for PHP CS Fixer 2.19/3.0 (derrabus) · 518badd9
      Fabien Potencier 提交于
      This PR was merged into the 4.4 branch.
      
      Discussion
      ----------
      
      Migrate configuration file for PHP CS Fixer 2.19/3.0
      
      | Q             | A
      | ------------- | ---
      | Branch?       | 4.4
      | Bug fix?      | no
      | New feature?  | no
      | Deprecations? | no
      | Tickets       | N/A
      | License       | MIT
      | Doc PR        | N/A
      
      This PR suggests to rename the PHP CS Fixer configuration file as expected by version 2.19 and 3.0. I don't know what version Fabbot is currently running, but as soon as it is updated to 2.19, we can merge this PR.
      
      Commits
      -------
      
      1462a321 Migrate configuration file for PHP CS Fixer 2.19/3.0
      518badd9
    • F
      bug #41206 [Mailer] Fix SES API call with UTF-8 Addresses (jderusse) · 21b8cb7d
      Fabien Potencier 提交于
      This PR was merged into the 5.2 branch.
      
      Discussion
      ----------
      
      [Mailer] Fix SES API call with UTF-8 Addresses
      
      | Q             | A
      | ------------- | ---
      | Branch?       | 5.2
      | Bug fix?      | yes
      | New feature?  | no
      | Deprecations? | no
      | Tickets       | -
      | License       | MIT
      | Doc PR        | -
      
      The address (including email and name) used in Amazon SES API (`ses+api://`) must not contain unicode chars  (https://docs.aws.amazon.com/ses/latest/APIReference-V2/API_Destination.html)
      
      This PR encodes name with base64 as suggested by issues in Official AWS SDKs (https://github.com/aws/aws-sdk-php/issues/1196, https://github.com/aws/aws-sdk-js/issues/1585)
      
      note: I did not use the Base64Encoder, because the address could not be chunked (API Call failed) and it looks like addresses wider than 64 chars are allowed.
      
      Commits
      -------
      
      05a94972 [Mailer] Fix SES API call with UTF-8 Addresses
      21b8cb7d
    • F
      bug #41240 Fixed deprecation warnings about passing null as parameter (derrabus) · eb3a3c1c
      Fabien Potencier 提交于
      This PR was merged into the 4.4 branch.
      
      Discussion
      ----------
      
      Fixed deprecation warnings about passing null as parameter
      
      | Q             | A
      | ------------- | ---
      | Branch?       | 4.4
      | Bug fix?      | yes
      | New feature?  | no
      | Deprecations? | no
      | Tickets       | N/A
      | License       | MIT
      | Doc PR        | N/A
      
      Various built-in PHP functions will trigger a deprecation warning if `null` is passed as parameter. This PR attempts to fix all warnings that our test suite currently picks up.
      
      Commits
      -------
      
      7d9bdf57 Fixed deprecation warnings about passing null as parameter
      eb3a3c1c
    • F
      bug #41241 [Finder] Fix gitignore regex build with "**" (mvorisek) · 03519d40
      Fabien Potencier 提交于
      This PR was squashed before being merged into the 4.4 branch.
      
      Discussion
      ----------
      
      [Finder] Fix gitignore regex build with "**"
      
      | Q             | A
      | ------------- | ---
      | Branch?       | 4.4
      | Bug fix?      | yes
      | New feature?  | no
      | Deprecations? | no
      | Tickets       | Fix #41223
      | License       | MIT
      | Doc PR        | no
      
      covered with tests, also faster, we do not have to explode the rule at all :)
      
      ping `@lindelius` `@OskarStark`
      
      Commits
      -------
      
      ce22d5dd [Finder] Fix gitignore regex build with "**"
      03519d40
    • M
      [Finder] Fix gitignore regex build with "**" · ce22d5dd
      Michael Voříšek 提交于
      ce22d5dd
    • A
      7d9bdf57
    • N
      minor #41238 [Form] Replace broken ServerParams mock (derrabus) · d3ebc5fd
      Nicolas Grekas 提交于
      This PR was merged into the 4.4 branch.
      
      Discussion
      ----------
      
      [Form] Replace broken ServerParams mock
      
      | Q             | A
      | ------------- | ---
      | Branch?       | 4.4
      | Bug fix?      | yes
      | New feature?  | no
      | Deprecations? | no
      | Tickets       | N/A
      | License       | MIT
      | Doc PR        | N/A
      
      `AbstractRequestHandlerTest` creates a mocked version of the `ServerParams` class. Since `getNormalizedIniPostMaxSize()` does not have a return type declaration, PHPUnit will by default create an implementation that always returns `null`. However, the real implementation of that method guarantees to always return a string.
      
      This becomes problematic in PHP 8.1 because the return value is sometimes passed as-is into functions like `strtolower()` which trigger a deprecation warning on `null` now.
      
      This PR proposes to replace the mock with a dummy implementation that returns an empty string by default.
      
      Commits
      -------
      
      77c2d69f [Form] Replace broken ServerParams mock
      d3ebc5fd
    • W
      4f1b4f99
    • A
      1462a321
  2. 15 5月, 2021 18 次提交
    • A
      [Form] Replace broken ServerParams mock · 77c2d69f
      Alexander M. Turek 提交于
      77c2d69f
    • A
      Merge branch '5.2' into 5.x · 8ed99642
      Alexander M. Turek 提交于
      * 5.2:
        Update .github/workflows/tests.yml
        Don't call class_exists() on null
        Added and improved Bulgarian translations
        PHP 8.1 must not cause the build to fail (yet)
        Add _run_tests bash function
        Add a GitHub Action for tests against PHP 8.1
        [HttpClient] fix adding query string to relative URLs with scoped clients
        [Security] Added Ukrainian translations
      8ed99642
    • A
      Merge branch '4.4' into 5.2 · ec761d6b
      Alexander M. Turek 提交于
      * 4.4:
        Update .github/workflows/tests.yml
        Don't call class_exists() on null
        Added and improved Bulgarian translations
        PHP 8.1 must not cause the build to fail (yet)
        Add _run_tests bash function
        Add a GitHub Action for tests against PHP 8.1
        [HttpClient] fix adding query string to relative URLs with scoped clients
        [Security] Added Ukrainian translations
      ec761d6b
    • N
      minor #41080 Add a GitHub Action for tests against PHP 8.1 (derrabus, Nyholm) · dffdc71a
      Nyholm 提交于
      This PR was merged into the 4.4 branch.
      
      Discussion
      ----------
      
      Add a GitHub Action for tests against PHP 8.1
      
      | Q             | A
      | ------------- | ---
      | Branch?       | 4.4
      | Bug fix?      | no
      | New feature?  | no
      | Deprecations? | no
      | Tickets       | N/A
      | License       | MIT
      | Doc PR        | N/A
      
      I'd like to monitor our compatibility with the upcoming PHP 8.1 release. Because I failed miserably at convincing Travis to run our tests with PHP 8.1 (see #40532), I tried to do the same with GitHub Actions.
      
      Commits
      -------
      
      6a328ae0 Update .github/workflows/tests.yml
      6f1c4b8c PHP 8.1 must not cause the build to fail (yet)
      b0b45105 Add _run_tests bash function
      de4f0170 Add a GitHub Action for tests against PHP 8.1
      dffdc71a
    • J
      [Mailer] Fix SES API call with UTF-8 Addresses · 05a94972
      Jérémy Derussé 提交于
      05a94972
    • T
      Update .github/workflows/tests.yml · 6a328ae0
      Tobias Nyholm 提交于
      6a328ae0
    • N
      bug #41224 [HttpClient] fix adding query string to relative URLs with scoped... · 3b0c6f9a
      Nicolas Grekas 提交于
      bug #41224 [HttpClient] fix adding query string to relative URLs with scoped clients (nicolas-grekas)
      
      This PR was merged into the 4.4 branch.
      
      Discussion
      ----------
      
      [HttpClient] fix adding query string to relative URLs with scoped clients
      
      | Q             | A
      | ------------- | ---
      | Branch?       | 4.4
      | Bug fix?      | yes
      | New feature?  | no
      | Deprecations? | no
      | Tickets       | Fix #41220
      | License       | MIT
      | Doc PR        | -
      
      Commits
      -------
      
      5ccba2c3 [HttpClient] fix adding query string to relative URLs with scoped clients
      3b0c6f9a
    • N
      bug #41233 [DependencyInjection][ProxyManagerBridge] Don't call class_exists() on null (derrabus) · 9e12a383
      Nicolas Grekas 提交于
      This PR was merged into the 4.4 branch.
      
      Discussion
      ----------
      
      [DependencyInjection][ProxyManagerBridge] Don't call class_exists() on null
      
      | Q             | A
      | ------------- | ---
      | Branch?       | 4.4
      | Bug fix?      | yes
      | New feature?  | no
      | Deprecations? | no
      | Tickets       | N/A
      | License       | MIT
      | Doc PR        | N/A
      
      PHP 8.1 complains if we pass `null` to `class_exists()` or `interface_exists()`:
      
      > class_exists(): Passing null to parameter `#1` ($class) of type string is deprecated
      
      Commits
      -------
      
      88520e53 Don't call class_exists() on null
      9e12a383
    • N
      minor #41192 [Security] Added Ukrainian translations (andrii-bodnar) · a7d35336
      Nyholm 提交于
      This PR was merged into the 4.4 branch.
      
      Discussion
      ----------
      
      [Security] Added Ukrainian translations
      
      | Q             | A
      | ------------- | ---
      | Branch?       | 4.4 <!-- see below -->
      | Bug fix?      | no
      | New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
      | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
      | Tickets       | Fix #41088 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
      | License       | MIT
      | Doc PR        | <!-- required for new features -->
      
      Added some missing Ukrainian translations.
      
      Commits
      -------
      
      8f34572a [Security] Added Ukrainian translations
      a7d35336
    • N
      minor #41231 [Security] Added and improved Bulgarian translations (I-Valchev) · 4289ab9f
      Nyholm 提交于
      This PR was merged into the 4.4 branch.
      
      Discussion
      ----------
      
      [Security] Added and improved Bulgarian translations
      
      | Q             | A
      | ------------- | ---
      | Branch?       | 4.4
      | Bug fix?      | no
      | New feature?  | no
      | Deprecations? |no
      | Tickets       | Fix #41035
      | License       | MIT
      | Doc PR        | n/a
      
      Added missing translations for id 19 and 20.
      Replaced the word "incorrect" with "unsuccessful"/"failed" for id 17.
      Replaced the phonetic use of "cookie" with the word for "cookie" in Bulgarian for id 5 and 10.
      Fixed grammatical error, now use the definite article ("the") instead of the indefinine for id 11, 13, 15 and 16.
      
      Commits
      -------
      
      b79962b6 Added and improved Bulgarian translations
      4289ab9f
    • A
      Don't call class_exists() on null · 88520e53
      Alexander M. Turek 提交于
      88520e53
    • A
      Merge branch '5.2' into 5.x · 7e9c7e0d
      Alexander M. Turek 提交于
      * 5.2:
        Introduce SYMFONY_FEATURE_BRANCH variable in Travis config
      7e9c7e0d
    • A
      Merge branch '4.4' into 5.2 · be28e226
      Alexander M. Turek 提交于
      * 4.4:
        Introduce SYMFONY_FEATURE_BRANCH variable in Travis config
      be28e226
    • A
      minor #41228 Introduce SYMFONY_FEATURE_BRANCH variable in Travis config (derrabus) · 9c3ee3d8
      Alexander M. Turek 提交于
      This PR was squashed before being merged into the 4.4 branch.
      
      Discussion
      ----------
      
      Introduce SYMFONY_FEATURE_BRANCH variable in Travis config
      
      | Q             | A
      | ------------- | ---
      | Branch?       | 4.4
      | Bug fix?      | no
      | New feature?  | no
      | Deprecations? | no
      | Tickets       | #40887
      | License       | MIT
      | Doc PR        | not needed
      
      This PR proposes to introduce a `SYMFONY_FEATURE_BRANCH` variable that always points to the branch of Symfony's next feature release. This is a setting that we need to adjust twice a year. This way, the branch does not have to follow the `.x` suffix convention anymore.
      
      ~~I'm currently testing my changes against the 5.x branch. As soon as the PR is ready, I will target 4.4.~~
      
      Update: `SYMFONY_FEATURE_BRANCH` is now populated via an API request.
      
      Commits
      -------
      
      7de11c0e Introduce SYMFONY_FEATURE_BRANCH variable in Travis config
      9c3ee3d8
    • A
      7de11c0e
    • I
      Added and improved Bulgarian translations · b79962b6
      Ivo Valchev 提交于
      b79962b6
    • A
      PHP 8.1 must not cause the build to fail (yet) · 6f1c4b8c
      Alexander M. Turek 提交于
      6f1c4b8c
    • A
      Add _run_tests bash function · b0b45105
      Alexander M. Turek 提交于
      b0b45105
  3. 14 5月, 2021 4 次提交
  4. 13 5月, 2021 6 次提交
    • A
      [Security] Added Ukrainian translations · 8f34572a
      Andrii Bodnar 提交于
      8f34572a
    • R
      minor #41216 [Security\Guard] Fix test (chalasr) · e41aacd1
      Robin Chalas 提交于
      This PR was merged into the 5.3-dev branch.
      
      Discussion
      ----------
      
      [Security\Guard] Fix test
      
      | Q             | A
      | ------------- | ---
      | Branch?       | 5.x
      | Bug fix?      | no
      | New feature?  | no
      | Deprecations? | no
      | Tickets       | -
      | License       | MIT
      | Doc PR        | -
      
      Commits
      -------
      
      94cf3993 [Security\Guard] Fix test
      e41aacd1
    • R
      bug #41214 [Console] fix registering command aliases when using the new... · c61617e6
      Robin Chalas 提交于
      bug #41214 [Console] fix registering command aliases when using the new "cmd|alias" syntax for names (nicolas-grekas)
      
      This PR was merged into the 5.3-dev branch.
      
      Discussion
      ----------
      
      [Console] fix registering command aliases when using the new "cmd|alias" syntax for names
      
      | Q             | A
      | ------------- | ---
      | Branch?       | 5.x
      | Bug fix?      | yes
      | New feature?  | no
      | Deprecations? | no
      | Tickets       | Fix #41212
      | License       | MIT
      | Doc PR        | -
      
      Commits
      -------
      
      6633b955 [Console] fix registering command aliases when using the new "cmd|alias" syntax for names
      c61617e6
    • R
      [Security\Guard] Fix test · 94cf3993
      Robin Chalas 提交于
      94cf3993
    • N
      minor #41097 [Security] Missing lt translations (rmikalkenas) · 90666777
      Nyholm 提交于
      This PR was merged into the 4.4 branch.
      
      Discussion
      ----------
      
      [Security] Missing lt translations
      
      | Q             | A
      | ------------- | ---
      | Branch?       | 4.4
      | Bug fix?      | no
      | New feature?  | no
      | Deprecations? | no
      | Tickets       | Fix #41054
      | License       | MIT
      
      For minute/minutes translation I decided to use "min." abbreviation, because in lithuanian language the plural translation might not always match the word case.
      For example:
      1 minute -> 1 minutė
      2 minutes -> 2 minutės
      ...
      10 minutes -> 10 minučių
      ...
      21 minutes -> 21 minutė
      22 minutes -> 22 minutės
      ...
      30 minutes -> 30 minučių
      
      and so on...
      
      Commits
      -------
      
      f2dedd8a Missing security lt translations added
      90666777
    • N
      bug #41211 [Notifier] Add missing charset to content-type for Slack notifier (norkunas) · 35dbf8c8
      Nyholm 提交于
      This PR was merged into the 5.2 branch.
      
      Discussion
      ----------
      
      [Notifier] Add missing charset to content-type for Slack notifier
      
      | Q             | A
      | ------------- | ---
      | Branch?       | 5.2
      | Bug fix?      | yes
      | New feature?  | no
      | Deprecations? | no
      | Tickets       | N/A
      | License       | MIT
      | Doc PR        | N/A
      
      Symfony HttpClient doesn't set charset for the Content-Type header when used with `json` request option so with each response slack includes:
      ```
      "response_metadata" => array:1 [
        "warnings" => array:1 [
          0 => "missing_charset"
        ]
      ]
      ```
      
      Commits
      -------
      
      e642100e Add missing charset to content-type for Slack notifier
      35dbf8c8