From cae55bfc68bed0a2d562891f11a75bf2145eb81e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ulf=20M=C3=B6ller?= Date: Sun, 6 Feb 2000 15:56:59 +0000 Subject: [PATCH] Improve bntest slightly, and fix another bug in the BN library. --- CHANGES | 7 ++ crypto/bn/bn_ctx.c | 2 +- crypto/bn/bn_recp.c | 1 + crypto/bn/bntest.c | 181 +++++++++++++++++---------- doc/crypto/BN_mod_mul_reciprocal.pod | 13 +- test/Makefile.ssl | 13 +- 6 files changed, 137 insertions(+), 80 deletions(-) diff --git a/CHANGES b/CHANGES index d7e012babb..91d89b795b 100644 --- a/CHANGES +++ b/CHANGES @@ -4,6 +4,13 @@ Changes between 0.9.4 and 0.9.5 [xx XXX 2000] + *) Bug fix for BN_div_recp() for numerators with an even number of + bits. + [Ulf Möller] + + *) More tests in bntest.c, and changed test_bn output. + [Ulf Möller] + *) ./config recognizes MacOS X now. [Andy Polyakov] diff --git a/crypto/bn/bn_ctx.c b/crypto/bn/bn_ctx.c index 93d08152f7..46132fd180 100644 --- a/crypto/bn/bn_ctx.c +++ b/crypto/bn/bn_ctx.c @@ -119,7 +119,7 @@ BIGNUM *BN_CTX_get(BN_CTX *ctx) if (!ctx->too_many) { BNerr(BN_F_BN_CTX_GET,BN_R_TOO_MANY_TEMPORARY_VARIABLES); - /* disable error code until SSL_CTX_end is called: */ + /* disable error code until BN_CTX_end is called: */ ctx->too_many = 1; } return NULL; diff --git a/crypto/bn/bn_recp.c b/crypto/bn/bn_recp.c index e1919e3ce6..80539c5e2c 100644 --- a/crypto/bn/bn_recp.c +++ b/crypto/bn/bn_recp.c @@ -158,6 +158,7 @@ int BN_div_recp(BIGNUM *dv, BIGNUM *rem, BIGNUM *m, BN_RECP_CTX *recp, * */ i=BN_num_bits(m); + if (i%2) i--; j=recp->num_bits*2; if (j > i) diff --git a/crypto/bn/bntest.c b/crypto/bn/bntest.c index 7a0e154d34..fd63bd6fd5 100644 --- a/crypto/bn/bntest.c +++ b/crypto/bn/bntest.c @@ -72,6 +72,10 @@ #include "../bio/bss_file.c" #endif +const num0 = 100; /* number of tests */ +const num1 = 50; /* additional tests for some functions */ +const num2 = 5; /* number of tests for slow functions */ + int test_add(BIO *bp); int test_sub(BIO *bp); int test_lshift1(BIO *bp); @@ -100,6 +104,16 @@ static unsigned char lst[]="\xC6\x4F\x43\x04\x2A\xEA\xCA\x6E\x58\x36\x80\x5B\xE8 static const char rnd_seed[] = "string to make the random number generator think it has entropy"; +void message(BIO *out, char *m) + { + fprintf(stderr, "test %s\n", m); +#if 1 + BIO_puts(out, "print \"test "); + BIO_puts(out, m); + BIO_puts(out, "\\n\"\n"); +#endif + } + int main(int argc, char *argv[]) { BN_CTX *ctx; @@ -149,68 +163,68 @@ int main(int argc, char *argv[]) if (!results) BIO_puts(out,"obase=16\nibase=16\n"); - fprintf(stderr,"test BN_add\n"); + message(out,"BN_add"); if (!test_add(out)) goto err; fflush(stdout); - fprintf(stderr,"test BN_sub\n"); + message(out,"BN_sub"); if (!test_sub(out)) goto err; fflush(stdout); - fprintf(stderr,"test BN_lshift1\n"); + message(out,"BN_lshift1"); if (!test_lshift1(out)) goto err; fflush(stdout); - fprintf(stderr,"test BN_lshift (fixed)\n"); + message(out,"BN_lshift (fixed)"); if (!test_lshift(out,ctx,BN_bin2bn(lst,sizeof(lst)-1,NULL))) goto err; fflush(stdout); - fprintf(stderr,"test BN_lshift\n"); + message(out,"BN_lshift"); if (!test_lshift(out,ctx,NULL)) goto err; fflush(stdout); - fprintf(stderr,"test BN_rshift1\n"); + message(out,"BN_rshift1"); if (!test_rshift1(out)) goto err; fflush(stdout); - fprintf(stderr,"test BN_rshift\n"); + message(out,"BN_rshift"); if (!test_rshift(out,ctx)) goto err; fflush(stdout); - fprintf(stderr,"test BN_sqr\n"); + message(out,"BN_sqr"); if (!test_sqr(out,ctx)) goto err; fflush(stdout); - fprintf(stderr,"test BN_mul\n"); + message(out,"BN_mul"); if (!test_mul(out)) goto err; fflush(stdout); - fprintf(stderr,"test BN_div\n"); + message(out,"BN_div"); if (!test_div(out,ctx)) goto err; fflush(stdout); - fprintf(stderr,"test BN_div_recp\n"); + message(out,"BN_div_recp"); if (!test_div_recp(out,ctx)) goto err; fflush(stdout); - fprintf(stderr,"test BN_mod\n"); + message(out,"BN_mod"); if (!test_mod(out,ctx)) goto err; fflush(stdout); - fprintf(stderr,"test BN_mod_mul\n"); + message(out,"BN_mod_mul"); if (!test_mod_mul(out,ctx)) goto err; fflush(stdout); - fprintf(stderr,"test BN_mont\n"); + message(out,"BN_mont"); if (!test_mont(out,ctx)) goto err; fflush(stdout); - fprintf(stderr,"test BN_mod_exp\n"); + message(out,"BN_mod_exp"); if (!test_mod_exp(out,ctx)) goto err; fflush(stdout); - fprintf(stderr,"test BN_exp\n"); + message(out,"BN_exp"); if (!test_exp(out,ctx)) goto err; fflush(stdout); @@ -222,7 +236,7 @@ int main(int argc, char *argv[]) err: BIO_puts(out,"1\n"); /* make sure bc fails if we are piping to it */ ERR_load_crypto_strings(); - ERR_print_errors(out); + ERR_print_errors_fp(stderr); exit(1); return(1); } @@ -238,7 +252,7 @@ int test_add(BIO *bp) BN_init(&c); BN_rand(&a,512,0,0); - for (i=0; i<100; i++) + for (i=0; iN)); BN_sub(&d,&d,&A); if(!BN_is_zero(&d)) { - BIO_puts(bp,"Montgomery multiplication test failed!\n"); + fprintf(stderr,"Montgomery multiplication test failed!\n"); return 0; } } @@ -636,7 +682,7 @@ int test_mod(BIO *bp, BN_CTX *ctx) e=BN_new(); BN_rand(a,1024,0,0); /**/ - for (i=0; i<20; i++) + for (i=0; ineg=rand_neg(); @@ -661,7 +707,7 @@ int test_mod(BIO *bp, BN_CTX *ctx) BN_sub(e,e,c); if(!BN_is_zero(e)) { - BIO_puts(bp,"Modulo test failed!\n"); + fprintf(stderr,"Modulo test failed!\n"); return 0; } } @@ -685,9 +731,8 @@ int test_mod_mul(BIO *bp, BN_CTX *ctx) e=BN_new(); BN_rand(c,1024,0,0); /**/ - for (i=0; i<10; i++) + for (i=0; ineg=rand_neg(); b->neg=rand_neg(); @@ -723,7 +768,7 @@ int test_mod_mul(BIO *bp, BN_CTX *ctx) BN_div(a,b,d,c,ctx); if(!BN_is_zero(b)) { - BIO_puts(bp,"Modulo multiply test failed!\n"); + fprintf(stderr,"Modulo multiply test failed!\n"); return 0; } } @@ -747,7 +792,7 @@ int test_mod_exp(BIO *bp, BN_CTX *ctx) e=BN_new(); BN_rand(c,30,0,1); /* must be odd for montgomery */ - for (i=0; i<6; i++) + for (i=0; ineg=rand_neg(); } - for (i=0; i<70; i++) + for (i=0; ineg=rand_neg(); - for (i=0; i<70; i++) + for (i=0; ineg=rand_neg(); - for (i=0; i<70; i++) + for (i=0; ineg=rand_neg(); - for (i=0; i<70; i++) + for (i=0; i. BN_RECP_CTX_free() frees the components of the B, and, if it was created by BN_RECP_CTX_new(), also the structure itself. -BN_RECP_CTX_set() computes 1/B and shifts it left by -BN_num_bits(B)+1 to make it an integer. The result and the -number of bits it was shifted left are stored in B. +BN_RECP_CTX_set() stores B in B and sets it up for computing +1/B and shifting it left by BN_num_bits(B)+1 to make it an +integer. The result and the number of bits it was shifted left will +later be stored in B. + +BN_div_recp() divides B by B using B. It places the quotient +in B and the remainder in B. The B structure is defined as follows: diff --git a/test/Makefile.ssl b/test/Makefile.ssl index 6607f63f9d..a3386d9a7e 100644 --- a/test/Makefile.ssl +++ b/test/Makefile.ssl @@ -13,6 +13,7 @@ INSTALLTOP= /usr/local/ssl MAKEFILE= Makefile.ssl MAKE= make -f $(MAKEFILE) MAKEDEPEND= $(TOP)/util/domd $(TOP) +PERL= perl PEX_LIBS= EX_LIBS= #-lnsl -lsocket @@ -180,14 +181,10 @@ test_pkcs7: test_bn: @echo starting big number library test, could take a while... -# This *should* work: -# @(./$(BNTEST)|bc) | awk '{ \ -# Some broken bc's treat the pipe as a terminal :-( -# By using a temporary file, errors detected by awk may be farther away from -# the test that caused them; but even with the pipe there'd be some distance. - @(./$(BNTEST) >tmp.bntest; echo quit >>tmp.bntest; bc tmp.bntest) | awk '{ \ -if ($$0 != "0") {print "error"; exit(1); } \ -if (((NR+1)%64) == 0) print NR+1," tests done"; }' + @./$(BNTEST) >tmp.bntest + @echo quit >>tmp.bntest + @echo "running bc" + @bc tmp.bntest 2>&1 | $(PERL) -e 'while () {if (/^test (.*)/) {print STDERR "\nverify $$1";} elsif (!/^0$$/) {die "\nFailed! bc: $$_";} print STDERR "."; $$i++;} print STDERR "\n$$i tests passed\n"' @echo 'test a^b%c implementations' ./$(EXPTEST) -- GitLab