From 751bb45a0a4ca4ab3baf5e5037c0b10f0430aeb6 Mon Sep 17 00:00:00 2001 From: Kitson Kelly Date: Wed, 23 Sep 2020 11:39:20 +1000 Subject: [PATCH] fix: ignore fileExists in tsc host (#7635) Fixes #7630 --- cli/tests/fix_tsc_file_exists.out | 1 + cli/tests/integration_tests.rs | 5 +++++ cli/tests/tsc/a.js | 2 ++ cli/tests/tsc/d.ts | 3 +++ cli/tests/tsc/node_modules/b.js | 2 ++ cli/tests/tsc/node_modules/c.js | 1 + cli/tests/tsc/test.js | 4 ++++ cli/tsc/99_main_compiler.js | 5 +++-- tools/lint.py | 7 ++++--- 9 files changed, 25 insertions(+), 5 deletions(-) create mode 100644 cli/tests/fix_tsc_file_exists.out create mode 100644 cli/tests/tsc/a.js create mode 100644 cli/tests/tsc/d.ts create mode 100644 cli/tests/tsc/node_modules/b.js create mode 100644 cli/tests/tsc/node_modules/c.js create mode 100644 cli/tests/tsc/test.js diff --git a/cli/tests/fix_tsc_file_exists.out b/cli/tests/fix_tsc_file_exists.out new file mode 100644 index 00000000..ce013625 --- /dev/null +++ b/cli/tests/fix_tsc_file_exists.out @@ -0,0 +1 @@ +hello diff --git a/cli/tests/integration_tests.rs b/cli/tests/integration_tests.rs index 7e0e020d..4ec816c4 100644 --- a/cli/tests/integration_tests.rs +++ b/cli/tests/integration_tests.rs @@ -2378,6 +2378,11 @@ itest!(fix_js_imports { output: "fix_js_imports.ts.out", }); +itest!(fix_tsc_file_exists { + args: "run --quiet --reload tsc/test.js", + output: "fix_tsc_file_exists.out", +}); + itest!(es_private_fields { args: "run --quiet --reload es_private_fields.js", output: "es_private_fields.js.out", diff --git a/cli/tests/tsc/a.js b/cli/tests/tsc/a.js new file mode 100644 index 00000000..5a7b3ff9 --- /dev/null +++ b/cli/tests/tsc/a.js @@ -0,0 +1,2 @@ +import { v4 } from "./d.ts"; +export function a() {} diff --git a/cli/tests/tsc/d.ts b/cli/tests/tsc/d.ts new file mode 100644 index 00000000..3c74b8c8 --- /dev/null +++ b/cli/tests/tsc/d.ts @@ -0,0 +1,3 @@ +export function v4() { + return "hello"; +} diff --git a/cli/tests/tsc/node_modules/b.js b/cli/tests/tsc/node_modules/b.js new file mode 100644 index 00000000..19166093 --- /dev/null +++ b/cli/tests/tsc/node_modules/b.js @@ -0,0 +1,2 @@ +import c from "./c.js"; +export { c }; diff --git a/cli/tests/tsc/node_modules/c.js b/cli/tests/tsc/node_modules/c.js new file mode 100644 index 00000000..cff71c44 --- /dev/null +++ b/cli/tests/tsc/node_modules/c.js @@ -0,0 +1 @@ +export default function c() {} diff --git a/cli/tests/tsc/test.js b/cli/tests/tsc/test.js new file mode 100644 index 00000000..b7f46b35 --- /dev/null +++ b/cli/tests/tsc/test.js @@ -0,0 +1,4 @@ +import { a } from "./a.js"; +import { c } from "./node_modules/b.js"; + +console.log("hello"); diff --git a/cli/tsc/99_main_compiler.js b/cli/tsc/99_main_compiler.js index 63a5d1f5..94a08e6a 100644 --- a/cli/tsc/99_main_compiler.js +++ b/cli/tsc/99_main_compiler.js @@ -278,8 +278,9 @@ delete Object.prototype.__proto__; /* TypeScript CompilerHost APIs */ - fileExists(_fileName) { - return notImplemented(); + fileExists(fileName) { + log(`compiler::host.fileExists("${fileName}")`); + return false; } getCanonicalFileName(fileName) { diff --git a/tools/lint.py b/tools/lint.py index e7f96714..76f51404 100755 --- a/tools/lint.py +++ b/tools/lint.py @@ -66,13 +66,14 @@ def eslint(): ":!:cli/tests/swc_syntax_error.ts", ":!:std/**/testdata/*", ":!:std/**/node_modules/*", + ":!:cli/bench/node*.js", ":!:cli/compilers/wasm_wrap.js", + ":!:cli/dts/**", + ":!:cli/tests/encoding/**", ":!:cli/tests/error_syntax.js", ":!:cli/tests/lint/**", - ":!:cli/tests/encoding/**", - ":!:cli/dts/**", + ":!:cli/tests/tsc/**", ":!:cli/tsc/*typescript.js", - ":!:cli/bench/node*.js", ]) if source_files: max_command_len = 30000 -- GitLab