From 313e63a959dd96fa6d285a3b51dad197daf4a739 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rafael=20Mendon=C3=A7a=20Fran=C3=A7a?= Date: Mon, 19 Aug 2019 16:53:01 -0400 Subject: [PATCH] Generate keep file in tmp/pids Since 9c913116c634fe5fe2159a94b8f1a244801a4877, if you run `rackup` in a machine that doesn't have that folder, the server will not start. This doesn't happen on `rails s` because we create that folder when starting the server on https://github.com/rails/rails/blob/8c8b02784a637570451d7810fd3dfed4eae9a77d/railties/lib/rails/commands/server/server_command.rb#L70-L74. --- railties/lib/rails/generators/rails/app/app_generator.rb | 1 + railties/test/generators/app_generator_test.rb | 1 + 2 files changed, 2 insertions(+) diff --git a/railties/lib/rails/generators/rails/app/app_generator.rb b/railties/lib/rails/generators/rails/app/app_generator.rb index c91106ab82..62e081d79a 100644 --- a/railties/lib/rails/generators/rails/app/app_generator.rb +++ b/railties/lib/rails/generators/rails/app/app_generator.rb @@ -232,6 +232,7 @@ def system_test def tmp empty_directory_with_keep_file "tmp" + empty_directory_with_keep_file "tmp/pids" empty_directory "tmp/cache" empty_directory "tmp/cache/assets" end diff --git a/railties/test/generators/app_generator_test.rb b/railties/test/generators/app_generator_test.rb index 262704c20e..130c9b89fa 100644 --- a/railties/test/generators/app_generator_test.rb +++ b/railties/test/generators/app_generator_test.rb @@ -950,6 +950,7 @@ def test_create_keeps test/helpers test/integration tmp + tmp/pids ) folders_with_keep.each do |folder| assert_file("#{folder}/.keep") -- GitLab