diff --git a/.github/ISSUE_TEMPLATE/enhancement.md b/.github/ISSUE_TEMPLATE/enhancement.md new file mode 100644 index 0000000000000000000000000000000000000000..74ed61e07a8e7547fbdeadbd8168c0d2eff7d44a --- /dev/null +++ b/.github/ISSUE_TEMPLATE/enhancement.md @@ -0,0 +1,15 @@ +--- +name: "Enhancement request" +about: Suggest an enhancement idea for Milvus +title: '' +labels: '' +assignees: '' + +--- + +**Please state your issue using the following template and, most importantly, in English.** + +**What would you like to be added ?** + +**Why is this needed ?** + diff --git a/ci/jenkins/Jenkinsfile b/ci/jenkins/Jenkinsfile index 48cf613de8aba44efd65a5892209dbe8576be3ec..5672e152714798872cf1d5f1dcd05348f9545b79 100644 --- a/ci/jenkins/Jenkinsfile +++ b/ci/jenkins/Jenkinsfile @@ -97,6 +97,7 @@ pipeline { TARGET_REPO = "${params.DOKCER_REGISTRY_URL}/milvus/engine" SOURCE_TAG = "${CHANGE_TARGET ? CHANGE_TARGET : SEMVER}-${BINARY_VERSION}-${OS_NAME}-${LOWER_BUILD_TYPE}" TARGET_TAG = "${SEMVER}-${BINARY_VERSION}-${OS_NAME}-${LOWER_BUILD_TYPE}" + DOCKER_BUILDKIT = 1 } agent { kubernetes { diff --git a/core/src/scheduler/resource/Resource.cpp b/core/src/scheduler/resource/Resource.cpp index 395a48d72b7b9a4a693880f1bcf1ccb14c3f2d7c..f34aadab3eff936b267a0453b7eec6d0a5c24b48 100644 --- a/core/src/scheduler/resource/Resource.cpp +++ b/core/src/scheduler/resource/Resource.cpp @@ -217,6 +217,8 @@ Resource::executor_function() { ResMgrInst::GetInstance()->GetResource("disk")->WakeupLoader(); } + task_item->task = FinishedTask::Create(task_item->task); + if (subscriber_) { auto event = std::make_shared(shared_from_this(), task_item); subscriber_(std::static_pointer_cast(event)); diff --git a/core/src/scheduler/task/FinishedTask.cpp b/core/src/scheduler/task/FinishedTask.cpp index 46a42053c64ba00b2b7c54b8dbfcbb99fdaa2b51..264a6270bdf89e34ddf92527b3a91beaa6af3c66 100644 --- a/core/src/scheduler/task/FinishedTask.cpp +++ b/core/src/scheduler/task/FinishedTask.cpp @@ -14,11 +14,14 @@ namespace milvus::scheduler { std::shared_ptr -FinishedTask::Create() { - return std::make_shared(); +FinishedTask::Create(const TaskPtr& task) { + return std::make_shared(task); } -FinishedTask::FinishedTask() : Task(TaskType::SearchTask, nullptr) { +FinishedTask::FinishedTask(const TaskPtr& task) : Task(TaskType::SearchTask, nullptr) { + Task::task_path_ = task->task_path_; + Task::type_ = task->type_; + Task::label_ = task->label_; } Status diff --git a/core/src/scheduler/task/FinishedTask.h b/core/src/scheduler/task/FinishedTask.h index 0fa36c2e95ed0cf9154f3fa6b415c13e07c2b682..fdc6d2876a2c45adfdf076f4a2e4a669c86d5d5a 100644 --- a/core/src/scheduler/task/FinishedTask.h +++ b/core/src/scheduler/task/FinishedTask.h @@ -20,10 +20,10 @@ namespace milvus::scheduler { class FinishedTask : public Task { public: static std::shared_ptr - Create(); + Create(const TaskPtr& task); public: - FinishedTask(); + explicit FinishedTask(const TaskPtr& task); Status OnLoad(LoadType type, uint8_t device_id) override;