diff --git a/doc/release_notes.md b/doc/release_notes.md index 518fff4c0b7658228f53bb1f2676fb8852a1eb07..374151dd82ea724706bc773187d2f1e54ca73a15 100644 --- a/doc/release_notes.md +++ b/doc/release_notes.md @@ -421,8 +421,9 @@ OpenPose Library - Release Notes 3. Added Asynchronous mode to Python API. 4. Added `DOWNLOAD_SERVER` variable to CMake. It specifies the link where the models and 3rd party libraries will be downloaded from. 5. Installation documentation highly simplified and improved. - 6. Removed all compiler warnings for Ubuntu 20.04 and removed some for Windows 10. + 6. Removed all compiler warnings for Ubuntu 20.04 (GCC and Clang) as well as some for Windows 10. 2. Functions or parameters renamed: + 1. `USE_MKL` disabled by default in Ubuntu. Reason: Not compatible with non-intel CPUs and Ubuntu 20. 3. Main bugs fixed: 1. 90 and 270-degree rotations working again. 2. C++ tutorial API demos only try to cv::imshow the image if it is not empty (avoding the assert that it would trigger otherwise). diff --git a/include/openpose/thread/thread.hpp b/include/openpose/thread/thread.hpp index 64a314be87e0dcd27b909fcfb38deb247936e54c..4a38b0d872f1b6670078c0d2dfa09497417eea3c 100644 --- a/include/openpose/thread/thread.hpp +++ b/include/openpose/thread/thread.hpp @@ -120,7 +120,7 @@ namespace op { stopAndJoin(); spIsRunning = isRunningSharedPtr; - *spIsRunning = {true}; + *spIsRunning = true; threadFunction(); } catch (const std::exception& e) @@ -136,7 +136,7 @@ namespace op { opLog("", Priority::Low, __LINE__, __FUNCTION__, __FILE__); stopAndJoin(); - *spIsRunning = {true}; + *spIsRunning = true; mThread = {std::thread{&Thread::threadFunction, this}}; } catch (const std::exception& e) @@ -209,7 +209,7 @@ namespace op { try { - *spIsRunning = {false}; + *spIsRunning = false; } catch (const std::exception& e) { diff --git a/src/openpose/3d/poseTriangulation.cpp b/src/openpose/3d/poseTriangulation.cpp index 0b544dfb8a3a4ea5210b3db5f12f7980486b2442..fe6b9f0b4d800230e63e7e4ab709c89571bfc071 100644 --- a/src/openpose/3d/poseTriangulation.cpp +++ b/src/openpose/3d/poseTriangulation.cpp @@ -21,6 +21,7 @@ namespace op catch (const std::exception& e) { error(e.what(), __LINE__, __FUNCTION__, __FILE__); + return false; } } diff --git a/src/openpose/core/matrix.cpp b/src/openpose/core/matrix.cpp index 3cc25e09ed9ef0369bd4f98c838c90e1a02c4a5c..2c1717641d9da6a8ad54bf103a3c3ca4e80a7599 100644 --- a/src/openpose/core/matrix.cpp +++ b/src/openpose/core/matrix.cpp @@ -104,6 +104,7 @@ namespace op catch (const std::exception& e) { error(e.what(), __LINE__, __FUNCTION__, __FILE__); + return nullptr; } } @@ -116,6 +117,7 @@ namespace op catch (const std::exception& e) { error(e.what(), __LINE__, __FUNCTION__, __FILE__); + return nullptr; } } diff --git a/src/openpose/pose/poseExtractorNet.cpp b/src/openpose/pose/poseExtractorNet.cpp index 2684ccc26d54ffe65436f49f298c431982c44194..9623d0a58a93584374d6e404e51c0c3296cbf948 100644 --- a/src/openpose/pose/poseExtractorNet.cpp +++ b/src/openpose/pose/poseExtractorNet.cpp @@ -344,7 +344,7 @@ namespace op opLog("Property " + std::to_string((int)property) + " set from " + std::to_string(propertyElement) + " to " + std::to_string(value), Priority::High); - propertyElement = {value}; + propertyElement = value; } catch (const std::exception& e) {