1. 16 12月, 2020 3 次提交
  2. 15 12月, 2020 8 次提交
    • S
      Merge pull request #1362 from Unity-Technologies/fix-dst-transition-bug · 512ad805
      Scott Ferguson 提交于
      Fix Incorrect UTC offset during DST transition (case 1288231)
      512ad805
    • A
      Expose mono_class_is_open_constructed_type to Unity to allow us to check to... · 37f88942
      Alex Thibodeau 提交于
      Expose mono_class_is_open_constructed_type to Unity to allow us to check to see if the class is not yet fully instantiated prior to asttempting to call mono_object_new on it.
      
      * Also cleaning up a minor leak of a MonoError in mono_unity_class_inflate_generic_class
      37f88942
    • S
      Fix Incorrect UTC offset during DST transition (case 1288231) · 26dced2c
      Scott Ferguson 提交于
      Corrects an issue where for the hour after the DST transition, the
      local UTC offset was listed.  The UTC offset was the DST offset
      instead of the standard time offset.
      
      The runtime library captures this an ambiguous time.  That is
      the local time that occurs twice - once in DST then once in standard
      time.  If DST is an extra 1:00 a.m. offset and ends at 2:00 a.m., 1:00 a.m.
      to 1:59:59.9999.... occurs twice.  First in DST then again in standard
      time.
      
      The classlibs had this incorrect - they did not consider 1:00 a.m. an
      ambiguous time, and considered 2:00 a.m. ambiguous.  However it should
      be reversed.  1:00 a.m. occurs twice, but 2:00 a.m. only occurs once.
      The instance we would hit 2:00 a.m. DST, we instantaneous switch to
      1:00 a.m. standard.
      
      The classlibs were also not recording enough information to record
      which side of DST a local time was.  When converting a time from UTC,
      or using DateTime.Now an internal flag, IsAmbiguousDaylightSavingTime,
      should be set if the time is an ambiguous local time that is on the
      DST side of the transition.  The classlibs were calling
      TimeZone.IsAmbigousTime which has a wider defintion for ambiguous
      time that the IsAmbiguousDaylightSavingTime should have.  It returns
      true for local times on either side of DST.  So a new method
      IsAmbiguousLocalDstFromUtc was added to check this case.
      
      The classlibs were also not checking the IsAmbiguousLocalDstFromUtc
      flag when getting the UTC offset for a local time.  So a check
      was inserted in two locations to correct for that.
      
      Some tests has to be updated to reflect these new definitions of when
      DST starts and ends and which times are ambiguous.  These also account
      for some test changes required by cherry-picked changes to
      TimeZoneInfo.cs where the corresponding test changes were not
      cherry-picked.  Some of those changes where in PR's that updated to
      the CoreFx TimeZoneInfo class.
      
      All these changes have been verified against the behavior of the
      .Net Framework and they match.
      
      Fix case 1288231:
      Mono: Fix incorrect UTC offset during daylight savings time transitions
      26dced2c
    • M
      Fix time zone issue when jumping into DST (#16430) · 21b58c96
      Maxim Lipnin 提交于
      Addresses an issue with jumping into DST for some time zones when the incorrect date-time offset is returned for date-time in UTC (which comes from DateTime.Now). The fix is to just check if the incoming date-time is in UTC.
      
      Also added a set of tests for some time zones to verify jumping into DST in general.
      
      Fixes https://github.com/mono/mono/issues/16395
      21b58c96
    • M
    • M
      9d66cfbc
    • M
      Fix time zone transition out of DST (#15401) · 329442fa
      Maxim Lipnin 提交于
      When a datetime appears in range of [end_of_DST_period - Daylight_delta; end_of_DST_period] it's not DST and should return base offset.
      
      Fixes #9664.
      329442fa
    • M
      Port 13553 "Fix transition offset logic" to master · 5a853002
      Maxim Lipnin 提交于
      5a853002
  3. 11 12月, 2020 2 次提交
  4. 05 12月, 2020 1 次提交
  5. 04 12月, 2020 1 次提交
  6. 03 12月, 2020 2 次提交
    • A
      Merge pull request #1367 from Unity-Technologies/unity-master-fix-1288953 · 3b2f916e
      Alex Thibodeau 提交于
      Fix race condition in WaitAnyWithSecondMutexAbandoned test. (case 1288953)
      3b2f916e
    • L
      Fix race condition in WaitAnyWithSecondMutexAbandoned test. · df5aa2bd
      lateralusX 提交于
      There is a small race condition during the completion of a native thread join
      call. During that period of time the tid is no longer included on the
      internal list tracking joinable threads so a thread that will join on the
      tid while another thread (like the finalizer thread) is waiting on native
      join to complete for the same tid, will cause the managed Thread.Join call
      to complete before the native join call has completed. This race could cause
      issues on some OS:es that clear's up some thread resources, like abandoned
      mutexes when the thread has exited. This race is hit by WaitAnyWithSecondMutexAbandoned
      since the call to Thread.Join will return before the thread owning the mutex
      has terminated meaning that it doesn't get ownership of the abandoned mutex
      as assumed by the test.
      
      Fix makes sure Thread.Join won't complete until native thread join is complete.
      Increasing the join timeouts in the test also eliminates a timeout error making it
      harder to hit the problematic code path, primarily during reproduction
      in the debugger.
      
      Fix also switch to coop mutex for joinable threads.
      df5aa2bd
  7. 02 12月, 2020 2 次提交
  8. 01 12月, 2020 4 次提交
  9. 23 11月, 2020 1 次提交
  10. 21 11月, 2020 1 次提交
    • J
      [TermInfo] support new file format terminfo2 introduced with ncurses6.1 · e62b7a78
      Josh Peterson 提交于
      These changes are applied from upstream Mono at https://github.com/mono/mono/pull/7308/commits/e25f5c321573b677ab9edcb88833ef40d267026c.
      
      They correct an exception that happens on Linux like this:
      
      ```
      System.TypeInitializationException: The type initializer for 'System.Console' threw an exception. ---> System.TypeInitializationException: The type initializer for 'System.ConsoleDriver' threw an exception. ---> System.Exception: Magic number is wrong: 542
        at System.TermInfoReader.ReadHeader (System.Byte[] buffer, System.Int32& position) [0x0008d] in /Users/bokken/build/output/Unity-Technologies/mono/mcs/class/corlib/System/TermInfoReader.cs:134
        at System.TermInfoReader..ctor (System.String term, System.String filename) [0x0005f] in /Users/bokken/build/output/Unity-Technologies/mono/mcs/class/corlib/System/TermInfoReader.cs:97
        at System.TermInfoDriver..ctor (System.String term) [0x00055] in /Users/bokken/build/output/Unity-Technologies/mono/mcs/class/corlib/System/TermInfoDriver.cs:164
        at System.ConsoleDriver.CreateTermInfoDriver (System.String term) [0x00000] in /Users/bokken/build/output/Unity-Technologies/mono/mcs/class/corlib/System/ConsoleDriver.cs:73
        at System.ConsoleDriver..cctor () [0x0004d] in /Users/bokken/build/output/Unity-Technologies/mono/mcs/class/corlib/System/ConsoleDriver.cs:57
      ```
      e62b7a78
  11. 18 11月, 2020 1 次提交
  12. 16 11月, 2020 1 次提交
  13. 30 10月, 2020 2 次提交
  14. 21 10月, 2020 2 次提交
  15. 09 10月, 2020 1 次提交
  16. 07 10月, 2020 8 次提交