diff --git a/app/cmd/job_build.go b/app/cmd/job_build.go index 32e05375b3c9541646e4fc716d391a05675dbc93..df4e2739f49dba386d68f6c18b60c935fdd42f70 100644 --- a/app/cmd/job_build.go +++ b/app/cmd/job_build.go @@ -46,7 +46,6 @@ var jobBuildCmd = &cobra.Command{ paramDefs := []client.ParameterDefinition{} hasParam := false if job, err := jclient.GetJob(jobOption.Name); err == nil { - fmt.Println(job.Property) if len(job.Property) != 0 { for _, pro := range job.Property { if len(pro.ParameterDefinitions) == 0 { diff --git a/client/core.go b/client/core.go index 4a028f6b888297f5b4fec626e27e6e118e8bb2f9..24e0df23d844f3a9b1ea91e0a31958d4f6e69b0d 100644 --- a/client/core.go +++ b/client/core.go @@ -51,7 +51,8 @@ func (j *JenkinsCore) AuthHandle(request *http.Request) { } func (j *JenkinsCore) CrumbHandle(request *http.Request) error { - if c, err := j.GetCrumb(); err == nil { + if c, err := j.GetCrumb(); err == nil && c != nil { + // cannot get the crumb could be a noraml situation j.CrumbRequestField = c.CrumbRequestField j.Crumb = c.Crumb request.Header.Add(j.CrumbRequestField, j.Crumb) @@ -80,7 +81,10 @@ func (j *JenkinsCore) GetCrumb() (*JenkinsCrumb, error) { if data, err := ioutil.ReadAll(response.Body); err == nil { if response.StatusCode == 200 { json.Unmarshal(data, &crumbIssuer) + } else if response.StatusCode == 404 { + return nil, err } else { + log.Printf("Unexpected status code: %d.", response.StatusCode) return nil, err } } else {