Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
爱吃血肠
spring-framework
提交
e0faaa48
S
spring-framework
项目概览
爱吃血肠
/
spring-framework
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
S
spring-framework
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
提交
e0faaa48
编写于
11月 06, 2019
作者:
R
Rossen Stoyanchev
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Relax domain name checks in ResponseCookie
Closes gh-23924
上级
2e494419
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
26 addition
and
1 deletion
+26
-1
spring-web/src/main/java/org/springframework/http/ResponseCookie.java
...rc/main/java/org/springframework/http/ResponseCookie.java
+1
-1
spring-web/src/test/java/org/springframework/http/ResponseCookieTests.java
...st/java/org/springframework/http/ResponseCookieTests.java
+25
-0
未找到文件。
spring-web/src/main/java/org/springframework/http/ResponseCookie.java
浏览文件 @
e0faaa48
...
...
@@ -374,7 +374,7 @@ public final class ResponseCookie extends HttpCookie {
}
int
char1
=
domain
.
charAt
(
0
);
int
charN
=
domain
.
charAt
(
domain
.
length
()
-
1
);
if
(
char1
==
'
.'
||
char1
==
'
-'
||
charN
==
'.'
||
charN
==
'-'
)
{
if
(
char1
==
'-'
||
charN
==
'.'
||
charN
==
'-'
)
{
throw
new
IllegalArgumentException
(
"Invalid first/last char in cookie domain: "
+
domain
);
}
for
(
int
i
=
0
,
c
=
-
1
;
i
<
domain
.
length
();
i
++)
{
...
...
spring-web/src/test/java/org/springframework/http/ResponseCookieTests.java
浏览文件 @
e0faaa48
...
...
@@ -85,6 +85,31 @@ public class ResponseCookieTests {
});
}
@Test
public
void
domainChecks
()
{
Arrays
.
asList
(
"abc"
,
"abc.org"
,
"abc-def.org"
,
"abc3.org"
,
".abc.org"
)
.
forEach
(
domain
->
ResponseCookie
.
from
(
"n"
,
"v"
).
domain
(
domain
).
build
());
Arrays
.
asList
(
"-abc.org"
,
"abc.org."
,
"abc.org-"
,
"-abc.org"
,
"abc.org-"
)
.
forEach
(
domain
->
{
try
{
ResponseCookie
.
from
(
"n"
,
"v"
).
domain
(
domain
).
build
();
}
catch
(
IllegalArgumentException
ex
)
{
assertThat
(
ex
.
getMessage
(),
Matchers
.
containsString
(
"Invalid first/last char"
));
}
});
Arrays
.
asList
(
"abc..org"
,
"abc.-org"
,
"abc-.org"
)
.
forEach
(
domain
->
{
try
{
ResponseCookie
.
from
(
"n"
,
"v"
).
domain
(
domain
).
build
();
}
catch
(
IllegalArgumentException
ex
)
{
assertThat
(
ex
.
getMessage
(),
Matchers
.
containsString
(
"invalid cookie domain char"
));
}
});
}
}
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录