fix: fix more lint issues

cmd/tbs.go

@@ -28,9 +28,8 @@ var tbsCmd = &cobra.Command{
 	Long:  ``,
 	Run: func(cmd *cobra.Command, args []string) {
 		files := cocafile.GetJavaTestFiles(tbsCmdConfig.Path)
-		var identifiers []domain.JIdentifier
 
-		identifiers = cmd_util.LoadTestIdentify(files)
+		identifiers := cmd_util.LoadTestIdentify(files)
 		identifiersMap := domain.BuildIdentifierMap(identifiers)
 
 		var classes []string = nil

pkg/application/deps/dep_app.go

@@ -44,7 +44,7 @@ func (d *DepAnalysisApp) AnalysisPath(path string, nodes []domain.JClassNode) []
 
 	var needRemoveMap = make(map[int]int)
 	for depIndex, dep := range mavenDeps {
-		for key, _ := range importMap {
+		for key := range importMap {
 			if strings.Contains(key, dep.GroupId) {
 				needRemoveMap[depIndex] = depIndex
 				continue

pkg/application/git/log_parser.go

@@ -34,9 +34,7 @@ func UpdateMessageForChange(changedFile string) (string, string, string) {
 		var oldLastChanged = changed[4]
 		// TODO: support for Windows rename
 		if changed[2] == "" {
-			if strings.HasPrefix(oldLastChanged, "/") {
-				oldLastChanged = oldLastChanged[1:]
-			}
+			oldLastChanged = strings.TrimPrefix(oldLastChanged, "/")
 		}
 
 		oldFileName = changed[1] + changed[2] + oldLastChanged

pkg/application/refactor/base/java_refactor_listener.go

@@ -85,7 +85,7 @@ func (s *JavaRefactorListener) EnterTypeType(ctx *TypeTypeContext) {
 
 func (s *JavaRefactorListener) EnterClassOrInterfaceType(ctx *ClassOrInterfaceTypeContext) {
 	identifiers := ctx.AllIDENTIFIER()
-	for index, _ := range identifiers {
+	for index := range identifiers {
 		context := ctx.IDENTIFIER(index)
 		name := context.GetText()
 		startLine := ctx.GetStart().GetLine()
@@ -108,7 +108,7 @@ func (s *JavaRefactorListener) EnterAnnotation(ctx *AnnotationContext) {
 
 func (s *JavaRefactorListener) EnterLambdaParameters(ctx *LambdaParametersContext) {
 	identifiers := ctx.AllIDENTIFIER()
-	for index, _ := range identifiers {
+	for index := range identifiers {
 		context := ctx.IDENTIFIER(index)
 		name := context.GetText()
 		startLine := ctx.GetStart().GetLine()
@@ -153,7 +153,7 @@ func (s *JavaRefactorListener) EnterStatement(ctx *StatementContext) {
 
 func (s *JavaRefactorListener) EnterCreatedName(ctx *CreatedNameContext) {
 	identifiers := ctx.AllIDENTIFIER()
-	for index, _ := range identifiers {
+	for index := range identifiers {
 		context := ctx.IDENTIFIER(index)
 		name := context.GetText()
 		startLine := ctx.GetStart().GetLine()

pkg/application/refactor/unused_classes/unused_classes_app.go

@@ -35,6 +35,6 @@ func Refactoring(parsedDeps []JClassNode) []string {
 		}
 	}
 
-	sort.Sort(sort.StringSlice(excludePackage))
+	sort.Strings(excludePackage)
 	return excludePackage
 }

pkg/application/tbs/tbs_app_test.go

@@ -141,9 +141,8 @@ func buildTbsResult(codePath string) []TestBadSmell {
 
 func BuildTestAnalysisResultsByPath(codePath string) (map[string]domain.JIdentifier, []domain.JClassNode) {
 	files := cocafile.GetJavaTestFiles(codePath)
-	var identifiers []domain.JIdentifier
 
-	identifiers = cmd_util.LoadTestIdentify(files)
+	identifiers := cmd_util.LoadTestIdentify(files)
 	identifiersMap := domain.BuildIdentifierMap(identifiers)
 
 	var classes []string = nil

pkg/infrastructure/apriori/apriori.go

@@ -296,9 +296,7 @@ func (a *Apriori) generateRelationRecords(relationRecords chan RelationRecord, s
 func (a *Apriori) createNextCandidates(prevCandidates [][]string, length int) [][]string {
 	var items []string
 	for _, candidate := range prevCandidates {
-		for _, item := range candidate {
-			items = append(items, item)
-		}
+		items = append(items, candidate...)
 	}
 	sort.Strings(items)
 	items = a.uniqueItems(items)