Explicitly mark abort() as an allowed API call for gpopt

libgpos has a set of banned API calls which needs to be allowed with
the ALLOW_xxx macro in order for gpopt to compile (and thus run).
The changes to ereport() brought a need for allowing abort() since
it now invokes abort when building with --enable-cassert.

This is a temporary fix awaiting the removal of the banning of
function calls entirely. Pushed even though the CI pipeline failed
to provide a clean run (for seeminly unrelated reasons) due to the
absence of this blocking other efforts.

src/backend/gpopt/CGPOptimizer.cpp

@@ -13,6 +13,8 @@
 //
 //---------------------------------------------------------------------------
 
+#define ALLOW_abort
+
 #include "gpopt/CGPOptimizer.h"
 #include "gpopt/utils/COptTasks.h"
 

src/backend/gpopt/gpdbwrappers.cpp

@@ -177,6 +177,7 @@
 #define ALLOW_has_subclass
 #define ALLOW_cdbhash_const
 #define ALLOW_cdbhash_const_list
+#define ALLOW_abort
 
 #define ALLOW_ExecCheckRTPerms
 #define ALLOW_evaluate_expr

src/backend/gpopt/translate/CTranslatorQueryToDXL.cpp

@@ -14,6 +14,8 @@
 //
 //---------------------------------------------------------------------------
 
+#define ALLOW_abort
+
 #include "postgres.h"
 
 #include "access/sysattr.h"

src/backend/gpopt/translate/CTranslatorRelcacheToDXL.cpp

@@ -27,6 +27,7 @@
 #define ALLOW_MemoryContextFreeImpl
 #define ALLOW_CharGetDatum
 #define ALLOW_list_head
+#define ALLOW_abort
 
 #include "postgres.h"
 #include "utils/array.h"

src/backend/gpopt/utils/CConstExprEvaluatorProxy.cpp

@@ -14,6 +14,7 @@
 //
 //---------------------------------------------------------------------------
 
+#define ALLOW_abort
 
 #include "postgres.h"
 #include "executor/executor.h"

src/backend/gpopt/utils/COptTasks.cpp

@@ -14,6 +14,7 @@
 //---------------------------------------------------------------------------
 
 #define ALLOW_strcasecmp
+#define ALLOW_abort
 
 #include "gpopt/utils/gpdbdefs.h"
 #include "gpopt/utils/CConstExprEvaluatorProxy.h"

src/backend/gpopt/utils/funcs.cpp

@@ -14,6 +14,7 @@
 //---------------------------------------------------------------------------
 
 #define ALLOW_appendStringInfo
+#define ALLOW_abort
 
 #include <sys/stat.h>
 #include "gpopt/utils/nodeutils.h"