Revert "Only list complete logical indices for a partitioned table [#143522031]"

This reverts commit 83a2f870.

src/backend/gpopt/gpdbwrappers.cpp

@@ -3042,17 +3042,4 @@ gpdb::FMDCacheNeedsReset
 	return true;
 }
 
-bool
-gpdb::FPartialLogicalIndex
-		(
-			const LogicalIndexInfo *logicalIndexInfo
-		)
-{
-	// A logical index is complete when it's on all leaf partitions
-	// A partial logical index will have part constraints or default levels
-	// set
-	// c.f. BuildLogicalIndexInfo in cdbpartindex.c
-	return logicalIndexInfo->partCons || logicalIndexInfo->defaultLevels;
-}
-
 // EOF

src/backend/gpopt/translate/CTranslatorRelcacheToDXL.cpp

@@ -343,10 +343,7 @@ CTranslatorRelcacheToDXL::PlIndexOidsPartTable
 	for (ULONG ul = 0; ul < ulIndexes; ul++)
 	{
 		LogicalIndexInfo *pidxinfo = (plgidx->logicalIndexInfo)[ul];
-		if (!gpdb::FPartialLogicalIndex(pidxinfo))
-		{
-			plOids = gpdb::PlAppendOid(plOids, pidxinfo->logicalIndexOid);
-		}
+		plOids = gpdb::PlAppendOid(plOids, pidxinfo->logicalIndexOid);
 	}
 	
 	gpdb::GPDBFree(plgidx);
@@ -1227,7 +1224,7 @@ CTranslatorRelcacheToDXL::PmdindexPartTable
 		}
 	}
 
-	BOOL fPartial = gpdb::FPartialLogicalIndex(pidxinfo);
+	BOOL fPartial = (NULL != pnodePartCnstr || NIL != plDefaultLevels);
 
 	if (NULL == pnodePartCnstr)
 	{

src/include/gpopt/gpdbwrappers.h

@@ -516,10 +516,6 @@ namespace gpdb {
 	// close the given relation
 	void CloseRelation(Relation rel);
 
-	// A logical index is partial if it's not present on all leaf partitions
-	// c.f. BuildLogicalIndexInfo in cdbpartindex.c
-	bool FPartialLogicalIndex(const LogicalIndexInfo* logicalIndexInfo);
-
 	// return the logical indexes for a partitioned table
 	LogicalIndexes *Plgidx(Oid oid);