Review comments

gpAux/Makefile

@@ -857,7 +857,6 @@ SET_VERSION_SCRIPTS = \
 	sbin/gpgetstatususingtransition.py \
 	sbin/gpsegstart.py \
 	sbin/gpsegstop.py \
-	sbin/gpsegtoprimaryormirror.py \
 	sbin/gpsetdbid.py \
 	sbin/gpupgrademirror.py \
 	lib/python/gppylib/programs/clsAddMirrors.py \

gpMgmt/Makefile

@@ -35,7 +35,6 @@ SET_VERSION_SCRIPTS = \
 	sbin/gpgetstatususingtransition.py \
 	sbin/gpsegstart.py \
 	sbin/gpsegstop.py \
-	sbin/gpsegtoprimaryormirror.py \
 	sbin/gpsetdbid.py \
 	sbin/gpupgrademirror.py \
 	lib/python/gppylib/programs/clsAddMirrors.py \

gpMgmt/bin/README

@@ -67,7 +67,6 @@ sbin/gpfaultinjector.py -  Helper script for gpfaultinjector
 sbin/gpsegcopy          -  Helper script for gpexpand
 sbin/gpsegstart.py      -  Helper script for gpstart
 sbin/gpsegstop.py       -  Helper script for gpstop
-sbin/gpsegtoprimaryormirror.py  - Helper script for failover
 
 
 Overview of gppylib

gpMgmt/bin/gppylib/commands/gp.py

@@ -611,28 +611,6 @@ class GpSegStartCmd(Command):
         Command.__init__(self,name,cmdStr,ctxt,remoteHost)
 
 
-class GpSegChangeMirrorModeCmd(Command):
-    def __init__(self, name, gphome, gpversion, dbs, targetMode,
-                 pickledParams, verbose=False, ctxt=LOCAL, remoteHost=None):
-        self.gphome=gphome
-        self.dblist=dbs
-        self.dirlist=[]
-        for db in dbs:
-            datadir = db.getSegmentDataDirectory()
-            port = db.getSegmentPort()
-            self.dirlist.append(datadir + ':' + str(port))
-
-        dirstr=" -D ".join(self.dirlist)
-        if verbose:
-            setverbose=" -v "
-        else:
-            setverbose=""
-
-        cmdStr="$GPHOME/sbin/gpsegtoprimaryormirror.py %s -D %s -M %s -p %s -V '%s'" % \
-                (setverbose,dirstr,targetMode,pickledParams,gpversion)
-
-        Command.__init__(self,name,cmdStr,ctxt,remoteHost)
-
 #-----------------------------------------------
 class GpSegStopCmd(Command):
     def __init__(self, name, gphome, version,mode,dbs,timeout=SEGMENT_STOP_TIMEOUT_DEFAULT,

gpMgmt/bin/gppylib/operations/startSegments.py

@@ -277,48 +277,3 @@ class StartSegmentsOperation:
 
         return base64.urlsafe_b64encode(pickle.dumps(hostData))
 
-    def __sendPrimaryMirrorTransition(self, targetMode, segments, convertUsingFullResync, gpArray, resultOut):
-        """
-            @param segments the segments to convert
-            @param convertUsingFullResync in parallel with segments, may be None, gives true/false for whether fullResync
-                                          flag should be passed to the transition
-        """
-
-        if len(segments) == 0:
-            logger.debug("%s conversion of zero segments...skipping" % targetMode)
-            return
-
-        logger.info("Commencing parallel %s conversion of %s segments, please wait..." % (targetMode, len(segments)))
-
-        ###############################################
-        # for each host, create + transfer the transition arguments file
-        dispatchCount=0
-
-        dbIdToPeerMap = gpArray.getDbIdToPeerMap()
-        segmentsByHostName = GpArray.getSegmentsByHostName(segments)
-        for hostName, segments in segmentsByHostName.iteritems():
-            assert len(segments) > 0
-
-            logger.debug("Dispatching command to convert segments on host: %s " % (hostName))
-
-            targetModePerSegment = [targetMode for seg in segments]
-            pickledParams = self.__createPickledTransitionParameters(segments, targetModePerSegment,
-                                        convertUsingFullResync, dbIdToPeerMap)
-
-            address = segments[0].getSegmentAddress()
-            cmd=gp.GpSegChangeMirrorModeCmd(
-                    "remote segment mirror mode conversion on host '%s' using address '%s'" % (hostName, address),
-                    self.__gpHome, self.__gpVersion,
-                    segments, targetMode, pickledParams, verbose=logging_is_verbose(),
-                    ctxt=base.REMOTE,
-                    remoteHost=address)
-            self.__workerPool.addCommand(cmd)
-            dispatchCount+=1
-        self.__workerPool.wait_and_printdots(dispatchCount,self.__quiet)
-
-        # process results
-        self.__processStartOrConvertCommands(resultOut)
-        self.__workerPool.empty_completed_items()
-
-
-