The directory creation code here seems to be duplicated in multiple
places. Since tests are passing now, we're not sure if it's necessary.
It seems to only apply to a standby master, when using non-default
filespaces, and we haven't found a good test case to reproduce the
initial issue that it was supposed to solve -- it seems like originally,
there was a problem where the filespace hashtable was not initialized on
the standby.

Since things seem to be working as intended now, get rid of the dead
code.
Signed-off-by: NJacob Champion <pchampion@pivotal.io>
Signed-off-by: NAsim R P <apraveen@pivotal.io>

Add a FIXME to ao_insert_replay to check if it can work similar to
replay of heap insert xlog records.

This function had diverged a lot from upstream; post subselect merge.
One of the main reason is that upstream has lot of restrictive checks
which prevent pull-up of EXISTS/NOT EXISTS. GPDB handles them
differently; thus producing a join/initplan or a one-time filter.

The cases that GPDB handles and for which we have not ported the checks
from upstream are as follows:

- AGG with limit count with/without offset
- HAVING clause without AGG
- AGG without HAVING clause

For other conditions, we bail out as upstream. Hence we have added
checks differently for having and aggs inside simplify_EXISTS_query.
Rest of the code is similar to upstream.
Signed-off-by: NEkta Khanna <ekhanna@pivotal.io>

* removing docs for pgadmin (not included in build)

* remove pgadmin graphics

The error message was changed accidentally in commit 78b0a42e. Probably
a copy-paste mistake. Change it back.

* Moving module references to 'Additional Supplied Moduels' section to better match postregsql docs organization

* port postgresql passwordcheck docs

These tests are not stable enough, so remove them for now. We will add
them back after improvements.

This was in part already supported as the backend part of the below
commit was already backported. This brings in the frontend changes
as well the followup commit to remove backend support for SSLv3 as
it no longer make any sense to keep it around.

  commit 4dddf8552801ef013c40b22915928559a6fb22a0
  Author: Tom Lane <tgl@sss.pgh.pa.us>
  Date:   Thu May 21 20:41:55 2015 -0400

    Back-patch libpq support for TLS versions beyond v1.

    Since 7.3.2, libpq has been coded in such a way that the only SSL protocol
    it would allow was TLS v1.  That approach is looking increasingly obsolete.
    In commit 820f08ca we fixed it to allow TLS >= v1, but did not
    back-patch the change at the time, partly out of caution and partly because
    the question was confused by a contemporary server-side change to reject
    the now-obsolete SSL protocol v3.  9.4 has now been out long enough that
    it seems safe to assume the change is OK; hence, back-patch into 9.0-9.3.

    (I also chose to back-patch some relevant comments added by commit
    326e1d73, but did *not* change the server behavior; hence, pre-9.4
    servers will continue to allow SSL v3, even though no remotely modern
    client will request it.)

    Per gripe from Jan Bilek.

  commit 326e1d73
  Author: Tom Lane <tgl@sss.pgh.pa.us>
  Date:   Fri Jan 31 17:51:07 2014 -0500

    Disallow use of SSL v3 protocol in the server as well as in libpq.

    Commit 820f08ca claimed to make the server
    and libpq handle SSL protocol versions identically, but actually the server
    was still accepting SSL v3 protocol while libpq wasn't.  Per discussion,
    SSL v3 is obsolete, and there's no good reason to continue to accept it.
    So make the code really equivalent on both sides.  The behavior now is
    that we use the highest mutually-supported TLS protocol version.

    Marko Kreen, some comment-smithing by me

* resgroup: correct the memory quota size on QE.
  QE might have different caps with QD, so the runtime status must also
  be considered to decide the per slot memory quota.
* resgroup: retire sessionId in slot.
* resgroup: also update memQuotaUsed on QEs.
  This value is necessary on ALTER RESOURCE GROUP to decide the new
  memory capabilities, but it was not updated on QEs in the past, so
  the memory quota might be over released on QEs. This does not lead to
  runtime errors, and the memory quota can be regained laterly, but the
  performance can be affected in worst case.
  To fix it now we update this value also on QEs.
* resgroup: reduce the duplicated code in groupApplyMemCaps().
  Move the duplicated logic into mempoolAutoRelease().
* resgroup: validate proc is in the right resgroup wait queue.
  We used to check proc's queuing status, now we also validate it's in
  the specific resgroup's wait queue. This check is expensive so it's
  only enabled in the debugging build.
* resgroup: retire MyProc->resWaiting.
  resWaiting is only true when proc is in the wait queue, and is only
  false when proc is not in the wait queue, so it's a redundant flag.
  And checking proc's queuing status can be performed automatically,
  so resWaiting can be safely retired.
  Their helper functions procIsWaiting() and procIsInWaitQueue() are
  also merged into one.
* and other misc changes.

* Set/Unset doMemCheck in Attach/Detach slot.
* Use IsResGroupEnabled() in ResGroupReleaseMemory().
* Remove AssertImply in Attach/Detach slot.
* Replace magic number 0 with macro to represent cgroup top dir.
* Remove static global variable cpucores.
* Dump more info in ResGroupDumpMemoryInfo.

    commit 195aaf54
    Author: Adam Lee <adam8157@gmail.com>
    Date:   Thu Nov 9 00:36:46 2017 +0800

        Fix cases which are unpredictable (#3797)

* docs - add pxf upgrade procedure

* docs - add content for pxf upgrade procedure

* edits requested by david

* edits from alex, kong

Signed-off-by: NDavid Sharp <dsharp@pivotal.io>

* docs - RG/RQ-qualify gpperfmon, other content where appropriate

* edits from david

In all kills 17 combinations running gpstop -a. These tests already have
coverage for gpstop -i. In case of gpstop -a tests the fault injected is
resumed, command completes and gpstop -a is performed, which will write
checkpoint and clean shut-down. So, really there is nothing to test as recovery
will be normal means not doing anything, do not need so many combinations
testing this behavior.

These tests already have coverage for gpstop -i. In case of gpstop -a tests the
fault injected is resumed, command completes and gpstop -a is performed, which
will write checkpoint and clean shut-down. So, really there is nothing to test
as recovery will be normal means not doing anything, do not need so many
combinations testing this behavior.

test_switch_13_24.py was using fault injector `dtm_xlog_distributed_commit`,
while test_switch_01_12.py has tests for `dtm_broadcast_commit_prepared`. From
code `dtm_xlog_distributed_commit` is set after commit record is written in
`RecordTransactionCommit()` and `dtm_broadcast_commit_prepared` is set just
before commit prepared is broadcasted to segments in
`doNotifyingCommitPrepared()` which gets called right after
`RecordTransactionCommit()`. No 2PC state change between these two fault
injector points making the tests at these 2 points redundant.

Hence, reducing one more box on CI by moving some combinations to
test_switch.py and deleting the test_switch_13_24.py.

* docs - add gp_toolkit discussion of resgroup views

* remove proposed_cpu_rate_limit

For AO tables, users do not always want to run ANALYZE on a table when the
analyzedb command is run. For example, when they have already ANALYZE'ed the
table.

The --gen_profile_only option saves the modification count of the specified AO
table (or all AO tables if none is specified) so that a subsequent analyzedb
command will not ANALYZE the AO table if the modification count for the table
has not changed from the saved value.
Signed-off-by: NMarbin Tan <mtan@pivotal.io>
Signed-off-by: NShoaib Lari <slari@pivotal.io>

The releng NON_PRODUCTION_FILES and QAUTILS_FILES were referencing
quite a few apps that were removed a long time ago (some of them in
the 3.x cycle). Also, the Perl module split in 5.x has made explain
in this list not work since it lacked the corresponding module.

Instead of having to remember to manually update the gppylib JSON
file (which has frequently been forgotten), hook the generation
into the src/backend/catalog "all" target such that it's generated
automatically when needed and thus can be removed from the repo
(removing the risk of using a stale file).

Also updates the documentation and some minor comment fixes to the
process_foreign_key script.

Remove the trailing whitespace that catullus.pl appends to the
comments on the DATA rows for no good reason. Also regenerate
the pg_proc_gp.h file without the whitespace.

* Do UnassignResGroup within prepareTransaction too, prepareTransaction()
will put QE out of any transactions temporarily until the second commit
command arrives, so any failures in this gap will cause leaks of resource
group including slots etc.
* Clean code, move UnassignResGroup() into AtEOXact_ResGroup() so resource
group related codes will not spread across prepare/commit/abort functions.
* Do not call callback functions in PrepareTransaction because the transaction
is not trully commited.

* docs - PXF supports RPM install of clients

* edits per review comments from alex

* docs - add PXF memory and thread config content

* edits to intro paragraph from shivram

* edits from alex re: tomcat queueing

In situations in which our available memory is much larger than the
memory in our sortcontext, it was previously possible to overflow the
maxNumEntries variable.
Signed-off-by: NHaisheng Yuan <hyuan@pivotal.io>

* docs: gpdbrestore add information for --noplan option

* docs: add gpdbrestore --noplan option information to example text.

Unfortunately we can't remove the code referenced by the FIXME yet, but
we've pulled the existing context into the comment and moved to GitHub
for tracking.

[ci skip]
Signed-off-by: NJacob Champion <pchampion@pivotal.io>
Signed-off-by: NAsim R P <apraveen@pivotal.io>

This commit acheives the same behaviour as before, ensuring backward
compatibility for python. Reverting copyfile changes from commit 640fd9d5
for regression.diffs and regression.out as it is used for icg regression
diffs in the ORCA ci pipeline.
Signed-off-by: NDhanashree Kashid <dkashid@pivotal.io>

Signed-off-by: NJiangTian Nie <jiangtian.nie@gmail.com>