The pipeline job icw_planner_centos7_online_expand tests gpexpand in
such a way, it creates a cluster with only 2 primary+mirror segment
pairs, then expand it to 3 and run ICW to verify the expanded cluster
works correctly.

Now we further expand the cluster size from 3 to 4 after ICW, to verify
that tables can be successfully redistributed.

Also renamed the job to icw_planner_centos7_expand.

tracker story here:

  https://www.pivotaltracker.com/story/show/162139588

  When we compile the gpdb, we observer a error in the stdout:

  Error Copying Documentation: /root/gpdb/gpAux/docs/release is not
  present

  We sent a email to confirm with gpdb dev about this issue. and got
  the reply is to remove it completely.
Authored-by: NBob Bao <bbao@pivotal.io>

For GP 6 beta, the release engineering team is removing the apr-util
package from the list of bundled dependencies. Users will be asked
to provide their own apr-util package, which can differ in the version
on each platform. So it is necessary to verify gpperfmon is workable
with the platform provided apr-util on each supported platform.

Originally, gpperfmon test is done in CLI test suite, only covers centos6.
This commit changed it to a dedicated suite in order to test multiple
platforms.
Note: on SLES12 does not need to install libapr-util1 to run gpmmon

With the creation of 6X_STABLE, the pipelines creating artifacts from
the master branch need to separate from 6X_STABLE in blob store
Authored-by: NKris Macoskey <kmacoskey@pivotal.io>

Gp_role is asserted to GP_ROLE_DISPATCH

In some scenarios ERROR "append-only table version -1 is invalid" is
being hit. Code inspection doens't reveal any clues why it can
happen. So, for now we thought of adding more info to figure out the
cause. Backtrace would definitely be helpful when the error hits.

Also, check the format version as soon as entry is read from
catalog. Plus also would be greatly helpful if can have corefile when
the problem happens so under the controlled environment with guc
evelate ERROR to PANIC. GUC
`debug_appendonly_print_verify_write_block` usage for same is not
ideal but wish to avoid adding special guc just for this case, hence
piggyback on this existing uinteresting debug guc for now.
Co-authored-by: NDaniel Gustafsson <dgustafsson@pivotal.io>

* dblink - xref to postgres 9.4 docs

* docs - add some using and writing your own FDW info

* add quote missing from mpp_execute master option

* foreign dash data, misc edits

ci: remove `-oss` from pattern used to parse version output

Remove period from assertRaisesRegexp expectation to not be conflated
with the regex metacharacter.
Authored-by: NKalen Krempely <kkrempely@pivotal.io>

* gpexpand
- remove `-D` flag and specify expansion schema is created in postgres database
- Add gpstate -x flag

* From review: consistent formatting for gpexpand and postgres

* Edit from review

* README mentions how gpupgrade and gpbackup both use the database "regression" that remains after an ICW run in the directory "regress".
Authored-by: NLarry Hamel <lhamel@pivotal.io>

- get port from MASTER_DATA_DIRECTORY, so there is no confusion if
  PGPORT and MASTER_DATA_DIRECTORY are set to different clusters
- delete tmp status file 'gpexpand.standby.status' and copy the
  status file to standby directly
- get standby data directory from catalog instead of assuming its
  same with master
- copy gp_segment_configuration backup file to standby also, so
  standby can restore this catalog if master is down

Previously we added the code due to Coverity report,
however, we conclude that we should better align with upstream
after some further discussion. See below.

https://github.com/greenplum-db/gpdb/pull/7120

In the long run, we hope StrNCpy() is gone, by the way.
Reviewed-by: NDaniel Gustafsson <dgustafsson@pivotal.io>

FirstNormalObjectId indicates the first OID for user objects, if a
relation's oid >= FirstNormalObjectId then it's an user object,
otherwise it's a catalog object.

Fixed some incorrect uses of it, they treated oid == FirstNormalObjectId
as catalog objects.

Discussion: https://groups.google.com/a/greenplum.org/d/msg/gpdb-dev/ZHy-x1DaoXE/ceyzZ4TuCgAJReviewed-by: NDaniel Gustafsson <dgustafsson@pivotal.io>
Reviewed-by: NJimmy Yih <jyih@pivotal.io>
Reviewed-by: NGeorgios Kokolatos <gkokolatos@pivotal.io>

Authored-by: NKris Macoskey <kmacoskey@pivotal.io>

Authored-by: NKris Macoskey <kmacoskey@pivotal.io>

Authored-by: NKris Macoskey <kmacoskey@pivotal.io>

The default is a non OSS build across CI. Explict CI jobs that do build
OSS can use `--with-extra-version` to append `-oss`.
Authored-by: NKris Macoskey <kmacoskey@pivotal.io>

The catullus script had not been used to synchronize all pg_proc
changes into the catalog, so ensure we are in sync before we cut
Beta and (mostly) freeze the catalog. Also fix a set of typos in
DESC properties.

* Doc updates for removal of filespaces.

Changes to utility refs for #4314 and #7116

- Removes references to filespaces
- Allow configuring standby and master on the same host (options to specify host, port, data directory)
- Standy master dir is specified with -F (gpinitsystem) or -S (gpinitstandby)

* Updates from reviews

The error output in gpos job is very different from other jobs. Add
ignore first to fix the pipeline. I would find the root cause and
enable the case again.

It tests heap table and index, temporary table and index created in user tablespace , still exist in  pg_basebackup output.

A replicated table has a full replica of the data on each segment, so
the 'rows' in the EXPLAIN output should not be scaled.

A partial table's 'rows' in the EXPLAIN output should be scaled with the
numsegments of itself.

We used to scale both of above cases with the cluster size in the
EXPLAIN output, so the 'rows' were incorrectly displayed.  It's only a
bug in EXPLAIN output, the cost calculation of the plan is not affected.

We used to make cost calculation with this property, it is equal to the
segments count of the cluster, however this is wrong when the table is a
partial one (this happens during gpexpand).  We should always get
numsegments from the motion.

The gangsize.sql test is updated as in some of its queries the slices
order is different than before due to change of the costs.

This job is used to test online expand, it will create a cluster
with two segments, then expand to 3 and run all ICW to check
whether the cluster is OK after expansion.
As restart is forbidden in online expand test, so we exclude all
the case which contains restart opertaion. But if someone add a
new test with restart, the job may fail. Manual intervention to
exclude the test is needed.
So we move this job to our own dev pipeline to reduce the impact
on prod pipeline.

Most of these FIXME were put in the code as reminders for us to revisit
the decision policy on numsegments, during the development we have
verified the policies or fixed the incorrect ones, now we just need to
remove these FIXME or convert them to comments.
Reviewed-by: NGeorgios Kokolatos <gkokolatos@pivotal.io>

* Adding gpload limitation notice for MPP-29682

* clarify double quotes

* more double quotes

- Refer to specific gpcheckcat output to fix catalog

* Updating location of diferent temp/spill files

* Update follow-on description of temp files for sorting

* Squashed commit of the following:

commit c5f4e38fa669b3daf4c5812b924ad8704e0bdcdc
Author: dyozie <dyozie@pivotal.io>
Date:   Fri Mar 1 14:40:19 2019 -0800

    SELECT - add LATERAL, NO KEY UPDATE, KEY SHARE, and related edits to locking clause

commit b6bb9e9002491bff4ced8c619ee3f4f9fb8699f3
Author: dyozie <dyozie@pivotal.io>
Date:   Fri Mar 1 09:10:50 2019 -0800

    TRUNCATE - add * option

commit 363921783d794bb18b188e585163cd998b7a2f97
Author: David Yozie <dyozie@pivotal.io>
Date:   Thu Feb 28 16:56:50 2019 -0800

    PREPARE - add note about search_path

commit 4ec9f8879f90212c34602b7ccaf9ba93c0cfbe8f
Author: David Yozie <dyozie@pivotal.io>
Date:   Thu Feb 28 16:50:32 2019 -0800

    pg_dumpall - add -d, --dbname option

commit 00c97fca7a4a8420e4a148249af2cafa937c21f8
Author: David Yozie <dyozie@pivotal.io>
Date:   Thu Feb 28 16:41:56 2019 -0800

    add * syntax for descendant tables

commit ab9bd0f96ca38639b4b1ebc97cc8f4009dc7cb91
Author: Lisa Owen <lowen@pivotal.io>
Date:   Thu Feb 28 09:45:22 2019 -0800

    pg_dump - misc edits, additions, formatting

commit 2de77b61903dbbd56f5011545bf23fa794e0a5b5
Author: Lisa Owen <lowen@pivotal.io>
Date:   Wed Feb 27 15:04:03 2019 -0800

    psql - misc additions, edits, and reformats

commit 43bbeed814c56037bbe9bed2bd0b778475264e1c
Author: Lisa Owen <lowen@pivotal.io>
Date:   Wed Feb 27 10:49:00 2019 -0800

    reindexdb - add -t option support for multiple tables; misc edits

commit b9128c528c258d5c84457db12a2a43439a9bacef
Author: Lisa Owen <lowen@pivotal.io>
Date:   Wed Feb 27 10:47:24 2019 -0800

    vacuumdb - add -t option support for multiple tables

* Squashed commit of the following:

commit c8d0bd57acc1a038b2bbd0d9a6900762bf19498e
Author: Chuck Litzell <litzellc@pivotal.io>
Date:   Fri Mar 1 15:33:35 2019 -0600

    CREATE TABLE. Syntax changes. Add SET CONSTRAINTS command.

commit a34ddfac6a5c6aea43b71f7445d6e8d82ab43592
Author: Chuck Litzell <litzellc@pivotal.io>
Date:   Fri Mar 1 16:00:51 2019 -0600

    CREATE TABLE AS. Add WITH/WITHOUT OIDS

commit dde4d614cf10a178b6e1b1dbc8d64608b171924f
Author: Chuck Litzell <litzellc@pivotal.io>
Date:   Fri Mar 1 15:58:54 2019 -0600

    bgworker. Add bgworker topic to reference guide

commit 2749f2e735cc0b59e1153f04fe693e83a812bfc5
Author: Chuck Litzell <litzellc@pivotal.io>
Date:   Wed Feb 27 17:27:57 2019 -0600

    CREATE SCHEMA. Add IF NOT EXISTS forms of command

commit 581274c1d5b218443a9516c160c290aeb73e0999
Author: Chuck Litzell <litzellc@pivotal.io>
Date:   Wed Feb 27 16:43:40 2019 -0600

    CREATE INDEX. Minor synopsis update.

commit b83065abce53d0021eee01c1e8cdf0c7a53d60d4
Author: Chuck Litzell <litzellc@pivotal.io>
Date:   Wed Feb 27 16:13:19 2019 -0600

    COPY. Add FREEZE option and edits.

commit a0800bb10b581cccff97ef5193ef430b53061327
Author: Chuck Litzell <litzellc@pivotal.io>
Date:   Wed Feb 27 15:37:40 2019 -0600

    ALTER RULE. Add new command and fix some conref issues

commit dcf917189d601c1ef9d7c894ea016bd6139e29e8
Author: Chuck Litzell <litzellc@pivotal.io>
Date:   Wed Feb 27 14:58:58 2019 -0600

    ALTER ROLE. Re-order syntax and descriptions.

commit c5f4e38fa669b3daf4c5812b924ad8704e0bdcdc
Author: dyozie <dyozie@pivotal.io>
Date:   Fri Mar 1 14:40:19 2019 -0800

    SELECT - add LATERAL, NO KEY UPDATE, KEY SHARE, and related edits to locking clause

commit b6bb9e9002491bff4ced8c619ee3f4f9fb8699f3
Author: dyozie <dyozie@pivotal.io>
Date:   Fri Mar 1 09:10:50 2019 -0800

    TRUNCATE - add * option

commit 363921783d794bb18b188e585163cd998b7a2f97
Author: David Yozie <dyozie@pivotal.io>
Date:   Thu Feb 28 16:56:50 2019 -0800

    PREPARE - add note about search_path

commit 4ec9f8879f90212c34602b7ccaf9ba93c0cfbe8f
Author: David Yozie <dyozie@pivotal.io>
Date:   Thu Feb 28 16:50:32 2019 -0800

    pg_dumpall - add -d, --dbname option

commit 00c97fca7a4a8420e4a148249af2cafa937c21f8
Author: David Yozie <dyozie@pivotal.io>
Date:   Thu Feb 28 16:41:56 2019 -0800

    add * syntax for descendant tables

commit ab9bd0f96ca38639b4b1ebc97cc8f4009dc7cb91
Author: Lisa Owen <lowen@pivotal.io>
Date:   Thu Feb 28 09:45:22 2019 -0800

    pg_dump - misc edits, additions, formatting

commit 2de77b61903dbbd56f5011545bf23fa794e0a5b5
Author: Lisa Owen <lowen@pivotal.io>
Date:   Wed Feb 27 15:04:03 2019 -0800

    psql - misc additions, edits, and reformats

commit 43bbeed814c56037bbe9bed2bd0b778475264e1c
Author: Lisa Owen <lowen@pivotal.io>
Date:   Wed Feb 27 10:49:00 2019 -0800

    reindexdb - add -t option support for multiple tables; misc edits

commit b9128c528c258d5c84457db12a2a43439a9bacef
Author: Lisa Owen <lowen@pivotal.io>
Date:   Wed Feb 27 10:47:24 2019 -0800

    vacuumdb - add -t option support for multiple tables

* Changes from review

* json-data. Edits, mostly already present in GPDB doc.

* ALTER FOREIGN TABLE. ENABLE/DISABLE trigger forms.

* ALTER INDEX. Add ALL IN TABLESPACE.

* ALTER SYSTEM. new command

* ALTER TABLE. ALL IN TABLESPACE, edits, MVCC warning.

* ALTER TABLESPACE. minor changes only.

* CREATE ROLE. Take out warning about older clients/MD5

* CREATE TABLE. multiple edits.

* CREATE VIEW. Edits. Added RECURSIVE, but also added a Beta warning.

* DISCARD. Add SEQUENCES; edits.

* DROP OWNED. Minor edits.

* GRANT. Add default privileges for object types.

* psql. Many edits.

* SELECT. Many edits.

* gpbackup. typo fix.

* TRUNCATE. Add note truncate is not mvcc-safe.

* VACUUM. Restore description of example

* Corrections from reviews

* Add missing period.

It's kilobytes, not kilo bytes.

This removes a whole set of GUCs which are no longer used in the
codebase. Also remove relevant documentation.
Reviewed-by: NAshwin Agrawal <aagrawal@pivotal.io>
Reviewed-by: NHeikki Linnakangas <hlinnakangas@pivotal.io>
Reviewed-by: NGeorgios Kokolatos <gkokolatos@pivotal.io>

As we merge with upstream and by that keep refining the Postgres
planner, legacy planner is no longer a suitable name. This changes
all variations of the spelling (legacy planner, legacy optimizer,
legacy query optimizer etc) to say "Postgres" rather than "legacy".
Reviewed-by: NVenkatesh Raghavan <vraghavan@pivotal.io>
Reviewed-by: NDavid Yozie <dyozie@pivotal.io>
Reviewed-by: NGeorgios Kokolatos <gkokolatos@pivotal.io>

This just removes unused imports, variables and functions as well
as cleans up a little bit of whitespace. No functional changes.
Reviewed-by: NAdam Berlin <aberlin@pivotal.io>
Reviewed-by: NShoaib Lari <slari@pivotal.io>
Reviewed-by: NKalen Krempely <kkrempely@pivotal.io>