提交 02ab727a 编写于 作者: J Justin Collins

Check for .gitignore secrets in subdirectories

fixes #519
上级 468376e3
......@@ -134,12 +134,15 @@ class Brakeman::CheckSessionSettings < Brakeman::BaseCheck
end
def ignored? file
if @app_tree.exists? ".gitignore"
input = @app_tree.read(".gitignore")
[".", "config", "config/initializers"].each do |dir|
ignore_file = "#{dir}/.gitignore"
if @app_tree.exists? ignore_file
input = @app_tree.read(ignore_file)
input.include? file
else
false
return true if input.include? file
end
end
false
end
end
......@@ -298,4 +298,17 @@ class RescannerTests < Test::Unit::TestCase
assert_fixed 9
end
end
def test_gitignore_session_secret_subdir
gitignore = "config/initializers/.gitignore"
before_rescan_of gitignore do
append gitignore, "secret_token.rb"
end
assert_changes
assert_reindex :none
assert_fixed 1
assert_new 0
end
end
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册