Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
Brakeman
提交
ae776523
B
Brakeman
项目概览
李少辉-开发者
/
Brakeman
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
B
Brakeman
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
提交
ae776523
编写于
8月 27, 2013
作者:
J
Justin Collins
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Remove fuzzy matching for CheckModelAttrAccessible
in practice, this ends up with annoying false positives
上级
46e2d805
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
14 addition
and
3 deletion
+14
-3
lib/brakeman/checks/check_model_attr_accessible.rb
lib/brakeman/checks/check_model_attr_accessible.rb
+3
-3
test/apps/rails3.1/app/models/account.rb
test/apps/rails3.1/app/models/account.rb
+1
-0
test/tests/rails31.rb
test/tests/rails31.rb
+10
-0
未找到文件。
lib/brakeman/checks/check_model_attr_accessible.rb
浏览文件 @
ae776523
...
...
@@ -11,9 +11,9 @@ class Brakeman::CheckModelAttrAccessible < Brakeman::BaseCheck
@description
=
"Reports models which have dangerous attributes defined under the attr_accessible whitelist."
SUSP_ATTRS
=
[
[
/admin/
,
CONFIDENCE
[
:high
]],
# Very dangerous unless some Rails authorization used
[
/role/
,
CONFIDENCE
[
:med
]],
[
/banned/
,
CONFIDENCE
[
:med
]],
[
:admin
,
CONFIDENCE
[
:high
]],
# Very dangerous unless some Rails authorization used
[
:role
,
CONFIDENCE
[
:med
]],
[
:banned
,
CONFIDENCE
[
:med
]],
[
:account_id
,
CONFIDENCE
[
:high
]],
[
/\S*_id(s?)\z/
,
CONFIDENCE
[
:low
]]
# All other foreign keys have weak/low confidence
]
...
...
test/apps/rails3.1/app/models/account.rb
浏览文件 @
ae776523
...
...
@@ -3,4 +3,5 @@ class Account < ActiveRecord::Base
validates
:phone
,
:format
=>
{
:with
=>
/(\d{3})-(\d{3})-(\d{4})/
,
:on
=>
:create
},
:presence
=>
true
validates
:first_name
,
:format
=>
/\w+/
serialize
:cc_info
#safe from CVE-2013-0277
attr_accessible
:blah_admin_blah
end
test/tests/rails31.rb
浏览文件 @
ae776523
...
...
@@ -1044,6 +1044,16 @@ class Rails31Tests < Test::Unit::TestCase
:relative_path
=>
"app/models/user.rb"
end
def
test_attr_accessible_not_matching_regex
assert_no_warning
:type
=>
:model
,
:warning_code
=>
60
,
:fingerprint
=>
"e933f99c33bece852891a466b5b0fc629d9f20ba80ff3bbc42adfd239d5a5b48"
,
:warning_type
=>
"Mass Assignment"
,
:message
=>
/^Potentially\ dangerous\ attribute\ blah_admin/
,
:confidence
=>
0
,
:relative_path
=>
"app/models/account.rb"
end
def
test_wrong_model_attributes_in_haml
assert_no_warning
:type
=>
:template
,
:warning_code
=>
2
,
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录