Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
0bef4b97
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
提交
0bef4b97
编写于
4月 05, 2016
作者:
F
Felipe Artur
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Implement review suggestions
上级
32c7e42b
变更
4
隐藏空白更改
内联
并排
Showing
4 changed file
with
6 addition
and
7 deletion
+6
-7
CHANGELOG
CHANGELOG
+1
-0
app/controllers/groups/milestones_controller.rb
app/controllers/groups/milestones_controller.rb
+3
-5
app/services/milestones/create_service.rb
app/services/milestones/create_service.rb
+1
-1
spec/controllers/groups/milestones_controller_spec.rb
spec/controllers/groups/milestones_controller_spec.rb
+1
-1
未找到文件。
CHANGELOG
浏览文件 @
0bef4b97
...
...
@@ -14,6 +14,7 @@ v 8.7.0 (unreleased)
- Handle nil descriptions in Slack issue messages (Stan Hu)
- Add default scope to projects to exclude projects pending deletion
- Implement 'Groups View' as an option for dashboard preferences !3379 (Elias W.)
- Better errors handling when creating milestones inside groups
- Implement 'TODOs View' as an option for dashboard preferences !3379 (Elias W.)
- Gracefully handle notes on deleted commits in merge requests (Stan Hu)
- Fix creation of merge requests for orphaned branches (Stan Hu)
...
...
app/controllers/groups/milestones_controller.rb
浏览文件 @
0bef4b97
...
...
@@ -21,7 +21,7 @@ class Groups::MilestonesController < Groups::ApplicationController
project_ids
=
params
[
:milestone
][
:project_ids
].
reject
(
&
:blank?
)
title
=
milestone_params
[
:title
]
if
create_milestones
(
project_ids
,
title
)
if
create_milestones
(
project_ids
)
redirect_to
milestone_path
(
title
)
else
render_new_with_error
(
project_ids
.
empty?
)
...
...
@@ -41,7 +41,7 @@ class Groups::MilestonesController < Groups::ApplicationController
private
def
create_milestones
(
project_ids
,
title
)
def
create_milestones
(
project_ids
)
return
false
unless
project_ids
.
present?
ActiveRecord
::
Base
.
transaction
do
...
...
@@ -51,9 +51,7 @@ class Groups::MilestonesController < Groups::ApplicationController
end
true
rescue
=>
e
rescue
ActiveRecord
::
ActiveRecordError
=>
e
flash
.
now
[
:alert
]
=
"An error occurred while creating the milestone:
#{
e
.
message
}
"
false
end
...
...
app/services/milestones/create_service.rb
浏览文件 @
0bef4b97
...
...
@@ -3,7 +3,7 @@ module Milestones
def
execute
milestone
=
project
.
milestones
.
new
(
params
)
if
milestone
.
save
if
milestone
.
save
!
event_service
.
open_milestone
(
milestone
,
current_user
)
end
...
...
spec/controllers/groups/milestones_controller_spec.rb
浏览文件 @
0bef4b97
...
...
@@ -27,7 +27,7 @@ describe Groups::MilestonesController do
it
"redirects to new when there are no project ids"
do
post
:create
,
group_id:
group
.
id
,
milestone:
{
title:
title
,
project_ids:
[
""
]
}
expect
(
response
).
to
render_template
:new
expect
(
assigns
(
:milestone
).
errors
).
to_not
be_nil
expect
(
assigns
(
:milestone
).
errors
).
not_to
be_nil
end
end
end
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录