Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
33694a5a
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
提交
33694a5a
编写于
8月 02, 2016
作者:
M
Mike Greiling
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
use gitlab global root url as canonical base url for all javascript set cookies (closes #20435)
上级
6fb46b60
变更
8
隐藏空白更改
内联
并排
Showing
8 changed file
with
39 addition
and
15 deletion
+39
-15
CHANGELOG
CHANGELOG
+1
-0
app/assets/javascripts/activities.js
app/assets/javascripts/activities.js
+1
-1
app/assets/javascripts/application.js
app/assets/javascripts/application.js
+2
-2
app/assets/javascripts/awards_handler.js
app/assets/javascripts/awards_handler.js
+1
-0
app/assets/javascripts/project.js
app/assets/javascripts/project.js
+2
-6
app/assets/javascripts/right_sidebar.js
app/assets/javascripts/right_sidebar.js
+1
-1
app/assets/javascripts/user.js
app/assets/javascripts/user.js
+1
-3
spec/javascripts/awards_handler_spec.js
spec/javascripts/awards_handler_spec.js
+30
-2
未找到文件。
CHANGELOG
浏览文件 @
33694a5a
...
...
@@ -4,6 +4,7 @@ v 8.12.0 (unreleased)
- Add two-factor recovery endpoint to internal API !5510
- Change merge_error column from string to text type
- Add `web_url` field to issue, merge request, and snippet API objects (Ben Boeckel)
- Set path for all JavaScript cookies to honor GitLab's subdirectory setting !5627 (Mike Greiling)
- Optimistic locking for Issues and Merge Requests (title and description overriding prevention)
- Add `wiki_page_events` to project hook APIs (Ben Boeckel)
- Add Sentry logging to API calls
...
...
app/assets/javascripts/activities.js
浏览文件 @
33694a5a
...
...
@@ -26,7 +26,7 @@
event_filters
=
$
.
cookie
(
"
event_filter
"
);
filter
=
sender
.
attr
(
"
id
"
).
split
(
"
_
"
)[
0
];
$
.
cookie
(
"
event_filter
"
,
(
event_filters
!==
filter
?
filter
:
""
),
{
path
:
'
/
'
path
:
gon
.
relative_url_root
||
'
/
'
});
if
(
event_filters
!==
filter
)
{
return
sender
.
closest
(
'
li
'
).
toggleClass
(
"
active
"
);
...
...
app/assets/javascripts/application.js
浏览文件 @
33694a5a
...
...
@@ -288,7 +288,7 @@
new
Aside
();
if
(
$window
.
width
()
<
1024
&&
$
.
cookie
(
'
pin_nav
'
)
===
'
true
'
)
{
$
.
cookie
(
'
pin_nav
'
,
'
false
'
,
{
path
:
'
/
'
,
path
:
gon
.
relative_url_root
||
'
/
'
,
expires
:
365
*
10
});
$
(
'
.page-with-sidebar
'
).
toggleClass
(
'
page-sidebar-collapsed page-sidebar-expanded
'
).
removeClass
(
'
page-sidebar-pinned
'
);
...
...
@@ -313,7 +313,7 @@
$topNav
.
removeClass
(
'
header-pinned-nav
'
).
toggleClass
(
'
header-collapsed header-expanded
'
);
}
$
.
cookie
(
'
pin_nav
'
,
doPinNav
,
{
path
:
'
/
'
,
path
:
gon
.
relative_url_root
||
'
/
'
,
expires
:
365
*
10
});
if
(
$
.
cookie
(
'
pin_nav
'
)
===
'
true
'
||
doPinNav
)
{
...
...
app/assets/javascripts/awards_handler.js
浏览文件 @
33694a5a
...
...
@@ -320,6 +320,7 @@
frequentlyUsedEmojis
=
this
.
getFrequentlyUsedEmojis
();
frequentlyUsedEmojis
.
push
(
emoji
);
return
$
.
cookie
(
'
frequently_used_emojis
'
,
frequentlyUsedEmojis
.
join
(
'
,
'
),
{
path
:
gon
.
relative_url_root
||
'
/
'
,
expires
:
365
});
};
...
...
app/assets/javascripts/project.js
浏览文件 @
33694a5a
...
...
@@ -17,19 +17,15 @@
return
$
(
this
).
parents
(
'
form
'
).
submit
();
});
$
(
'
.hide-no-ssh-message
'
).
on
(
'
click
'
,
function
(
e
)
{
var
path
;
path
=
'
/
'
;
$
.
cookie
(
'
hide_no_ssh_message
'
,
'
false
'
,
{
path
:
path
path
:
gon
.
relative_url_root
||
'
/
'
});
$
(
this
).
parents
(
'
.no-ssh-key-message
'
).
remove
();
return
e
.
preventDefault
();
});
$
(
'
.hide-no-password-message
'
).
on
(
'
click
'
,
function
(
e
)
{
var
path
;
path
=
'
/
'
;
$
.
cookie
(
'
hide_no_password_message
'
,
'
false
'
,
{
path
:
path
path
:
gon
.
relative_url_root
||
'
/
'
});
$
(
this
).
parents
(
'
.no-password-message
'
).
remove
();
return
e
.
preventDefault
();
...
...
app/assets/javascripts/right_sidebar.js
浏览文件 @
33694a5a
...
...
@@ -30,7 +30,7 @@
}
if
(
!
triggered
)
{
return
$
.
cookie
(
"
collapsed_gutter
"
,
$
(
'
.right-sidebar
'
).
hasClass
(
'
right-sidebar-collapsed
'
),
{
path
:
'
/
'
path
:
gon
.
relative_url_root
||
'
/
'
});
}
});
...
...
app/assets/javascripts/user.js
浏览文件 @
33694a5a
...
...
@@ -7,10 +7,8 @@
});
this
.
initTabs
();
$
(
'
.hide-project-limit-message
'
).
on
(
'
click
'
,
function
(
e
)
{
var
path
;
path
=
'
/
'
;
$
.
cookie
(
'
hide_project_limit_message
'
,
'
false
'
,
{
path
:
path
path
:
gon
.
relative_url_root
||
'
/
'
});
$
(
this
).
parents
(
'
.project-limit-message
'
).
remove
();
return
e
.
preventDefault
();
...
...
spec/javascripts/awards_handler_spec.js
浏览文件 @
33694a5a
...
...
@@ -11,7 +11,7 @@
/*= require ./fixtures/emoji_menu */
(
function
()
{
var
awardsHandler
,
lazyAssert
;
var
awardsHandler
,
lazyAssert
,
urlRoot
;
awardsHandler
=
null
;
...
...
@@ -27,6 +27,7 @@
};
gon
.
award_menu_url
=
'
/emojis
'
;
urlRoot
=
gon
.
relative_url_root
;
lazyAssert
=
function
(
done
,
assertFn
)
{
return
setTimeout
(
function
()
{
...
...
@@ -45,9 +46,14 @@
return
cb
();
};
})(
this
));
return
spyOn
(
jQuery
,
'
get
'
).
and
.
callFake
(
function
(
req
,
cb
)
{
spyOn
(
jQuery
,
'
get
'
).
and
.
callFake
(
function
(
req
,
cb
)
{
return
cb
(
window
.
emojiMenu
);
});
spyOn
(
jQuery
,
'
cookie
'
);
});
afterEach
(
function
()
{
// restore original url root value
gon
.
relative_url_root
=
urlRoot
;
});
describe
(
'
::showEmojiMenu
'
,
function
()
{
it
(
'
should show emoji menu when Add emoji button clicked
'
,
function
(
done
)
{
...
...
@@ -189,6 +195,28 @@
return
expect
(
$thumbsUpEmoji
.
data
(
"
original-title
"
)).
toBe
(
'
sam
'
);
});
});
describe
(
'
::addEmojiToFrequentlyUsedList
'
,
function
()
{
it
(
'
should set a cookie with the correct default path
'
,
function
()
{
gon
.
relative_url_root
=
''
;
awardsHandler
.
addEmojiToFrequentlyUsedList
(
'
sunglasses
'
);
expect
(
jQuery
.
cookie
)
.
toHaveBeenCalledWith
(
'
frequently_used_emojis
'
,
'
sunglasses
'
,
{
path
:
'
/
'
,
expires
:
365
})
;
});
it
(
'
should set a cookie with the correct custom root path
'
,
function
()
{
gon
.
relative_url_root
=
'
/gitlab/subdir
'
;
awardsHandler
.
addEmojiToFrequentlyUsedList
(
'
alien
'
);
expect
(
jQuery
.
cookie
)
.
toHaveBeenCalledWith
(
'
frequently_used_emojis
'
,
'
alien
'
,
{
path
:
'
/gitlab/subdir
'
,
expires
:
365
})
;
});
});
describe
(
'
search
'
,
function
()
{
return
it
(
'
should filter the emoji
'
,
function
()
{
$
(
'
.js-add-award
'
).
eq
(
0
).
click
();
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录