Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
731b8609
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
提交
731b8609
编写于
10月 01, 2015
作者:
V
Valery Sizov
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Hide password in the service settings form
上级
2fa89a3d
变更
5
隐藏空白更改
内联
并排
Showing
5 changed file
with
14 addition
and
3 deletion
+14
-3
CHANGELOG
CHANGELOG
+1
-0
app/controllers/projects/services_controller.rb
app/controllers/projects/services_controller.rb
+3
-1
app/views/shared/_field.html.haml
app/views/shared/_field.html.haml
+5
-2
features/project/service.feature
features/project/service.feature
+1
-0
features/steps/project/services.rb
features/steps/project/services.rb
+4
-0
未找到文件。
CHANGELOG
浏览文件 @
731b8609
...
...
@@ -26,6 +26,7 @@ v 8.1.0 (unreleased)
- Show additions/deletions stats on merge request diff
- Remove footer text in emails (Zeger-Jan van de Weg)
- Ensure code blocks are properly highlighted after a note is updated
- Hide password in the service settings form
v 8.0.3
- Fix URL shown in Slack notifications
...
...
app/controllers/projects/services_controller.rb
浏览文件 @
731b8609
...
...
@@ -58,6 +58,8 @@ class Projects::ServicesController < Projects::ApplicationController
end
def
service_params
params
.
require
(
:service
).
permit
(
ALLOWED_PARAMS
)
service_params
=
params
.
require
(
:service
).
permit
(
ALLOWED_PARAMS
)
service_params
.
delete
(
"password"
)
if
service_params
[
"password"
].
blank?
service_params
end
end
app/views/shared/_field.html.haml
浏览文件 @
731b8609
...
...
@@ -8,7 +8,10 @@
-
help
=
field
[
:help
]
.form-group
=
form
.
label
name
,
title
,
class:
"control-label"
-
if
type
==
"password"
&&
value
.
present?
=
form
.
label
name
,
"Change
#{
title
}
"
,
class:
"control-label"
-
else
=
form
.
label
name
,
title
,
class:
"control-label"
.col-sm-10
-
if
type
==
'text'
=
form
.
text_field
name
,
class:
"form-control"
,
placeholder:
placeholder
...
...
@@ -19,6 +22,6 @@
-
elsif
type
==
'select'
=
form
.
select
name
,
options_for_select
(
choices
,
value
?
value
:
default_choice
),
{},
{
class:
"form-control"
}
-
elsif
type
==
'password'
=
form
.
password_field
name
,
value:
value
,
class:
'form-control'
=
form
.
password_field
name
,
autocomplete:
"new-password"
,
class:
'form-control'
-
if
help
%span
.help-block
=
help
features/project/service.feature
浏览文件 @
731b8609
...
...
@@ -72,6 +72,7 @@ Feature: Project Services
And
I click Atlassian Bamboo CI service link
And
I fill Atlassian Bamboo CI settings
Then
I should see Atlassian Bamboo CI service settings saved
And
I should see empty field Change Password
Scenario
:
Activate jetBrains TeamCity CI service
When
I visit project
"Shop"
services page
...
...
features/steps/project/services.rb
浏览文件 @
731b8609
...
...
@@ -202,6 +202,10 @@ class Spinach::Features::ProjectServices < Spinach::FeatureSteps
expect
(
find_field
(
'Username'
).
value
).
to
eq
'user'
end
step
'I should see empty field Change Password'
do
expect
(
find_field
(
'Change Password'
).
value
).
to
be_nil
end
step
'I click JetBrains TeamCity CI service link'
do
click_link
'JetBrains TeamCity CI'
end
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录