Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
b248ee93
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
提交
b248ee93
编写于
4月 05, 2016
作者:
G
Grzegorz Bizon
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Check permissions when importing project members
Closes #14899
上级
8a0a802e
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
59 addition
and
2 deletion
+59
-2
CHANGELOG
CHANGELOG
+3
-0
app/controllers/projects/project_members_controller.rb
app/controllers/projects/project_members_controller.rb
+7
-2
spec/controllers/projects/project_members_controller_spec.rb
spec/controllers/projects/project_members_controller_spec.rb
+49
-0
未找到文件。
CHANGELOG
浏览文件 @
b248ee93
...
...
@@ -20,6 +20,9 @@ v 8.7.0 (unreleased)
- Fall back to `In-Reply-To` and `References` headers when sub-addressing is not available (David Padilla)
- Remove "Congratulations!" tweet button on newly-created project. (Connor Shea)
v 8.6.5 (unreleased)
- Check permissions when user attempts to import members from another project
v 8.6.4
- Don't attempt to fetch any tags from a forked repo (Stan Hu)
...
...
app/controllers/projects/project_members_controller.rb
浏览文件 @
b248ee93
...
...
@@ -95,8 +95,13 @@ class Projects::ProjectMembersController < Projects::ApplicationController
def
apply_import
giver
=
Project
.
find
(
params
[
:source_project_id
])
status
=
@project
.
team
.
import
(
giver
,
current_user
)
notice
=
status
?
"Successfully imported"
:
"Import failed"
if
current_user
.
can?
(
:read_project_member
,
giver
)
status
=
@project
.
team
.
import
(
giver
,
current_user
)
notice
=
status
?
"Successfully imported"
:
"Import failed"
else
notice
=
'You are not authorized to import members from this project'
end
redirect_to
(
namespace_project_project_members_path
(
project
.
namespace
,
project
),
notice:
notice
)
...
...
spec/controllers/projects/project_members_controller_spec.rb
0 → 100644
浏览文件 @
b248ee93
require
(
'spec_helper'
)
describe
Projects
::
ProjectMembersController
do
let
(
:project
)
{
create
(
:project
)
}
let
(
:another_project
)
{
create
(
:project
,
:private
)
}
let
(
:user
)
{
create
(
:user
)
}
let
(
:member
)
{
create
(
:user
)
}
before
do
project
.
team
<<
[
user
,
:master
]
another_project
.
team
<<
[
member
,
:guest
]
sign_in
(
user
)
end
describe
'#apply_import'
do
shared_context
'import applied'
do
before
do
post
(
:apply_import
,
namespace_id:
project
.
namespace
.
to_param
,
project_id:
project
.
to_param
,
source_project_id:
another_project
.
id
)
end
end
context
'when user can access source project members'
do
before
{
another_project
.
team
<<
[
user
,
:guest
]
}
include_context
'import applied'
it
'imports source project members'
do
expect
(
project
.
team_members
).
to
include
member
expect
(
response
).
to
set_flash
.
to
'Successfully imported'
expect
(
response
).
to
redirect_to
(
namespace_project_project_members_path
(
project
.
namespace
,
project
)
)
end
end
context
'when user is not member of a source project'
do
include_context
'import applied'
it
'does not import team members'
do
expect
(
project
.
team_members
).
to_not
include
member
end
it
'notifies about invalid permissions'
do
expect
(
response
).
to
set_flash
.
to
/not authorized/
end
end
end
end
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录