未验证 提交 43c7c1ff 编写于 作者: X XuanYang-cn 提交者: GitHub

Fix indexcheck division by zero bug (#18482)

See also: #18479
Signed-off-by: Nyangxuan <xuan.yang@zilliz.com>
上级 efc5406e
...@@ -204,7 +204,7 @@ func (adapter *IVFPQConfAdapter) checkPQParams(params map[string]string) bool { ...@@ -204,7 +204,7 @@ func (adapter *IVFPQConfAdapter) checkPQParams(params map[string]string) bool {
return false return false
} }
m, err := strconv.Atoi(mStr) m, err := strconv.Atoi(mStr)
if err != nil { // invalid m if err != nil || m == 0 { // invalid m
return false return false
} }
......
...@@ -138,6 +138,9 @@ func TestIVFPQConfAdapter_CheckTrain(t *testing.T) { ...@@ -138,6 +138,9 @@ func TestIVFPQConfAdapter_CheckTrain(t *testing.T) {
invalidParamsM[IndexMode] = GPUMode invalidParamsM[IndexMode] = GPUMode
invalidParamsM[DIM] = strconv.Itoa(65536) invalidParamsM[DIM] = strconv.Itoa(65536)
invalidParamsMzero := copyParams(validParams)
invalidParamsMzero[IVFM] = "0"
cases := []struct { cases := []struct {
params map[string]string params map[string]string
want bool want bool
...@@ -152,6 +155,7 @@ func TestIVFPQConfAdapter_CheckTrain(t *testing.T) { ...@@ -152,6 +155,7 @@ func TestIVFPQConfAdapter_CheckTrain(t *testing.T) {
{invalidParamsWithoutIVF, false}, {invalidParamsWithoutIVF, false},
{invalidParamsIVF, false}, {invalidParamsIVF, false},
{invalidParamsM, false}, {invalidParamsM, false},
{invalidParamsMzero, false},
} }
adapter := newIVFPQConfAdapter() adapter := newIVFPQConfAdapter()
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册