• E
    command: avoid double close bugs · 1a6bad71
    Eric Blake 提交于
    KAMEZAWA Hiroyuki reported a nasty double-free bug when virCommand
    is used to convert a string into input to a child command.  The
    problem is that the poll() loop of virCommandProcessIO would close()
    the write end of the pipe in order to let the child see EOF, then
    the caller virCommandRun() would also close the same fd number, with
    the second close possibly nuking an fd opened by some other thread
    in the meantime.  This in turn can have all sorts of bad effects.
    
    The bug has been present since the introduction of virCommand in
    commit f16ad06f.
    
    This is based on his first attempt at a patch, at
    https://bugzilla.redhat.com/show_bug.cgi?id=823716
    
    * src/util/command.c (_virCommand): Drop inpipe member.
    (virCommandProcessIO): Add argument, to avoid closing caller's fd
    without informing caller.
    (virCommandRun, virCommandNewArgs): Adjust clients.
    (cherry picked from commit da831afc)
    
    Conflicts:
    
    	src/util/command.c
    1a6bad71
command.c 66.5 KB