提交 b3e872d4 编写于 作者: C cuixucui

修改编码规范问题

上级 026a8394
<?xml version="1.0" encoding="UTF-8"?>
<project version="4">
<component name="ProjectRootManager" version="2" project-jdk-name="Python 3.6 (2)" project-jdk-type="Python SDK" />
<component name="PyCharmProfessionalAdvertiser">
<option name="shown" value="true" />
</component>
</project>
\ No newline at end of file
<?xml version="1.0" encoding="UTF-8"?>
<project version="4">
<component name="ProjectModuleManager">
<modules>
<module fileurl="file://$PROJECT_DIR$/.idea/oec-hardware.iml" filepath="$PROJECT_DIR$/.idea/oec-hardware.iml" />
</modules>
</component>
</project>
\ No newline at end of file
<?xml version="1.0" encoding="UTF-8"?>
<module type="PYTHON_MODULE" version="4">
<component name="NewModuleRootManager">
<content url="file://$MODULE_DIR$" />
<orderEntry type="inheritedJdk" />
<orderEntry type="sourceFolder" forTests="false" />
</component>
<component name="TestRunnerService">
<option name="projectConfiguration" value="pytest" />
<option name="PROJECT_TEST_RUNNER" value="pytest" />
</component>
</module>
\ No newline at end of file
<?xml version="1.0" encoding="UTF-8"?>
<project version="4">
<component name="VcsDirectoryMappings">
<mapping directory="$PROJECT_DIR$" vcs="Git" />
</component>
</project>
\ No newline at end of file
<?xml version="1.0" encoding="UTF-8"?>
<project version="4">
<component name="ChangeListManager">
<list default="true" id="5f681658-0865-4c20-b343-72e088b11842" name="Default Changelist" comment="">
<change beforePath="$PROJECT_DIR$/hwcompatible/command.py" beforeDir="false" afterPath="$PROJECT_DIR$/hwcompatible/command.py" afterDir="false" />
<change beforePath="$PROJECT_DIR$/server/server.py" beforeDir="false" afterPath="$PROJECT_DIR$/server/server.py" afterDir="false" />
<change beforePath="$PROJECT_DIR$/tests/acpi/acpi.py" beforeDir="false" afterPath="$PROJECT_DIR$/tests/acpi/acpi.py" afterDir="false" />
<change beforePath="$PROJECT_DIR$/tests/cdrom/cdrom.py" beforeDir="false" afterPath="$PROJECT_DIR$/tests/cdrom/cdrom.py" afterDir="false" />
<change beforePath="$PROJECT_DIR$/tests/disk/disk.py" beforeDir="false" afterPath="$PROJECT_DIR$/tests/disk/disk.py" afterDir="false" />
<change beforePath="$PROJECT_DIR$/tests/ipmi/ipmi.py" beforeDir="false" afterPath="$PROJECT_DIR$/tests/ipmi/ipmi.py" afterDir="false" />
<change beforePath="$PROJECT_DIR$/tests/kdump/kdump.py" beforeDir="false" afterPath="$PROJECT_DIR$/tests/kdump/kdump.py" afterDir="false" />
<change beforePath="$PROJECT_DIR$/tests/memory/memory.py" beforeDir="false" afterPath="$PROJECT_DIR$/tests/memory/memory.py" afterDir="false" />
<change beforePath="$PROJECT_DIR$/tests/system/system.py" beforeDir="false" afterPath="$PROJECT_DIR$/tests/system/system.py" afterDir="false" />
</list>
<option name="EXCLUDED_CONVERTED_TO_IGNORED" value="true" />
<option name="SHOW_DIALOG" value="false" />
<option name="HIGHLIGHT_CONFLICTS" value="true" />
<option name="HIGHLIGHT_NON_ACTIVE_CHANGELIST" value="false" />
<option name="LAST_RESOLUTION" value="IGNORE" />
</component>
<component name="FileEditorManager">
<leaf>
<file pinned="false" current-in-tab="false">
<entry file="file://$PROJECT_DIR$/tests/memory/memory.py">
<provider selected="true" editor-type-id="text-editor">
<state relative-caret-position="578">
<caret line="244" column="26" selection-start-line="244" selection-start-column="19" selection-end-line="244" selection-end-column="35" />
<folding>
<element signature="e#587#596#0" expanded="true" />
</folding>
</state>
</provider>
</entry>
</file>
<file pinned="false" current-in-tab="false">
<entry file="file://$PROJECT_DIR$/tests/kdump/kdump.py">
<provider selected="true" editor-type-id="text-editor">
<state relative-caret-position="277">
<caret line="79" column="59" lean-forward="true" selection-start-line="79" selection-start-column="59" selection-end-line="79" selection-end-column="59" />
<folding>
<element signature="e#587#596#0" expanded="true" />
</folding>
</state>
</provider>
</entry>
</file>
<file pinned="false" current-in-tab="false">
<entry file="file://$PROJECT_DIR$/tests/network/ethernet.py">
<provider selected="true" editor-type-id="text-editor">
<state relative-caret-position="578">
<caret line="51" column="38" lean-forward="true" selection-start-line="51" selection-start-column="38" selection-end-line="51" selection-end-column="38" />
<folding>
<element signature="e#587#596#0" expanded="true" />
</folding>
</state>
</provider>
</entry>
</file>
<file pinned="false" current-in-tab="false">
<entry file="file://$PROJECT_DIR$/tests/network/network.py">
<provider selected="true" editor-type-id="text-editor">
<state relative-caret-position="-4212" />
</provider>
</entry>
</file>
<file pinned="false" current-in-tab="false">
<entry file="file://$PROJECT_DIR$/tests/network/rdma.py">
<provider selected="true" editor-type-id="text-editor">
<state relative-caret-position="-2511">
<caret line="23" lean-forward="true" selection-start-line="23" selection-end-line="23" />
</state>
</provider>
</entry>
</file>
<file pinned="false" current-in-tab="false">
<entry file="file://$PROJECT_DIR$/tests/system/system.py">
<provider selected="true" editor-type-id="text-editor">
<state relative-caret-position="174">
<caret line="145" column="31" lean-forward="true" selection-start-line="145" selection-start-column="31" selection-end-line="145" selection-end-column="31" />
</state>
</provider>
</entry>
</file>
<file pinned="false" current-in-tab="true">
<entry file="file://$PROJECT_DIR$/server/templates/job.html">
<provider selected="true" editor-type-id="text-editor">
<state relative-caret-position="567">
<caret line="21" column="20" lean-forward="true" selection-start-line="21" selection-start-column="20" selection-end-line="21" selection-end-column="20" />
</state>
</provider>
</entry>
</file>
<file pinned="false" current-in-tab="false">
<entry file="file://$PROJECT_DIR$/tests/nvme/nvme.py">
<provider selected="true" editor-type-id="text-editor">
<state relative-caret-position="-1539" />
</provider>
</entry>
</file>
<file pinned="false" current-in-tab="false">
<entry file="file://$PROJECT_DIR$/tests/ipmi/ipmi.py">
<provider selected="true" editor-type-id="text-editor">
<state relative-caret-position="659">
<caret line="38" column="35" selection-start-line="38" selection-start-column="19" selection-end-line="38" selection-end-column="35" />
<folding>
<element signature="e#587#621#0" expanded="true" />
</folding>
</state>
</provider>
</entry>
</file>
<file pinned="false" current-in-tab="false">
<entry file="file://$PROJECT_DIR$/hwcompatible/command.py">
<provider selected="true" editor-type-id="text-editor">
<state relative-caret-position="358">
<caret line="204" column="27" lean-forward="true" selection-start-line="204" selection-start-column="27" selection-end-line="204" selection-end-column="27" />
<folding>
<element signature="e#587#597#0" expanded="true" />
</folding>
</state>
</provider>
</entry>
</file>
</leaf>
</component>
<component name="FindInProjectRecents">
<findStrings>
<find>CertCommandError</find>
</findStrings>
</component>
<component name="Git.Settings">
<option name="RECENT_GIT_ROOT_PATH" value="$PROJECT_DIR$" />
</component>
<component name="IdeDocumentHistory">
<option name="CHANGED_PATHS">
<list>
<option value="$PROJECT_DIR$/server/server.py" />
<option value="$PROJECT_DIR$/hwcompatible/command.py" />
<option value="$PROJECT_DIR$/tests/acpi/acpi.py" />
<option value="$PROJECT_DIR$/tests/cdrom/cdrom.py" />
<option value="$PROJECT_DIR$/tests/ipmi/ipmi.py" />
<option value="$PROJECT_DIR$/tests/disk/disk.py" />
<option value="$PROJECT_DIR$/tests/memory/memory.py" />
<option value="$PROJECT_DIR$/tests/kdump/kdump.py" />
<option value="$PROJECT_DIR$/tests/network/ethernet.py" />
<option value="$PROJECT_DIR$/tests/system/system.py" />
</list>
</option>
</component>
<component name="ProjectFrameBounds" extendedState="7">
<option name="x" value="798" />
<option name="y" value="411" />
<option name="width" value="1509" />
<option name="height" value="905" />
</component>
<component name="ProjectView">
<navigator proportions="" version="1">
<foldersAlwaysOnTop value="true" />
</navigator>
<panes>
<pane id="ProjectPane">
<subPane>
<expand>
<path>
<item name="oec-hardware" type="b2602c69:ProjectViewProjectNode" />
<item name="oec-hardware" type="462c0819:PsiDirectoryNode" />
</path>
<path>
<item name="oec-hardware" type="b2602c69:ProjectViewProjectNode" />
<item name="oec-hardware" type="462c0819:PsiDirectoryNode" />
<item name="server" type="462c0819:PsiDirectoryNode" />
</path>
<path>
<item name="oec-hardware" type="b2602c69:ProjectViewProjectNode" />
<item name="oec-hardware" type="462c0819:PsiDirectoryNode" />
<item name="server" type="462c0819:PsiDirectoryNode" />
<item name="templates" type="462c0819:PsiDirectoryNode" />
</path>
</expand>
<select />
</subPane>
</pane>
<pane id="Scope" />
</panes>
</component>
<component name="PropertiesComponent">
<property name="last_opened_file_path" value="$PROJECT_DIR$" />
</component>
<component name="RunDashboard">
<option name="ruleStates">
<list>
<RuleState>
<option name="name" value="ConfigurationTypeDashboardGroupingRule" />
</RuleState>
<RuleState>
<option name="name" value="StatusDashboardGroupingRule" />
</RuleState>
</list>
</option>
</component>
<component name="SvnConfiguration">
<configuration />
</component>
<component name="TaskManager">
<task active="true" id="Default" summary="Default task">
<changelist id="5f681658-0865-4c20-b343-72e088b11842" name="Default Changelist" comment="" />
<created>1592261845556</created>
<option name="number" value="Default" />
<option name="presentableId" value="Default" />
<updated>1592261845556</updated>
</task>
<servers />
</component>
<component name="ToolWindowManager">
<frame x="-8" y="-8" width="1936" height="1056" extended-state="6" />
<editor active="true" />
<layout>
<window_info active="true" content_ui="combo" id="Project" order="0" visible="true" weight="0.24973656" />
<window_info id="Structure" order="1" side_tool="true" weight="0.25" />
<window_info id="Favorites" order="2" side_tool="true" />
<window_info anchor="bottom" id="Message" order="0" />
<window_info anchor="bottom" id="Find" order="1" />
<window_info anchor="bottom" id="Run" order="2" />
<window_info anchor="bottom" id="Debug" order="3" weight="0.4" />
<window_info anchor="bottom" id="Cvs" order="4" weight="0.25" />
<window_info anchor="bottom" id="Inspection" order="5" weight="0.4" />
<window_info anchor="bottom" id="TODO" order="6" />
<window_info anchor="bottom" id="Version Control" order="7" />
<window_info anchor="bottom" id="Terminal" order="8" />
<window_info anchor="bottom" id="Event Log" order="9" side_tool="true" />
<window_info anchor="bottom" id="Python Console" order="10" />
<window_info anchor="right" id="Commander" internal_type="SLIDING" order="0" type="SLIDING" weight="0.4" />
<window_info anchor="right" id="Ant Build" order="1" weight="0.25" />
<window_info anchor="right" content_ui="combo" id="Hierarchy" order="2" weight="0.25" />
</layout>
</component>
<component name="editorHistoryManager">
<entry file="file://$USER_HOME$/AppData/Local/Programs/Python/Python36/Lib/json/decoder.py">
<provider selected="true" editor-type-id="text-editor">
<state relative-caret-position="290">
<caret line="19" column="6" selection-start-line="19" selection-start-column="6" selection-end-line="19" selection-end-column="6" />
</state>
</provider>
</entry>
<entry file="file://$PROJECT_DIR$/server/server.py">
<provider selected="true" editor-type-id="text-editor">
<state relative-caret-position="389">
<caret line="295" lean-forward="true" selection-start-line="295" selection-end-line="295" />
</state>
</provider>
</entry>
<entry file="file://$USER_HOME$/AppData/Local/Programs/Python/Python36/Lib/subprocess.py">
<provider selected="true" editor-type-id="text-editor">
<state relative-caret-position="282">
<caret line="802" column="8" selection-start-line="802" selection-start-column="8" selection-end-line="802" selection-end-column="8" />
</state>
</provider>
</entry>
<entry file="file://$PROJECT_DIR$/tests/acpi/acpi.py">
<provider selected="true" editor-type-id="text-editor">
<state relative-caret-position="524">
<caret line="26" column="34" selection-start-line="26" selection-start-column="34" selection-end-line="26" selection-end-column="34" />
</state>
</provider>
</entry>
<entry file="file://$USER_HOME$/.PyCharmCE2019.1/system/python_stubs/-1442388730/builtins.py">
<provider selected="true" editor-type-id="text-editor">
<state relative-caret-position="290">
<caret line="5448" column="6" selection-start-line="5448" selection-start-column="6" selection-end-line="5448" selection-end-column="6" />
</state>
</provider>
</entry>
<entry file="file://$PROJECT_DIR$/tests/cdrom/cdrom.py">
<provider selected="true" editor-type-id="text-editor">
<state relative-caret-position="218">
<caret line="16" column="11" lean-forward="true" selection-start-line="16" selection-start-column="11" selection-end-line="16" selection-end-column="11" />
</state>
</provider>
</entry>
<entry file="file://$PROJECT_DIR$/tests/cpufreq/cpufreq.py">
<provider selected="true" editor-type-id="text-editor">
<state relative-caret-position="198">
<caret line="339" column="17" selection-start-line="339" selection-start-column="17" selection-end-line="339" selection-end-column="17" />
</state>
</provider>
</entry>
<entry file="file://$PROJECT_DIR$/tests/disk/disk.py">
<provider selected="true" editor-type-id="text-editor">
<state relative-caret-position="378">
<caret line="188" column="32" selection-start-line="188" selection-start-column="28" selection-end-line="188" selection-end-column="34" />
</state>
</provider>
</entry>
<entry file="file://$PROJECT_DIR$/hwcompatible/command.py">
<provider selected="true" editor-type-id="text-editor">
<state relative-caret-position="358">
<caret line="204" column="27" lean-forward="true" selection-start-line="204" selection-start-column="27" selection-end-line="204" selection-end-column="27" />
<folding>
<element signature="e#587#597#0" expanded="true" />
</folding>
</state>
</provider>
</entry>
<entry file="file://$PROJECT_DIR$/tests/memory/memory.py">
<provider selected="true" editor-type-id="text-editor">
<state relative-caret-position="578">
<caret line="244" column="26" selection-start-line="244" selection-start-column="19" selection-end-line="244" selection-end-column="35" />
<folding>
<element signature="e#587#596#0" expanded="true" />
</folding>
</state>
</provider>
</entry>
<entry file="file://$PROJECT_DIR$/tests/ipmi/ipmi.py">
<provider selected="true" editor-type-id="text-editor">
<state relative-caret-position="659">
<caret line="38" column="35" selection-start-line="38" selection-start-column="19" selection-end-line="38" selection-end-column="35" />
<folding>
<element signature="e#587#621#0" expanded="true" />
</folding>
</state>
</provider>
</entry>
<entry file="file://$PROJECT_DIR$/tests/kdump/kdump.py">
<provider selected="true" editor-type-id="text-editor">
<state relative-caret-position="277">
<caret line="79" column="59" lean-forward="true" selection-start-line="79" selection-start-column="59" selection-end-line="79" selection-end-column="59" />
<folding>
<element signature="e#587#596#0" expanded="true" />
</folding>
</state>
</provider>
</entry>
<entry file="file://$PROJECT_DIR$/tests/network/ethernet.py">
<provider selected="true" editor-type-id="text-editor">
<state relative-caret-position="578">
<caret line="51" column="38" lean-forward="true" selection-start-line="51" selection-start-column="38" selection-end-line="51" selection-end-column="38" />
<folding>
<element signature="e#587#596#0" expanded="true" />
</folding>
</state>
</provider>
</entry>
<entry file="file://$PROJECT_DIR$/tests/network/network.py">
<provider selected="true" editor-type-id="text-editor">
<state relative-caret-position="-4212" />
</provider>
</entry>
<entry file="file://$PROJECT_DIR$/tests/nvme/nvme.py">
<provider selected="true" editor-type-id="text-editor">
<state relative-caret-position="-1539" />
</provider>
</entry>
<entry file="file://$PROJECT_DIR$/tests/network/rdma.py">
<provider selected="true" editor-type-id="text-editor">
<state relative-caret-position="-2511">
<caret line="23" lean-forward="true" selection-start-line="23" selection-end-line="23" />
</state>
</provider>
</entry>
<entry file="file://$PROJECT_DIR$/tests/system/system.py">
<provider selected="true" editor-type-id="text-editor">
<state relative-caret-position="174">
<caret line="145" column="31" lean-forward="true" selection-start-line="145" selection-start-column="31" selection-end-line="145" selection-end-column="31" />
</state>
</provider>
</entry>
<entry file="file://$PROJECT_DIR$/server/templates/job.html">
<provider selected="true" editor-type-id="text-editor">
<state relative-caret-position="567">
<caret line="21" column="20" lean-forward="true" selection-start-line="21" selection-start-column="20" selection-end-line="21" selection-end-column="20" />
</state>
</provider>
</entry>
</component>
</project>
\ No newline at end of file
......@@ -94,14 +94,14 @@ class Command:
def print_output(self):
if self.output:
for line in self.output:
sys.stdout.write( line )
sys.stdout.write(line)
sys.stdout.write("\n")
sys.stdout.flush()
def print_errors(self):
if self.errors:
for line in self.errors:
sys.stderr.write( line )
sys.stderr.write(line)
sys.stderr.write("\n")
sys.stderr.flush()
......
......@@ -40,17 +40,17 @@ dir_files = os.path.join(dir_server, 'files')
@app.errorhandler(400)
def bad_request(e):
def bad_request():
return render_template('error.html', error='400 - Bad Request'), 400
@app.errorhandler(404)
def page_not_found(e):
def page_not_found():
return render_template('error.html', error='404 - Page Not Found'), 404
@app.errorhandler(500)
def internal_server_error(e):
def internal_server_error():
return render_template('error.html', error='500 - Internal Server Error'), 500
......@@ -65,15 +65,15 @@ def get_results():
for host in next(os.walk(dir_results))[1]:
dir_host = os.path.join(dir_results, host)
results[host] = {}
for id in next(os.walk(dir_host))[1]:
dir_id = os.path.join(dir_host, id)
for cert_id in next(os.walk(dir_host))[1]:
dir_id = os.path.join(dir_host, cert_id)
results[host][id] = next(os.walk(dir_id))[1]
return render_template('results.html', results=results)
@app.route('/results/<host>/<id>/<job>')
def get_job(host, id, job):
dir_job = os.path.join(dir_results, host, id, job)
def get_job(host, cert_id, job):
dir_job = os.path.join(dir_results, host, cert_id, job)
json_info = os.path.join(dir_job, 'compatibility.json')
json_results = os.path.join(dir_job, 'factory.json')
try:
......@@ -81,19 +81,19 @@ def get_job(host, id, job):
info = json.load(f)
with open(json_results, 'r') as f:
results = json.load(f)
except Exception as e:
except (IOError, json.decoder.JSONDecodeError) as e:
abort(404)
return render_template('job.html', host=host, id=id, job=job, info=info, results=results)
return render_template('job.html', host=host, id=cert_id, job=job, info=info, results=results)
@app.route('/results/<host>/<id>/<job>/devices/<interface>')
def get_device(host, id, job, interface):
dir_job = os.path.join(dir_results, host, id, job)
def get_device(host, cert_id, job, interface):
dir_job = os.path.join(dir_results, host, cert_id, job)
json_results = os.path.join(dir_job, 'factory.json')
try:
with open(json_results, 'r') as f:
results = json.load(f)
except Exception as e:
except (IOError, json.decoder.JSONDecodeError) as e:
abort(404)
for testcase in results:
device = testcase.get('device')
......@@ -104,20 +104,20 @@ def get_device(host, id, job, interface):
@app.route('/results/<host>/<id>/<job>/devices')
def get_devices(host, id, job):
dir_job = os.path.join(dir_results, host, id, job)
def get_devices(host, cert_id, job):
dir_job = os.path.join(dir_results, host, cert_id, job)
json_devices = os.path.join(dir_job, 'device.json')
try:
with open(json_devices, 'r') as f:
devices = json.load(f)
except Exception as e:
except (IOError, json.decoder.JSONDecodeError) as e:
abort(404)
return render_template('devices.html', devices=devices)
@app.route('/results/<host>/<id>/<job>/attachment')
def get_attachment(host, id, job):
dir_job = os.path.join(dir_results, host, id, job)
def get_attachment(host, cert_id, job):
dir_job = os.path.join(dir_results, host, cert_id, job)
attachment = dir_job + '.tar.gz'
filedir = os.path.dirname(attachment)
filename = os.path.basename(attachment)
......@@ -125,22 +125,22 @@ def get_attachment(host, id, job):
@app.route('/results/<host>/<id>/<job>/logs/<name>')
def get_log(host, id, job, name):
dir_job = os.path.join(dir_results, host, id, job)
def get_log(host, cert_id, job, name):
dir_job = os.path.join(dir_results, host, cert_id, job)
logpath = os.path.join(dir_job, name + '.log')
if not os.path.exists(logpath):
logpath = os.path.join(dir_job, 'job.log')
try:
with open(logpath, 'r') as f:
log = f.read().split('\n')
except Exception as e:
except IOError as e:
abort(404)
return render_template('log.html', name=name, log=log)
@app.route('/results/<host>/<id>/<job>/submit')
def submit(host, id, job):
dir_job = os.path.join(dir_results, host, id, job)
def submit(host, cert_id, job):
dir_job = os.path.join(dir_results, host, cert_id, job)
tar_job = dir_job + '.tar.gz'
json_cert = os.path.join(dir_job, 'compatibility.json')
try:
......@@ -148,7 +148,7 @@ def submit(host, id, job):
cert = json.load(f)
with open(tar_job, 'rb') as f:
attachment = base64.b64encode(f.read())
except Exception as e:
except (IOError, json.decoder.JSONDecodeError) as e:
print(e)
abort(500)
......@@ -181,15 +181,14 @@ def submit(host, id, job):
@app.route('/api/job/upload', methods=['GET', 'POST'])
def upload_job():
host = request.values.get('host', '').strip().replace(' ', '-')
id = request.values.get('id', '').strip().replace(' ', '-')
cert_id = request.values.get('id', '').strip().replace(' ', '-')
job = request.values.get('job', '').strip().replace(' ', '-')
filetext = request.values.get('filetext', '')
if not(all([host, id, job, filetext])):
return render_template('upload.html', host=host, id=id, job=job,
if not(all([host, cert_id, job, filetext])):
return render_template('upload.html', host=host, id=cert_id, job=job,
filetext=filetext, ret='Failed'), 400
dir_job = os.path.join(dir_results, host, id, job)
dir_job = os.path.join(dir_results, host, cert_id, job)
tar_job = dir_job + '.tar.gz'
if not os.path.exists(dir_job):
os.makedirs(dir_job)
......@@ -197,10 +196,10 @@ def upload_job():
with open(tar_job, 'wb') as f:
f.write(base64.b64decode(filetext))
os.system("tar xf '%s' -C '%s'" % (tar_job, os.path.dirname(dir_job)))
except Exception as e:
except (IOError, OSError) as e:
print(e)
abort(400)
return render_template('upload.html', host=host, id=id, job=job,
return render_template('upload.html', host=host, id=cert_id, job=job,
filetext=filetext, ret='Successful')
......@@ -229,7 +228,7 @@ def upload_file():
try:
with open(filepath, 'wb') as f:
f.write(base64.b64decode(filetext))
except Exception as e:
except IOError as e:
print(e)
abort(400)
return render_template('upload.html', filename=filename, filetext=filetext,
......@@ -303,7 +302,7 @@ def __get_ib_dev_port(ib_server_ip):
ibport = str(ibport)
return ibdev, ibport
except Exception as e:
except (OSError, IndexError, ValueError) as e:
print(e)
return None, None
......
......@@ -26,7 +26,7 @@ class AcpiTest(Test):
try:
Command("acpidump").echo()
return True
except Exception as e:
except OSError as e:
print(e)
return False
......@@ -72,26 +72,26 @@ class CDRomTest(Test):
bd_types = ["BD_RE", "BD_R", "BD"]
dvd_types = ["DVD_RW", "DVD_PLUS_RW", "DVD_R", "DVD_PLUS_R", "DVD"]
cd_types = ["CD_RW", "CD_R", "CD"]
for type in bd_types:
if device.get_property("ID_CDROM_" + type) == "1":
return type
for type in dvd_types:
if device.get_property("ID_CDROM_" + type) == "1":
return type
for type in cd_types:
if device.get_property("ID_CDROM_" + type) == "1":
return type
for bd_type in bd_types:
if device.get_property("ID_CDROM_" + bd_type) == "1":
return bd_type
for bd_type in dvd_types:
if device.get_ertpropy("ID_CDROM_" + bd_type) == "1":
return bd_type
for bd_type in cd_types:
if device.get_property("ID_CDROM_" + bd_type) == "1":
return bd_type
print("Can not find pr)oper test-type for %s." % device.get_name())
return None
def get_mode(self, type):
if not type:
def get_mode(self, device_type):
if not device_type:
return
if "RW" in type or "RE" in type:
if "RW" in device_type or "RE" in device_type:
self.method = "rw_test"
elif "_R" in type:
elif "_R" in device_type:
self.method = "write_test"
else:
self.method = "read_test"
......@@ -216,14 +216,14 @@ class CDRomTest(Test):
Command("eject %s" % device).run()
print("tray ejected.")
sys.stdout.flush()
except:
except CertCommandError as e:
pass
try:
Command("eject -t %s" % device).run()
print("tray auto-closed.\n")
sys.stdout.flush()
except:
except CertCommandError as e:
print("Could not auto-close the tray, please close the tray manually.")
self.ui.prompt_confirm("Done well?")
......
......@@ -32,7 +32,7 @@ class DiskTest(Test):
self.filesystems = ["ext4"]
self.ui = CommandUI()
def setup(self, args=None):
def setup(self):
try:
print("Disk Info:")
Command("fdisk -l").echo(ignore_errors=True)
......
......@@ -13,7 +13,7 @@
# Create: 2020-04-01
from hwcompatible.test import Test
from hwcompatible.command import Command
from hwcompatible.command import Command, CertCommandError
class IpmiTest(Test):
......@@ -26,7 +26,7 @@ class IpmiTest(Test):
try:
Command("systemctl start ipmi").run()
Command("systemctl status ipmi.service").get_str(regex="Active: active", single_line=False)
except:
except CertCommandError as e:
print("ipmi service cant't be started")
return False
return True
......@@ -36,7 +36,7 @@ class IpmiTest(Test):
for cmd in cmd_list:
try:
Command(cmd).echo()
except:
except CertCommandError as e:
print("%s return error." % cmd)
return False
return True
......
......@@ -79,12 +79,12 @@ class KdumpTest(Test):
if config.get_parameter("path"):
self.vmcore_path = config.get_parameter("path")
dir_pattern = re.compile("(?P<ipaddr>[0-9]+\.[0-9]+\.[0-9]+)-(?P<date>[0-9]+(-|\.)[0-9]+(-|\.)[0-9]+)-(?P<time>[0-9]+:[0-9]+:[0-9]+)")
dir_pattern = re.compile(r"(?P<ipaddr>[0-9]+\.[0-9]+\.[0-9]+)-(?P<date>[0-9]+(-|\.)[0-9]+(-|\.)[0-9]+)-(?P<time>[0-9]+:[0-9]+:[0-9]+)")
vmcore_dirs = list()
for (root, dirs, files) in os.walk(self.vmcore_path):
for dir in dirs:
if dir_pattern.search(dir):
vmcore_dirs.append(dir)
for eve_dir in dirs:
if dir_pattern.search(eve_dir):
vmcore_dirs.append(eve_dir)
vmcore_dirs.sort()
vmcore_file = os.path.join(self.vmcore_path, vmcore_dirs[-1], "vmcore")
......
......@@ -35,7 +35,7 @@ class MemoryTest(Test):
self.retry_list = list()
self.test_dir = os.path.dirname(os.path.realpath(__file__))
def setup(self, args=None):
def setup(self):
self.get_memory()
def test(self):
......@@ -201,7 +201,7 @@ class MemoryTest(Test):
Command("echo 1 > %s/online" % memory_path).run()
Command("cat %s/state" % memory_path).get_str("online")
return True
except:
except CertCommandError as e:
print("Error: fail to online %s." % memory_path)
return False
......@@ -210,7 +210,7 @@ class MemoryTest(Test):
Command("echo 0 > %s/online" % memory_path).run()
Command("cat %s/state" % memory_path).get_str("offline")
return True
except:
except CertCommandError as e:
print("Error: fail to online %s." % memory_path)
return False
......@@ -242,7 +242,7 @@ class MemoryTest(Test):
Command("cat %s/removable" % memory_path).get_str("1")
print("%s is removable, start testing..." % os.path.basename(memory_path))
test_flag = 1
except:
except CertCommandError as e:
continue
if not self.hotplug_memory_test(memory_path):
print("%s hotplug test fail." % os.path.basename(memory_path))
......
......@@ -148,7 +148,7 @@ class SystemTest(Test):
return return_code
def get_modules(self, sign):
pattern = re.compile("^(?P<mod_name>\w+)[\s\S]+\((?P<signs>[A-Z]+)\)")
pattern = re.compile(r"^(?P<mod_name>\w+)[\s\S]+\((?P<signs>[A-Z]+)\)")
proc_modules = open("/proc/modules")
modules = list()
for line in proc_modules.readlines():
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册