1. 16 2月, 2022 1 次提交
  2. 11 1月, 2022 1 次提交
  3. 11 6月, 2021 1 次提交
  4. 31 8月, 2020 1 次提交
  5. 20 8月, 2020 1 次提交
  6. 19 8月, 2020 1 次提交
  7. 17 8月, 2020 1 次提交
  8. 16 1月, 2020 1 次提交
    • R
      fix incorrect __hwcap seen in dynamic-linked __set_thread_area · 0ff18be2
      Rich Felker 提交于
      the bug fixed in commit b82cd6c7 was
      mostly masked on arm because __hwcap was zero at the point of the call
      from the dynamic linker to __set_thread_area, causing the access to
      libc.auxv to be skipped and kuser_helper versions of TLS access and
      atomics to be used instead of the armv6 or v7 versions. however, on
      kernels with kuser_helper removed for hardening it would crash.
      
      since __set_thread_area potentially uses __hwcap, it must be
      initialized before the function is called. move the AT_HWCAP lookup
      from stage 3 to stage 2b.
      0ff18be2
  9. 01 1月, 2020 3 次提交
    • R
      fix fdpic regression in dynamic linker with overly smart compilers · d6bbea2a
      Rich Felker 提交于
      at least gcc 9 broke execution of DT_INIT/DT_FINI for fdpic archs
      (presently only sh) by recognizing that the stores to the
      compound-literal function descriptor constructed to call them were
      dead stores. there's no way to make a "may_alias function", so instead
      launder the descriptor through an asm-statement barrier. in practice
      just making the compound literal volatile seemed to have worked too,
      but this should be less of a hack and more accurately convey the
      semantics of what transformations are not valid.
      d6bbea2a
    • R
      fix crashing ldso on archs where __set_thread_area examines auxv · b82cd6c7
      Rich Felker 提交于
      commit 1c84c999 moved the call to
      __init_tp above the initialization of libc.auxv, inadvertently
      breaking archs where __set_thread_area examines auxv for the sake of
      determining the TLS/atomic model needed at runtime. this broke armv6
      and sh2.
      b82cd6c7
    • R
      move stage3_func typedef out of shared internal dynlink.h header · b529ec9b
      Rich Felker 提交于
      this interface contract is entirely internal to dynlink.c.
      b529ec9b
  10. 03 11月, 2019 1 次提交
    • R
      add time64 redirect for, and redirecting implementation of, dlsym · 22daaea3
      Rich Felker 提交于
      if symbols are being redirected to provide the new time64 ABI, dlsym
      must perform matching redirections; otherwise, it would poke a hole in
      the magic and return pointers to functions that are not safe to call
      from a caller using time64 types.
      
      rather than duplicating a table of redirections, use the time64
      symbols present in libc's symbol table to derive the decision for
      whether a particular symbol needs to be redirected.
      22daaea3
  11. 14 8月, 2019 1 次提交
    • R
      fix regression whereby main thread didn't get TLS relocations · 9d35fec9
      Rich Felker 提交于
      commit ffab4360 broke this by moving
      relocations after not only the allocation of storage for the main
      thread's static TLS, but after the copying of the TLS image. thus,
      relocation results were not reflected in the main thread's copy. this
      could be fixed by calling __reset_tls after relocations, but instead
      split the allocation and installation before/after relocations so that
      there's not a redundant copy.
      
      due to commit 71af5309, updating of
      static_tls_cnt needs to be kept with allocation of static TLS, before
      relocations, rather than after installation.
      9d35fec9
  12. 13 8月, 2019 2 次提交
    • S
      make relocation time symbol lookup and dlsym consistent · f2435263
      Szabolcs Nagy 提交于
      Using common code path for all symbol lookups fixes three dlsym issues:
      
      - st_shndx of STT_TLS symbols were not checked and thus an undefined
        tls symbol reference could be incorrectly treated as a definition
        (the sysv hash lookup returns undefined symbols, gnu does not, so should
        be rare in practice).
      
      - symbol binding was not checked so a hidden symbol may be returned
        (in principle STB_LOCAL symbols may appear in the dynamic symbol table
        for hidden symbols, but linkers most likely don't produce it).
      
      - mips specific behaviour was not applied (ARCH_SYM_REJECT_UND) so
        undefined symbols may be returned on mips.
      
      always_inline is used to avoid relocation performance regression, the
      code generation for find_sym should not be affected.
      f2435263
    • R
      ldso: correct condition for local symbol handling in do_relocs · 1f060ed2
      Rich Felker 提交于
      commit 7a9669e9 added use of the
      symbol reference as the definition, in place of performing a lookup,
      for STT_SECTION symbol references that were first found used in FDPIC.
      such references may happen in certain other cases, such as
      local-dynamic TLS and with relocation types that require a symbol but
      that are being used for non-symbolic purposes, like the powerpc
      unaligned address relocations.
      
      in all such cases I'm aware of, the symbol referenced is a section
      symbol (STT_SECTION); however, the important semantic property is not
      its being a section, but rather its binding local (STB_LOCAL). check
      the latter instead of the former for greater generality and semantic
      correctness.
      1f060ed2
  13. 12 8月, 2019 1 次提交
    • S
      add support for powerpc/powerpc64 unaligned relocations · 08869deb
      Samuel Holland 提交于
      R_PPC_UADDR32 (R_PPC64_UADDR64) has the same meaning as R_PPC_ADDR32
      (R_PPC64_ADDR64), except that its address need not be aligned. For
      powerpc64, BFD ld(1) will automatically convert between ADDR<->UADDR
      relocations when the address is/isn't at its native alignment. This
      will happen if, for example, there is a pointer in a packed struct.
      
      gold and lld do not currently generate R_PPC64_UADDR64, but pass
      through misaligned R_PPC64_ADDR64 relocations from object files,
      possibly relaxing them to misaligned R_PPC64_RELATIVE. In both cases
      (relaxed or not) this violates the PSABI, which defines the relevant
      field type as "a 64-bit field occupying 8 bytes, the alignment of
      which is 8 bytes unless otherwise specified."
      
      All three linkers violate the PSABI on 32-bit powerpc, where the only
      difference is that the field is 32 bits wide, aligned to 4 bytes.
      
      Currently musl fails to load executables linked by BFD ld containing
      R_PPC64_UADDR64, with the error "unsupported relocation type 43".
      This change provides compatibility with BFD ld on powerpc64, and any
      static linker on either architecture that starts following the PSABI
      more closely.
      08869deb
  14. 11 8月, 2019 2 次提交
    • R
      ldso: remove redundant runtime checks in static TLS logic · 71af5309
      Rich Felker 提交于
      as a result of commit ffab4360,
      static_tls_cnt is now valid during relocations at program startup, so
      it's no longer necessary to condition the check against static_tls_cnt
      on this being a runtime (dlopen) relocation.
      71af5309
    • R
      ldso: fix calloc misuse allocating initial tls · ffab4360
      Rich Felker 提交于
      this is analogous to commit 2f1f51ae,
      and should have been caught at the same time since it was right next
      to the code moved in that commit. between final stage 3 reloc_all and
      the jump to the main program's entry point, it is not valid to call
      any functions which may be interposed by the application; doing so
      results in execution of application code before ctors have run, and on
      fdpic archs, before the main program's fdpic self-fixups have taken
      place, which will produce runaway wrong execution.
      ffab4360
  15. 07 7月, 2019 1 次提交
    • R
      fix inadvertent use of uninitialized variable in dladdr · 9b831820
      Rich Felker 提交于
      commit c8b49b2f introduced code that
      checked bestsym to determine whether a matching symbol was found, but
      bestsym is uninitialized if not. instead use best, consistent with use
      in the rest of the function.
      
      simplified from bug report and patch by Cheng Liu.
      9b831820
  16. 26 6月, 2019 1 次提交
    • R
      remove unnecessary and problematic _Noreturn from crt/ldso startup · 54b7564b
      Rich Felker 提交于
      after commit a48ccc15 removed the use
      of _Noreturn on the stage3_func type (which only worked due to it
      being defined to the "GNU C" attribute in C99 mode), GCC could no
      longer assume that the ends of __dls2 and __dls2b are unreachable, and
      produced a warning that a function marked _Noreturn returns.
      
      also, since commit 4390383b, the
      _Noreturn declaration for __libc_start_main in crt1/rcrt1 has been not
      only inconsistent with the definition, but wrong. formally,
      __libc_start_main does return, via a (hopefully) tail call to a helper
      function after the barrier. incorrect usage of _Noreturn in the
      declaration was probably formal UB.
      
      the _Noreturn specifiers were not useful in any of these places, so
      remove them all. now, the only remaining usage of _Noreturn is in
      public interfaces where _Noreturn is part of their contract.
      54b7564b
  17. 17 5月, 2019 2 次提交
    • S
      fix tls offsets when p_vaddr%p_align != 0 on TLS_ABOVE_TP targets · a60b9e06
      Szabolcs Nagy 提交于
      currently the bfd linker does not seem to create tls segments where
      p_vaddr%p_align != 0, but this is valid in ELF and then the runtime
      computed tls offset must satisfy
      
        offset%p_align == (base+p_vaddr)%p_align
      
      and in case of local exec tls (main executable) the smallest such
      offset must be used (otherwise it is incompatible with the offset
      computed by the static linker). the !TLS_ABOVE_TP case is handled
      correctly (the offset is negative then in the formula).
      
      the ldso code for TLS_ABOVE_TP is changed so the static tls offset
      of each module satisfies the formula.
      a60b9e06
    • S
      fix static tls offsets of shared libs on TLS_ABOVE_TP targets · 6104dae9
      Szabolcs Nagy 提交于
      tls_offset should always point to the end of the allocated static tls
      area, but this was not handled correctly on "tls variant 1" targets
      in the dynamic linker:
      
      after application tls was allocated, tls_offset was aligned up,
      potentially wasting tls space. (alignment may be needed at the
      begining of the tls area, not at the end, but that will be fixed
      separately as it is unlikely to affect real binaries.)
      
      when static tls was allocated for a shared library, tls_offset was
      only updated with the size of the tls segment which does not include
      alignment gaps, which can easily happen if the tls size update for
      one library leaves tls_offset misaligned for the next one. this can
      cause oob access in __copy_tls or arbitrary breakage at tls access.
      (the issue was observed on aarch64 with rust binaries)
      6104dae9
  18. 12 5月, 2019 1 次提交
  19. 11 4月, 2019 1 次提交
    • R
      overhaul i386 syscall mechanism not to depend on external asm source · 22e5bbd0
      Rich Felker 提交于
      this is the first part of a series of patches intended to make
      __syscall fully self-contained in the object file produced using
      syscall.h, which will make it possible for crt1 code to perform
      syscalls.
      
      the (confusingly named) i386 __vsyscall mechanism, which this commit
      removes, was introduced before the presence of a valid thread pointer
      was mandatory; back then the thread pointer was setup lazily only if
      threads were used. the intent was to be able to perform syscalls using
      the kernel's fast entry point in the VDSO, which can use the sysenter
      (Intel) or syscall (AMD) instruction instead of int $128, but without
      inlining an access to the __syscall global at the point of each
      syscall, which would incur a significant size cost from PIC setup
      everywhere. the mechanism also shuffled registers/calling convention
      around to avoid spills of call-saved registers, and to avoid
      allocating ebx or ebp via asm constraints, since there are plenty of
      broken-but-supported compiler versions which are incapable of
      allocating ebx with -fPIC or ebp with -fno-omit-frame-pointer.
      
      the new mechanism preserves the properties of avoiding spills and
      avoiding allocation of ebx/ebp in constraints, but does it inline,
      using some fairly simple register shuffling, and uses a field of the
      thread structure rather than global data for the vdso-provided syscall
      code address.
      
      for now, the external __syscall function is refactored not to use the
      old __vsyscall so it can be kept, but the intent is to remove it too.
      22e5bbd0
  20. 06 4月, 2019 1 次提交
  21. 02 4月, 2019 1 次提交
  22. 11 3月, 2019 1 次提交
    • R
      fix invalid-/double-/use-after-free in new dlopen ctor execution · 50cd0238
      Rich Felker 提交于
      this affected the error path where dlopen successfully found and
      loaded the requested dso and all its dependencies, but failed to
      resolve one or more relocations, causing the operation to fail after
      storage for the ctor queue was allocated.
      
      commit 188759bb wrongly put the free
      for the ctor_queue array in the error path inside a loop over each
      loaded dso that needed to be backed-out, rather than just doing it
      once. in addition, the exit path also observed the ctor_queue pointer
      still being nonzero, and would attempt to call ctors on the backed-out
      dsos unless the double-free crashed the process first.
      50cd0238
  23. 04 3月, 2019 6 次提交
    • R
      avoid malloc of ctor queue for programs with no external deps · 43e7efb4
      Rich Felker 提交于
      together with the previous two commits, this completes restoration of
      the property that dynamic-linked apps with no external deps and no tls
      have no failure paths before entry.
      43e7efb4
    • R
      avoid malloc of deps arrays for ldso and vdso · f034f145
      Rich Felker 提交于
      neither has or can have any dependencies, but since commit
      40355569, gratuitous zero-length deps
      arrays were being allocated for them. use a dummy array instead.
      f034f145
    • R
      avoid malloc of deps array for programs with no external deps · e612d094
      Rich Felker 提交于
      traditionally, we've provided a guarantee that dynamic-linked
      applications with no external dependencies (nothing but libc) and no
      thread-local storage have no failure paths before the entry point.
      normally, thanks to reclaim_gaps, such a malloc will not require a
      syscall anyway, but if segment alignment is unlucky, it might. use a
      builtin array for this common special case.
      e612d094
    • R
      fix malloc misuse for startup ctor queue, breakage on fdpic archs · 2f1f51ae
      Rich Felker 提交于
      in the case where malloc is being replaced, it's not valid to call
      malloc between final relocations and main app's crt1 entry point; on
      fdpic archs the main app's entry point will not yet have performed the
      self-fixups necessary to call its code.
      
      to fix, reorder queue_ctors before final relocations. an alternative
      solution would be doing the allocation from __libc_start_init, after
      the entry point but before any ctors run. this is less desirable,
      since it would leave a call to malloc that might be provided by the
      application happening at startup when doing so can be easily avoided.
      2f1f51ae
    • R
      synchronize shared library dtor exec against concurrent loads/ctors · 8e43b561
      Rich Felker 提交于
      previously, going way back, there was simply no synchronization here.
      a call to exit concurrent with ctor execution from dlopen could cause
      a dtor to execute concurrently with its corresponding ctor, or could
      cause dtors for newly-constructed libraries to be skipped.
      
      introduce a shutting_down state that blocks further ctor execution,
      producing the quiescence the dtor execution loop needs to ensure any
      kind of consistency, and that blocks further calls to dlopen so that a
      call into dlopen from a dtor cannot deadlock.
      
      better approaches to some of this may be possible, but the changes
      here at least make things safe.
      8e43b561
    • R
      overhaul shared library ctor execution for dependency order, concurrency · 188759bb
      Rich Felker 提交于
      previously, shared library constructors at program start and dlopen
      time were executed in reverse load order. some libraries, however,
      rely on a depth-first dependency order, which most other dynamic
      linker implementations provide. this is a much more reasonable, less
      arbitrary order, and it turns out to have much better properties with
      regard to how slow-running ctors affect multi-threaded programs, and
      how recursive dlopen behaves.
      
      this commit builds on previous work tracking direct dependencies of
      each dso (commit 40355569), and
      performs a topological sort on the dependency graph at load time while
      the main ldso lock is held and before success is committed, producing
      a queue of constructors needed by the newly-loaded dso (or main
      application). in the case of circular dependencies, the dependency
      chain is simply broken at points where it becomes circular.
      
      when the ctor queue is run, the init_fini_lock is held only for
      iteration purposes; it's released during execution of each ctor, so
      that arbitrarily-long-running application code no longer runs with a
      lock held in the caller. this prevents a dlopen with slow ctors in one
      thread from arbitrarily delaying other threads that call dlopen.
      fully-independent ctors can run concurrently; when multiple threads
      call dlopen with a shared dependency, one will end up executing the
      ctor while the other waits on a condvar for it to finish.
      
      another corner case improved by these changes is recursive dlopen
      (call from a ctor). previously, recursive calls to dlopen could cause
      a ctor for a library to be executed before the ctor for its
      dependency, even when there was no relation between the calling
      library and the library it was loading, simply due to the naive
      reverse-load-order traversal. now, we can guarantee that recursive
      dlopen in non-circular-dependency usage preserves the desired ctor
      execution order properties, and that even in circular usage, at worst
      the libraries whose ctors call dlopen will fail to have completed
      construction when ctors that depend on them run.
      
      init_fini_lock is changed to a normal, non-recursive mutex, since it
      is no longer held while calling back into application code.
      188759bb
  24. 03 3月, 2019 2 次提交
  25. 28 2月, 2019 2 次提交
    • R
      fix and overhaul dlsym depedency order, always record direct deps · 40355569
      Rich Felker 提交于
      dlsym with an explicit handle is specified to use "dependency order",
      a breadth-first search rooted at the argument. this has always been
      implemented by iterating a flattened dependency list built at dlopen
      time. however, the logic for building this list was completely wrong
      except in trivial cases; it simply used the list of libraries loaded
      since a given library, and their direct dependencies, as that
      library's dependencies, which could result in misordering, wrongful
      omission of deep dependencies from the search, and wrongful inclusion
      of unrelated libraries in the search.
      
      further, libraries did not have any recorded list of resolved
      dependencies until they were explicitly dlopened, meaning that
      DT_NEEDED entries had to be resolved again whenever a library
      participated as a dependency of more than one dlopened library.
      
      with this overhaul, the resolved direct dependency list of each
      library is always recorded when it is first loaded, and can be
      extended to a full flattened breadth-first search list if dlopen is
      called on the library. the extension is performed using the direct
      dependency list as a queue and appending copies of the direct
      dependency list of each dependency in the queue, excluding duplicates,
      until the end of the queue is reached. the direct deps remain
      available for future use as the initial subarray of the full deps
      array.
      
      first-load logic in dlopen is updated to match these changes, and
      clarified.
      40355569
    • R
      fix crash/misbehavior from oob read in new dynamic tls installation · 71db5dfa
      Rich Felker 提交于
      code introduced in commit 9d44b646
      wrongly attempted to read past the end of the currently-installed dtv
      to determine if a dso provides new, not-already-installed tls. this
      logic was probably leftover from an earlier draft of the code that
      wrongly installed the new dtv before populating it.
      
      it would work if we instead queried the new, not-yet-installed dtv,
      but instead, replace the incorrect check with a simple range check
      against old_cnt. this also catches modules that have no tls at all
      with a single condition.
      71db5dfa
  26. 25 2月, 2019 1 次提交
    • R
      fix crash in new dynamic tls installation when last dep lacks tls · 6516282d
      Rich Felker 提交于
      code introduced in commit 9d44b646
      wrongly assumed the dso list tail was the right place to find new dtv
      storage. however, this is only true if the last-loaded dependency has
      tls. the correct place to get it is the dso corresponding to the tls
      module list tail. introduce a container_of macro to get it, and use
      it.
      
      ultimately, dynamic tls allocation should be refactored so that this
      is not an issue. there is no reason to be allocating new dtv space at
      each load_library; instead it could happen after all new libraries
      have been loaded but before they are committed. such changes may be
      made later, but this commit fixes the present regression.
      6516282d
  27. 22 2月, 2019 2 次提交
    • R
      add membarrier syscall wrapper, refactor dynamic tls install to use it · ba18c1ec
      Rich Felker 提交于
      the motivation for this change is twofold. first, it gets the fallback
      logic out of the dynamic linker, improving code readability and
      organization. second, it provides application code that wants to use
      the membarrier syscall, which depends on preregistration of intent
      before the process becomes multithreaded unless unbounded latency is
      acceptable, with a symbol that, when linked, ensures that this
      registration happens.
      ba18c1ec
    • R
      fix loop logic cruft in dynamic tls installation · 609dd57c
      Rich Felker 提交于
      commit 9d44b646 inadvertently
      contained leftover logic from a previous approach to the fallback
      signaling loop. it had no adverse effect, since j was always nonzero
      if the loop body was reachable, but it makes no sense to be there with
      the current approach to avoid signaling self.
      609dd57c