In case of a restart, v[0] and v[1] were incorrectly initialised.
This was interpreted by ssl3_get_client_key_exchange as an RSA decryption
failure (don't ask me why) and caused it to create a _random_ master key
instead (even weirder), which obviously led to incorrect input to
ssl3_generate_master_secret and thus caused "block cipher pad is
wrong" error messages from ssl3_enc for the client's Finished message.
Arrgh.

Submitted by: Richard Levitte <levitte@stacken.kth.se>

and to lots of PEM_... functions.
Submitted by: Damien Miller <dmiller@ilogic.com.au>

SSL_MODE_ENABLE_PARTIAL_WRITE, SSL_MODE_ACCEPT_MOVING_WRITE_BUFFER.

Submitted by: Anonymous

Pointed out by: Janez Jere <jj@void.si>

because of missing session ID context (so that application programmers
are directly pointed to what they should do differently).

those functions without having a parameter list declaration.
(There are various similar cases left ...)

While modifying the sources, I found some inconsistencies on the use of
s->cert vs. s->session->sess_cert; I don't know if those could
really have caused problems, but possibly this is a proper bug-fix
and not just a clean-up.

Submitted by: Richard Levitte <richard@levitte.org>

Submitted by:
Reviewed by:
PR:

Submitted by:
Reviewed by:
PR:

that SSL_set_{accept,connect}_state be called before
SSL_{accept,connect} may be used.
Submitted by:
Reviewed by:
PR:

called sess_cert instead of just cert.  This is in preparation of further
changes: Probably often when s->session->sess_cert is used, we should
use s->cert instead; s->session->sess_cert should be a new structure
containing only the stuff that is for just one connection (e.g.
the peer's certificate, which the SSL client implementations currently
store in s->session->[sess_]cert, which is a very confusing thing to do).
Submitted by:
Reviewed by:
PR:

pointers.  The cert_st handling is changed by this in various ways.
Submitted by:
Reviewed by:
PR:

Submitted by:
Reviewed by:
PR:

when restructuring the cert_st handling (removed unnused parts,
and the like).
Submitted by:
Reviewed by:
PR:

Submitted by:
Reviewed by:
PR:

Submitted by:
Reviewed by:
PR:

callbacks.

Submitted by:
Reviewed by:
PR:

Submitted by:
Reviewed by:
PR:

script, translates function codes better and doesn't need the K&R function
prototypes to work (NB. the K&R prototypes can't be wiped just yet: they are
still needed by the DEF generator...). I also ran the script with the -rewrite
option to update all the header and source files.

Submitted by:
Reviewed by:
PR:

Slight cleanup in ssl/