finder_test.rb 42.0 KB
Newer Older
1
require "cases/helper"
2
require 'models/post'
J
Jeremy Kemper 已提交
3
require 'models/author'
4
require 'models/categorization'
J
Jeremy Kemper 已提交
5 6
require 'models/comment'
require 'models/company'
7
require 'models/tagging'
J
Jeremy Kemper 已提交
8 9 10
require 'models/topic'
require 'models/reply'
require 'models/entrant'
11
require 'models/project'
J
Jeremy Kemper 已提交
12
require 'models/developer'
A
Arun Agrawal 已提交
13
require 'models/computer'
14
require 'models/customer'
15
require 'models/toy'
16
require 'models/matey'
17
require 'models/dog'
18 19
require 'models/car'
require 'models/tyre'
D
David Heinemeier Hansson 已提交
20

21
class FinderTest < ActiveRecord::TestCase
R
Fix...  
Ryuta Kamizono 已提交
22
  fixtures :companies, :topics, :entrants, :developers, :developers_projects, :posts, :comments, :accounts, :authors, :author_addresses, :customers, :categories, :categorizations, :cars
D
David Heinemeier Hansson 已提交
23

24 25 26 27 28 29 30 31 32 33 34 35
  def test_find_by_id_with_hash
    assert_raises(ActiveRecord::StatementInvalid) do
      Post.find_by_id(:limit => 1)
    end
  end

  def test_find_by_title_and_id_with_hash
    assert_raises(ActiveRecord::StatementInvalid) do
      Post.find_by_title_and_id('foo', :limit => 1)
    end
  end

D
David Heinemeier Hansson 已提交
36
  def test_find
37
    assert_equal(topics(:first).title, Topic.find(1).title)
D
David Heinemeier Hansson 已提交
38
  end
39

40
  def test_find_with_proc_parameter_and_block
S
Sean Griffin 已提交
41
    exception = assert_raises(RuntimeError) do
42 43
      Topic.all.find(-> { raise "should happen" }) { |e| e.title == "non-existing-title" }
    end
S
Sean Griffin 已提交
44
    assert_equal "should happen", exception.message
45 46 47 48 49 50

    assert_nothing_raised(RuntimeError) do
      Topic.all.find(-> { raise "should not happen" }) { |e| e.title == topics(:first).title }
    end
  end

51 52 53 54 55 56 57 58 59 60
  def test_find_with_ids_returning_ordered
    records = Topic.find([4,2,5])
    assert_equal 'The Fourth Topic of the day', records[0].title
    assert_equal 'The Second Topic of the day', records[1].title
    assert_equal 'The Fifth Topic of the day', records[2].title

    records = Topic.find(4,2,5)
    assert_equal 'The Fourth Topic of the day', records[0].title
    assert_equal 'The Second Topic of the day', records[1].title
    assert_equal 'The Fifth Topic of the day', records[2].title
61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78

    records = Topic.find(['4','2','5'])
    assert_equal 'The Fourth Topic of the day', records[0].title
    assert_equal 'The Second Topic of the day', records[1].title
    assert_equal 'The Fifth Topic of the day', records[2].title

    records = Topic.find('4','2','5')
    assert_equal 'The Fourth Topic of the day', records[0].title
    assert_equal 'The Second Topic of the day', records[1].title
    assert_equal 'The Fifth Topic of the day', records[2].title
  end

  def test_find_with_ids_and_order_clause
    # The order clause takes precedence over the informed ids
    records = Topic.order(:author_name).find([5,3,1])
    assert_equal 'The Third Topic of the day', records[0].title
    assert_equal 'The First Topic',            records[1].title
    assert_equal 'The Fifth Topic of the day', records[2].title
79 80 81 82 83

    records = Topic.order(:id).find([5,3,1])
    assert_equal 'The First Topic',            records[0].title
    assert_equal 'The Third Topic of the day', records[1].title
    assert_equal 'The Fifth Topic of the day', records[2].title
84 85
  end

86 87 88
  def test_find_with_ids_with_limit_and_order_clause
    # The order clause takes precedence over the informed ids
    records = Topic.limit(2).order(:id).find([5,3,1])
89
    assert_equal 2, records.size
90 91 92 93 94 95 96 97
    assert_equal 'The First Topic',            records[0].title
    assert_equal 'The Third Topic of the day', records[1].title
  end

  def test_find_with_ids_and_limit
    records = Topic.limit(3).find([3,2,5,1,4])
    assert_equal 3, records.size
    assert_equal 'The Third Topic of the day',  records[0].title
98
    assert_equal 'The Second Topic of the day', records[1].title
99 100 101
    assert_equal 'The Fifth Topic of the day',  records[2].title
  end

102 103
  def test_find_with_ids_where_and_limit
    # Please note that Topic 1 is the only not approved so
104
    # if it were among the first 3 it would raise an ActiveRecord::RecordNotFound
105 106 107 108 109 110 111
    records = Topic.where(approved: true).limit(3).find([3,2,5,1,4])
    assert_equal 3, records.size
    assert_equal 'The Third Topic of the day',  records[0].title
    assert_equal 'The Second Topic of the day', records[1].title
    assert_equal 'The Fifth Topic of the day',  records[2].title
  end

112
  def test_find_with_ids_and_offset
113 114 115 116 117
    records = Topic.offset(2).find([3,2,5,1,4])
    assert_equal 3, records.size
    assert_equal 'The Fifth Topic of the day',  records[0].title
    assert_equal 'The First Topic',             records[1].title
    assert_equal 'The Fourth Topic of the day', records[2].title
118 119
  end

120 121 122 123 124 125
  def test_find_passing_active_record_object_is_deprecated
    assert_deprecated do
      Topic.find(Topic.last)
    end
  end

126
  def test_symbols_table_ref
127
    gc_disabled = GC.disable
128
    Post.where("author_id" => nil)  # warm up
129 130 131
    x = Symbol.all_symbols.count
    Post.where("title" => {"xxxqqqq" => "bar"})
    assert_equal x, Symbol.all_symbols.count
R
Ryuta Kamizono 已提交
132 133
  ensure
    GC.enable if gc_disabled == false
134 135
  end

136 137 138 139 140
  # find should handle strings that come from URLs
  # (example: Category.find(params[:id]))
  def test_find_with_string
    assert_equal(Topic.find(1).title,Topic.find("1").title)
  end
141

D
David Heinemeier Hansson 已提交
142
  def test_exists
143 144 145 146 147 148
    assert_equal true, Topic.exists?(1)
    assert_equal true, Topic.exists?("1")
    assert_equal true, Topic.exists?(title: "The First Topic")
    assert_equal true, Topic.exists?(heading: "The First Topic")
    assert_equal true, Topic.exists?(:author_name => "Mary", :approved => true)
    assert_equal true, Topic.exists?(["parent_id = ?", 1])
149
    assert_equal true, Topic.exists?(id: [1, 9999])
150 151

    assert_equal false, Topic.exists?(45)
152
    assert_equal false, Topic.exists?(Topic.new.id)
153

154 155 156
    assert_raise(NoMethodError) { Topic.exists?([1,2]) }
  end

157 158 159 160 161 162 163 164 165 166 167 168 169
  def test_exists_with_polymorphic_relation
    post = Post.create!(title: 'Post', body: 'default', taggings: [Tagging.new(comment: 'tagging comment')])
    relation = Post.tagged_with_comment('tagging comment')

    assert_equal true, relation.exists?(title: ['Post'])
    assert_equal true, relation.exists?(['title LIKE ?', 'Post%'])
    assert_equal true, relation.exists?
    assert_equal true, relation.exists?(post.id)
    assert_equal true, relation.exists?(post.id.to_s)

    assert_equal false, relation.exists?(false)
  end

170 171 172 173 174 175
  def test_exists_passing_active_record_object_is_deprecated
    assert_deprecated do
      Topic.exists?(Topic.new)
    end
  end

176
  def test_exists_fails_when_parameter_has_invalid_type
177
    assert_raises(RangeError) do
178 179
      assert_equal false, Topic.exists?(("9"*53).to_i) # number that's bigger than int
    end
180
    assert_equal false, Topic.exists?("foo")
D
David Heinemeier Hansson 已提交
181
  end
182

183
  def test_exists_does_not_select_columns_without_alias
184
    assert_sql(/SELECT\W+1 AS one FROM ["`]topics["`]/i) do
185 186 187 188
      Topic.exists?
    end
  end

189
  def test_exists_returns_true_with_one_record_and_no_args
190
    assert_equal true, Topic.exists?
191
  end
192

E
Egor Lynko 已提交
193
  def test_exists_returns_false_with_false_arg
194
    assert_equal false, Topic.exists?(false)
E
Egor Lynko 已提交
195 196
  end

197 198 199
  # exists? should handle nil for id's that come from URLs and always return false
  # (example: Topic.exists?(params[:id])) where params[:id] is nil
  def test_exists_with_nil_arg
200 201 202 203 204
    assert_equal false, Topic.exists?(nil)
    assert_equal true, Topic.exists?

    assert_equal false, Topic.first.replies.exists?(nil)
    assert_equal true, Topic.first.replies.exists?
205 206
  end

207 208
  # ensures +exists?+ runs valid SQL by excluding order value
  def test_exists_with_order
209
    assert_equal true, Topic.order(:id).distinct.exists?
210 211
  end

212
  def test_exists_with_includes_limit_and_empty_result
213 214
    assert_equal false, Topic.includes(:replies).limit(0).exists?
    assert_equal false, Topic.includes(:replies).limit(1).where('0 = 1').exists?
215 216
  end

217 218
  def test_exists_with_distinct_association_includes_and_limit
    author = Author.first
219 220
    assert_equal false, author.unique_categorized_posts.includes(:special_comments).limit(0).exists?
    assert_equal true, author.unique_categorized_posts.includes(:special_comments).limit(1).exists?
221 222 223 224
  end

  def test_exists_with_distinct_association_includes_limit_and_order
    author = Author.first
225 226
    assert_equal false, author.unique_categorized_posts.includes(:special_comments).order('comments.tags_count DESC').limit(0).exists?
    assert_equal true, author.unique_categorized_posts.includes(:special_comments).order('comments.tags_count DESC').limit(1).exists?
227 228
  end

229
  def test_exists_with_empty_table_and_no_args_given
230
    Topic.delete_all
231
    assert_equal false, Topic.exists?
232
  end
233

234 235
  def test_exists_with_aggregate_having_three_mappings
    existing_address = customers(:david).address
236
    assert_equal true, Customer.exists?(:address => existing_address)
237 238 239 240
  end

  def test_exists_with_aggregate_having_three_mappings_with_one_difference
    existing_address = customers(:david).address
241
    assert_equal false, Customer.exists?(:address =>
242
      Address.new(existing_address.street, existing_address.city, existing_address.country + "1"))
243
    assert_equal false, Customer.exists?(:address =>
244
      Address.new(existing_address.street, existing_address.city + "1", existing_address.country))
245
    assert_equal false, Customer.exists?(:address =>
246 247 248
      Address.new(existing_address.street + "1", existing_address.city, existing_address.country))
  end

249
  def test_exists_does_not_instantiate_records
250 251 252
    assert_not_called(Developer, :instantiate) do
      Developer.exists?
    end
253 254
  end

D
David Heinemeier Hansson 已提交
255 256 257 258
  def test_find_by_array_of_one_id
    assert_kind_of(Array, Topic.find([ 1 ]))
    assert_equal(1, Topic.find([ 1 ]).length)
  end
259

D
David Heinemeier Hansson 已提交
260
  def test_find_by_ids
261 262 263 264 265
    assert_equal 2, Topic.find(1, 2).size
    assert_equal topics(:second).title, Topic.find([2]).first.title
  end

  def test_find_by_ids_with_limit_and_offset
266
    assert_equal 2, Entrant.limit(2).find([1,3,2]).size
267 268 269
    entrants = Entrant.limit(3).offset(2).find([1,3,2])
    assert_equal 1, entrants.size
    assert_equal 'Ruby Guru', entrants.first.name
270 271 272 273

    # Also test an edge case: If you have 11 results, and you set a
    #   limit of 3 and offset of 9, then you should find that there
    #   will be only 2 results, regardless of the limit.
J
Jon Leighton 已提交
274
    devs = Developer.all
275
    last_devs = Developer.limit(3).offset(9).find devs.map(&:id)
276
    assert_equal 2, last_devs.size
277 278
    assert_equal 'fixture_10', last_devs[0].name
    assert_equal 'Jamis', last_devs[1].name
D
David Heinemeier Hansson 已提交
279 280
  end

281 282 283 284 285 286 287 288 289 290 291 292
  def test_find_with_large_number
    assert_raises(ActiveRecord::RecordNotFound) { Topic.find('9999999999999999999999999999999') }
  end

  def test_find_by_with_large_number
    assert_nil Topic.find_by(id: '9999999999999999999999999999999')
  end

  def test_find_by_id_with_large_number
    assert_nil Topic.find_by_id('9999999999999999999999999999999')
  end

293 294 295 296 297 298 299 300 301 302
  def test_find_on_relation_with_large_number
    assert_nil Topic.where('1=1').find_by(id: 9999999999999999999999999999999)
  end

  def test_find_by_bang_on_relation_with_large_number
    assert_raises(ActiveRecord::RecordNotFound) do
      Topic.where('1=1').find_by!(id: 9999999999999999999999999999999)
    end
  end

303 304 305 306
  def test_find_an_empty_array
    assert_equal [], Topic.find([])
  end

307 308 309 310
  def test_find_doesnt_have_implicit_ordering
    assert_sql(/^((?!ORDER).)*$/) { Topic.find(1) }
  end

D
David Heinemeier Hansson 已提交
311
  def test_find_by_ids_missing_one
312
    assert_raise(ActiveRecord::RecordNotFound) { Topic.find(1, 2, 45) }
D
David Heinemeier Hansson 已提交
313
  end
314

315
  def test_find_with_group_and_sanitized_having_method
316
    developers = Developer.group(:salary).having("sum(salary) > ?", 10000).select('salary').to_a
317 318 319 320 321
    assert_equal 3, developers.size
    assert_equal 3, developers.map(&:salary).uniq.size
    assert developers.all? { |developer| developer.salary > 10000 }
  end

D
David Heinemeier Hansson 已提交
322 323
  def test_find_with_entire_select_statement
    topics = Topic.find_by_sql "SELECT * FROM topics WHERE author_name = 'Mary'"
324

D
David Heinemeier Hansson 已提交
325
    assert_equal(1, topics.size)
326
    assert_equal(topics(:second).title, topics.first.title)
D
David Heinemeier Hansson 已提交
327
  end
328

D
David Heinemeier Hansson 已提交
329 330
  def test_find_with_prepared_select_statement
    topics = Topic.find_by_sql ["SELECT * FROM topics WHERE author_name = ?", "Mary"]
331

D
David Heinemeier Hansson 已提交
332
    assert_equal(1, topics.size)
333
    assert_equal(topics(:second).title, topics.first.title)
D
David Heinemeier Hansson 已提交
334
  end
335

336 337 338 339
  def test_find_by_sql_with_sti_on_joined_table
    accounts = Account.find_by_sql("SELECT * FROM accounts INNER JOIN companies ON companies.id = accounts.firm_id")
    assert_equal [Account], accounts.collect(&:class).uniq
  end
340

341 342 343 344 345 346
  def test_find_by_association_subquery
    author = authors(:david)
    assert_equal author.post, Post.find_by(author: Author.where(id: author))
    assert_equal author.post, Post.find_by(author_id: Author.where(id: author))
  end

347 348 349 350 351 352 353 354 355 356 357 358 359 360 361
  def test_take
    assert_equal topics(:first), Topic.take
  end

  def test_take_failing
    assert_nil Topic.where("title = 'This title does not exist'").take
  end

  def test_take_bang_present
    assert_nothing_raised do
      assert_equal topics(:second), Topic.where("title = 'The Second Topic of the day'").take!
    end
  end

  def test_take_bang_missing
362
    assert_raises_with_message ActiveRecord::RecordNotFound, "Couldn't find Topic" do
363 364 365 366
      Topic.where("title = 'This title does not exist'").take!
    end
  end

367
  def test_first
368
    assert_equal topics(:second).title, Topic.where("title = 'The Second Topic of the day'").first.title
369
  end
370

371
  def test_first_failing
372
    assert_nil Topic.where("title = 'The Second Topic of the day!'").first
373
  end
D
David Heinemeier Hansson 已提交
374

375 376 377 378 379 380 381
  def test_first_bang_present
    assert_nothing_raised do
      assert_equal topics(:second), Topic.where("title = 'The Second Topic of the day'").first!
    end
  end

  def test_first_bang_missing
382
    assert_raises_with_message ActiveRecord::RecordNotFound, "Couldn't find Topic" do
383 384 385 386
      Topic.where("title = 'This title does not exist'").first!
    end
  end

387 388 389 390 391 392
  def test_first_have_primary_key_order_by_default
    expected = topics(:first)
    expected.touch # PostgreSQL changes the default order if no order clause is used
    assert_equal expected, Topic.first
  end

393
  def test_model_class_responds_to_first_bang
394 395
    assert Topic.first!
    Topic.delete_all
396
    assert_raises_with_message ActiveRecord::RecordNotFound, "Couldn't find Topic" do
397 398 399 400
      Topic.first!
    end
  end

401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417
  def test_second
    assert_equal topics(:second).title, Topic.second.title
  end

  def test_second_with_offset
    assert_equal topics(:fifth), Topic.offset(3).second
  end

  def test_second_have_primary_key_order_by_default
    expected = topics(:second)
    expected.touch # PostgreSQL changes the default order if no order clause is used
    assert_equal expected, Topic.second
  end

  def test_model_class_responds_to_second_bang
    assert Topic.second!
    Topic.delete_all
418
    assert_raises_with_message ActiveRecord::RecordNotFound, "Couldn't find Topic" do
419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439
      Topic.second!
    end
  end

  def test_third
    assert_equal topics(:third).title, Topic.third.title
  end

  def test_third_with_offset
    assert_equal topics(:fifth), Topic.offset(2).third
  end

  def test_third_have_primary_key_order_by_default
    expected = topics(:third)
    expected.touch # PostgreSQL changes the default order if no order clause is used
    assert_equal expected, Topic.third
  end

  def test_model_class_responds_to_third_bang
    assert Topic.third!
    Topic.delete_all
440
    assert_raises_with_message ActiveRecord::RecordNotFound, "Couldn't find Topic" do
441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461
      Topic.third!
    end
  end

  def test_fourth
    assert_equal topics(:fourth).title, Topic.fourth.title
  end

  def test_fourth_with_offset
    assert_equal topics(:fifth), Topic.offset(1).fourth
  end

  def test_fourth_have_primary_key_order_by_default
    expected = topics(:fourth)
    expected.touch # PostgreSQL changes the default order if no order clause is used
    assert_equal expected, Topic.fourth
  end

  def test_model_class_responds_to_fourth_bang
    assert Topic.fourth!
    Topic.delete_all
462
    assert_raises_with_message ActiveRecord::RecordNotFound, "Couldn't find Topic" do
463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483
      Topic.fourth!
    end
  end

  def test_fifth
    assert_equal topics(:fifth).title, Topic.fifth.title
  end

  def test_fifth_with_offset
    assert_equal topics(:fifth), Topic.offset(0).fifth
  end

  def test_fifth_have_primary_key_order_by_default
    expected = topics(:fifth)
    expected.touch # PostgreSQL changes the default order if no order clause is used
    assert_equal expected, Topic.fifth
  end

  def test_model_class_responds_to_fifth_bang
    assert Topic.fifth!
    Topic.delete_all
484
    assert_raises_with_message ActiveRecord::RecordNotFound, "Couldn't find Topic" do
485 486 487 488
      Topic.fifth!
    end
  end

489 490 491 492 493 494 495
  def test_last_bang_present
    assert_nothing_raised do
      assert_equal topics(:second), Topic.where("title = 'The Second Topic of the day'").last!
    end
  end

  def test_last_bang_missing
496
    assert_raises_with_message ActiveRecord::RecordNotFound, "Couldn't find Topic" do
497 498 499 500
      Topic.where("title = 'This title does not exist'").last!
    end
  end

501
  def test_model_class_responds_to_last_bang
502
    assert_equal topics(:fifth), Topic.last!
503
    assert_raises_with_message ActiveRecord::RecordNotFound, "Couldn't find Topic" do
504 505 506 507 508
      Topic.delete_all
      Topic.last!
    end
  end

509
  def test_take_and_first_and_last_with_integer_should_use_sql_limit
510 511 512
    assert_sql(/LIMIT|ROWNUM <=/) { Topic.take(3).entries }
    assert_sql(/LIMIT|ROWNUM <=/) { Topic.first(2).entries }
    assert_sql(/LIMIT|ROWNUM <=/) { Topic.last(5).entries }
513 514 515 516 517 518
  end

  def test_last_with_integer_and_order_should_keep_the_order
    assert_equal Topic.order("title").to_a.last(2), Topic.order("title").last(2)
  end

519 520 521 522
  def test_last_with_integer_and_order_should_use_sql_limit
    relation = Topic.order("title")
    assert_queries(1) { relation.last(5) }
    assert !relation.loaded?
523 524
  end

525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556
  def test_last_with_integer_and_reorder_should_use_sql_limit
    relation = Topic.reorder("title")
    assert_queries(1) { relation.last(5) }
    assert !relation.loaded?
  end

  def test_last_on_loaded_relation_should_not_use_sql
    relation  = Topic.limit(10).load
    assert_no_queries do
      relation.last
      relation.last(2)
    end
  end

  def test_last_with_irreversible_order
    assert_deprecated do
      Topic.order("coalesce(author_name, title)").last
    end
  end  

  def test_last_on_relation_with_limit_and_offset
    post = posts('sti_comments')

    comments = post.comments.order(id: :asc)
    assert_equal comments.limit(2).to_a.last, comments.limit(2).last
    assert_equal comments.limit(2).to_a.last(2), comments.limit(2).last(2)
    assert_equal comments.limit(2).to_a.last(3), comments.limit(2).last(3)

    comments = comments.offset(1)
    assert_equal comments.limit(2).to_a.last, comments.limit(2).last
    assert_equal comments.limit(2).to_a.last(2), comments.limit(2).last(2)
    assert_equal comments.limit(2).to_a.last(3), comments.limit(2).last(3)
557 558
  end

559 560
  def test_take_and_first_and_last_with_integer_should_return_an_array
    assert_kind_of Array, Topic.take(5)
561 562 563 564
    assert_kind_of Array, Topic.first(5)
    assert_kind_of Array, Topic.last(5)
  end

D
David Heinemeier Hansson 已提交
565
  def test_unexisting_record_exception_handling
566
    assert_raise(ActiveRecord::RecordNotFound) {
D
David Heinemeier Hansson 已提交
567 568
      Topic.find(1).parent
    }
569

570
    Topic.find(2).topic
D
David Heinemeier Hansson 已提交
571
  end
572

573
  def test_find_only_some_columns
574
    topic = Topic.select("author_name").find(1)
575
    assert_raise(ActiveModel::MissingAttributeError) {topic.title}
576
    assert_raise(ActiveModel::MissingAttributeError) {topic.title?}
577
    assert_nil topic.read_attribute("title")
578 579
    assert_equal "David", topic.author_name
    assert !topic.attribute_present?("title")
580
    assert !topic.attribute_present?(:title)
581
    assert topic.attribute_present?("author_name")
582
    assert_respond_to topic, "author_name"
583
  end
J
Jeremy Kemper 已提交
584

585
  def test_find_on_array_conditions
586 587
    assert Topic.where(["approved = ?", false]).find(1)
    assert_raise(ActiveRecord::RecordNotFound) { Topic.where(["approved = ?", true]).find(1) }
D
David Heinemeier Hansson 已提交
588
  end
589

590
  def test_find_on_hash_conditions
591 592
    assert Topic.where(approved: false).find(1)
    assert_raise(ActiveRecord::RecordNotFound) { Topic.where(approved: true).find(1) }
593
  end
594

595
  def test_find_on_hash_conditions_with_explicit_table_name
596 597
    assert Topic.where('topics.approved' => false).find(1)
    assert_raise(ActiveRecord::RecordNotFound) { Topic.where('topics.approved' => true).find(1) }
598 599
  end

600
  def test_find_on_hash_conditions_with_hashed_table_name
601 602
    assert Topic.where(topics: { approved: false }).find(1)
    assert_raise(ActiveRecord::RecordNotFound) { Topic.where(topics: { approved: true }).find(1) }
603 604
  end

605 606 607 608 609 610
  def test_find_on_combined_explicit_and_hashed_table_names
    assert Topic.where('topics.approved' => false, topics: { author_name: "David" }).find(1)
    assert_raise(ActiveRecord::RecordNotFound) { Topic.where('topics.approved' => true, topics: { author_name: "David" }).find(1) }
    assert_raise(ActiveRecord::RecordNotFound) { Topic.where('topics.approved' => false, topics: { author_name: "Melanie" }).find(1) }
  end

611
  def test_find_with_hash_conditions_on_joined_table
612
    firms = Firm.joins(:account).where(:accounts => { :credit_limit => 50 })
613 614 615 616 617
    assert_equal 1, firms.size
    assert_equal companies(:first_firm), firms.first
  end

  def test_find_with_hash_conditions_on_joined_table_and_with_range
618
    firms = DependentFirm.joins(:account).where(name: 'RailsCore', accounts: { credit_limit: 55..60 })
619 620 621 622
    assert_equal 1, firms.size
    assert_equal companies(:rails_core), firms.first
  end

623 624 625 626 627 628 629 630
  def test_find_on_hash_conditions_with_explicit_table_name_and_aggregate
    david = customers(:david)
    assert Customer.where('customers.name' => david.name, :address => david.address).find(david.id)
    assert_raise(ActiveRecord::RecordNotFound) {
      Customer.where('customers.name' => david.name + "1", :address => david.address).find(david.id)
    }
  end

631
  def test_find_on_association_proxy_conditions
J
Jon Leighton 已提交
632
    assert_equal [1, 2, 3, 5, 6, 7, 8, 9, 10, 12], Comment.where(post_id: authors(:david).posts).map(&:id).sort
633 634
  end

635
  def test_find_on_hash_conditions_with_range
636 637
    assert_equal [1,2], Topic.where(id: 1..2).to_a.map(&:id).sort
    assert_raise(ActiveRecord::RecordNotFound) { Topic.where(id: 2..3).find(1) }
638
  end
639

640
  def test_find_on_hash_conditions_with_end_exclusive_range
641 642 643
    assert_equal [1,2,3], Topic.where(id: 1..3).to_a.map(&:id).sort
    assert_equal [1,2], Topic.where(id: 1...3).to_a.map(&:id).sort
    assert_raise(ActiveRecord::RecordNotFound) { Topic.where(id: 2...3).find(3) }
644 645
  end

646
  def test_find_on_hash_conditions_with_multiple_ranges
647 648
    assert_equal [1,2,3], Comment.where(id: 1..3, post_id: 1..2).to_a.map(&:id).sort
    assert_equal [1], Comment.where(id: 1..1, post_id: 1..10).to_a.map(&:id).sort
649
  end
650

651
  def test_find_on_hash_conditions_with_array_of_integers_and_ranges
652
    assert_equal [1,2,3,5,6,7,8,9], Comment.where(id: [1..2, 3, 5, 6..8, 9]).to_a.map(&:id).sort
653 654
  end

655 656 657 658
  def test_find_on_hash_conditions_with_array_of_ranges
    assert_equal [1,2,6,7,8], Comment.where(id: [1..2, 6..8]).to_a.map(&:id).sort
  end

659
  def test_find_on_multiple_hash_conditions
660 661 662 663
    assert Topic.where(author_name: "David", title: "The First Topic", replies_count: 1, approved: false).find(1)
    assert_raise(ActiveRecord::RecordNotFound) { Topic.where(author_name: "David", title: "The First Topic", replies_count: 1, approved: true).find(1) }
    assert_raise(ActiveRecord::RecordNotFound) { Topic.where(author_name: "David", title: "HHC", replies_count: 1, approved: false).find(1) }
    assert_raise(ActiveRecord::RecordNotFound) { Topic.where(author_name: "David", title: "The First Topic", replies_count: 1, approved: true).find(1) }
664
  end
665

666
  def test_condition_interpolation
667
    assert_kind_of Firm, Company.where("name = '%s'", "37signals").first
668 669 670
    assert_nil Company.where(["name = '%s'", "37signals!"]).first
    assert_nil Company.where(["name = '%s'", "37signals!' OR 1=1"]).first
    assert_kind_of Time, Topic.where(["id = %d", 1]).first.written_on
671 672
  end

673
  def test_condition_array_interpolation
674 675 676 677
    assert_kind_of Firm, Company.where(["name = '%s'", "37signals"]).first
    assert_nil Company.where(["name = '%s'", "37signals!"]).first
    assert_nil Company.where(["name = '%s'", "37signals!' OR 1=1"]).first
    assert_kind_of Time, Topic.where(["id = %d", 1]).first.written_on
D
David Heinemeier Hansson 已提交
678
  end
679

680
  def test_condition_hash_interpolation
681 682 683
    assert_kind_of Firm, Company.where(name: "37signals").first
    assert_nil Company.where(name: "37signals!").first
    assert_kind_of Time, Topic.where(id: 1).first.written_on
684
  end
685

686
  def test_hash_condition_find_malformed
687
    assert_raise(ActiveRecord::StatementInvalid) {
688
      Company.where(id: 2, dhh: true).first
689 690
    }
  end
691

692 693
  def test_hash_condition_find_with_escaped_characters
    Company.create("name" => "Ain't noth'n like' \#stuff")
694
    assert Company.where(name: "Ain't noth'n like' \#stuff").first
695 696 697
  end

  def test_hash_condition_find_with_array
698 699 700
    p1, p2 = Post.limit(2).order('id asc').to_a
    assert_equal [p1, p2], Post.where(id: [p1, p2]).order('id asc').to_a
    assert_equal [p1, p2], Post.where(id: [p1, p2.id]).order('id asc').to_a
701 702 703
  end

  def test_hash_condition_find_with_nil
704
    topic = Topic.where(last_read: nil).first
705 706
    assert_not_nil topic
    assert_nil topic.last_read
707
  end
D
David Heinemeier Hansson 已提交
708

709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750
  def test_hash_condition_find_with_aggregate_having_one_mapping
    balance = customers(:david).balance
    assert_kind_of Money, balance
    found_customer = Customer.where(:balance => balance).first
    assert_equal customers(:david), found_customer
  end

  def test_hash_condition_find_with_aggregate_attribute_having_same_name_as_field_and_key_value_being_aggregate
    gps_location = customers(:david).gps_location
    assert_kind_of GpsLocation, gps_location
    found_customer = Customer.where(:gps_location => gps_location).first
    assert_equal customers(:david), found_customer
  end

  def test_hash_condition_find_with_aggregate_having_one_mapping_and_key_value_being_attribute_value
    balance = customers(:david).balance
    assert_kind_of Money, balance
    found_customer = Customer.where(:balance => balance.amount).first
    assert_equal customers(:david), found_customer
  end

  def test_hash_condition_find_with_aggregate_attribute_having_same_name_as_field_and_key_value_being_attribute_value
    gps_location = customers(:david).gps_location
    assert_kind_of GpsLocation, gps_location
    found_customer = Customer.where(:gps_location => gps_location.gps_location).first
    assert_equal customers(:david), found_customer
  end

  def test_hash_condition_find_with_aggregate_having_three_mappings
    address = customers(:david).address
    assert_kind_of Address, address
    found_customer = Customer.where(:address => address).first
    assert_equal customers(:david), found_customer
  end

  def test_hash_condition_find_with_one_condition_being_aggregate_and_another_not
    address = customers(:david).address
    assert_kind_of Address, address
    found_customer = Customer.where(:address => address, :name => customers(:david).name).first
    assert_equal customers(:david), found_customer
  end

751 752
  def test_condition_utc_time_interpolation_with_default_timezone_local
    with_env_tz 'America/New_York' do
753
      with_timezone_config default: :local do
754
        topic = Topic.first
755
        assert_equal topic, Topic.where(['written_on = ?', topic.written_on.getutc]).first
756 757 758 759 760 761
      end
    end
  end

  def test_hash_condition_utc_time_interpolation_with_default_timezone_local
    with_env_tz 'America/New_York' do
762
      with_timezone_config default: :local do
763
        topic = Topic.first
764
        assert_equal topic, Topic.where(written_on: topic.written_on.getutc).first
765 766 767 768 769 770
      end
    end
  end

  def test_condition_local_time_interpolation_with_default_timezone_utc
    with_env_tz 'America/New_York' do
771
      with_timezone_config default: :utc do
772
        topic = Topic.first
773
        assert_equal topic, Topic.where(['written_on = ?', topic.written_on.getlocal]).first
774 775 776 777 778 779
      end
    end
  end

  def test_hash_condition_local_time_interpolation_with_default_timezone_utc
    with_env_tz 'America/New_York' do
780
      with_timezone_config default: :utc do
781
        topic = Topic.first
782
        assert_equal topic, Topic.where(written_on: topic.written_on.getlocal).first
783 784 785 786
      end
    end
  end

D
David Heinemeier Hansson 已提交
787
  def test_bind_variables
788 789 790 791
    assert_kind_of Firm, Company.where(["name = ?", "37signals"]).first
    assert_nil Company.where(["name = ?", "37signals!"]).first
    assert_nil Company.where(["name = ?", "37signals!' OR 1=1"]).first
    assert_kind_of Time, Topic.where(["id = ?", 1]).first.written_on
792
    assert_raise(ActiveRecord::PreparedStatementInvalid) {
793
      Company.where(["id=? AND name = ?", 2]).first
D
David Heinemeier Hansson 已提交
794
    }
795
    assert_raise(ActiveRecord::PreparedStatementInvalid) {
796
     Company.where(["id=?", 2, 3, 4]).first
D
David Heinemeier Hansson 已提交
797 798
    }
  end
799

D
David Heinemeier Hansson 已提交
800 801
  def test_bind_variables_with_quotes
    Company.create("name" => "37signals' go'es agains")
802
    assert Company.where(["name = ?", "37signals' go'es agains"]).first
D
David Heinemeier Hansson 已提交
803 804 805 806
  end

  def test_named_bind_variables_with_quotes
    Company.create("name" => "37signals' go'es agains")
807
    assert Company.where(["name = :name", {name: "37signals' go'es agains"}]).first
D
David Heinemeier Hansson 已提交
808 809 810
  end

  def test_named_bind_variables
811 812 813 814
    assert_kind_of Firm, Company.where(["name = :name", { name: "37signals" }]).first
    assert_nil Company.where(["name = :name", { name: "37signals!" }]).first
    assert_nil Company.where(["name = :name", { name: "37signals!' OR 1=1" }]).first
    assert_kind_of Time, Topic.where(["id = :id", { id: 1 }]).first.written_on
D
David Heinemeier Hansson 已提交
815 816 817
  end

  def test_string_sanitation
818 819
    assert_not_equal "'something ' 1=1'", ActiveRecord::Base.sanitize("something ' 1=1")
    assert_equal "'something; select table'", ActiveRecord::Base.sanitize("something; select table")
D
David Heinemeier Hansson 已提交
820 821 822 823 824 825 826 827 828
  end

  def test_count_by_sql
    assert_equal(0, Entrant.count_by_sql("SELECT COUNT(*) FROM entrants WHERE id > 3"))
    assert_equal(1, Entrant.count_by_sql(["SELECT COUNT(*) FROM entrants WHERE id > ?", 2]))
    assert_equal(2, Entrant.count_by_sql(["SELECT COUNT(*) FROM entrants WHERE id > ?", 1]))
  end

  def test_find_by_one_attribute
829
    assert_equal topics(:first), Topic.find_by_title("The First Topic")
D
David Heinemeier Hansson 已提交
830 831
    assert_nil Topic.find_by_title("The First Topic!")
  end
J
Jeremy Kemper 已提交
832

833 834
  def test_find_by_one_attribute_bang
    assert_equal topics(:first), Topic.find_by_title!("The First Topic")
835 836 837
    assert_raises_with_message(ActiveRecord::RecordNotFound, "Couldn't find Topic") do
      Topic.find_by_title!("The First Topic!")
    end
838 839
  end

840 841 842 843 844 845 846
  def test_find_by_on_attribute_that_is_a_reserved_word
    dog_alias = 'Dog'
    dog = Dog.create(alias: dog_alias)

    assert_equal dog, Dog.find_by_alias(dog_alias)
  end

847 848 849 850 851
  def test_find_by_one_attribute_that_is_an_alias
    assert_equal topics(:first), Topic.find_by_heading("The First Topic")
    assert_nil Topic.find_by_heading("The First Topic!")
  end

N
Nikita Afanasenko 已提交
852
  def test_find_by_one_attribute_bang_with_blank_defined
853 854
    blank_topic = BlankTopic.create(title: "The Blank One")
    assert_equal blank_topic, BlankTopic.find_by_title!("The Blank One")
N
Nikita Afanasenko 已提交
855 856
  end

857
  def test_find_by_one_attribute_with_conditions
J
Jon Leighton 已提交
858
    assert_equal accounts(:rails_core_account), Account.where('firm_id = ?', 6).find_by_credit_limit(50)
859 860
  end

861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894
  def test_find_by_one_attribute_that_is_an_aggregate
    address = customers(:david).address
    assert_kind_of Address, address
    found_customer = Customer.find_by_address(address)
    assert_equal customers(:david), found_customer
  end

  def test_find_by_one_attribute_that_is_an_aggregate_with_one_attribute_difference
    address = customers(:david).address
    assert_kind_of Address, address
    missing_address = Address.new(address.street, address.city, address.country + "1")
    assert_nil Customer.find_by_address(missing_address)
    missing_address = Address.new(address.street, address.city + "1", address.country)
    assert_nil Customer.find_by_address(missing_address)
    missing_address = Address.new(address.street + "1", address.city, address.country)
    assert_nil Customer.find_by_address(missing_address)
  end

  def test_find_by_two_attributes_that_are_both_aggregates
    balance = customers(:david).balance
    address = customers(:david).address
    assert_kind_of Money, balance
    assert_kind_of Address, address
    found_customer = Customer.find_by_balance_and_address(balance, address)
    assert_equal customers(:david), found_customer
  end

  def test_find_by_two_attributes_with_one_being_an_aggregate
    balance = customers(:david).balance
    assert_kind_of Money, balance
    found_customer = Customer.find_by_balance_and_name(balance, customers(:david).name)
    assert_equal customers(:david), found_customer
  end

895 896
  def test_dynamic_finder_on_one_attribute_with_conditions_returns_same_results_after_caching
    # ensure this test can run independently of order
A
Akira Matsuda 已提交
897
    class << Account; self; end.send(:remove_method, :find_by_credit_limit) if Account.public_methods.include?(:find_by_credit_limit)
J
Jon Leighton 已提交
898 899
    a = Account.where('firm_id = ?', 6).find_by_credit_limit(50)
    assert_equal a, Account.where('firm_id = ?', 6).find_by_credit_limit(50) # find_by_credit_limit has been cached
900 901
  end

902
  def test_find_by_one_attribute_with_several_options
J
Jon Leighton 已提交
903
    assert_equal accounts(:unknown), Account.order('id DESC').where('id != ?', 3).find_by_credit_limit(50)
904
  end
905

D
David Heinemeier Hansson 已提交
906
  def test_find_by_one_missing_attribute
907
    assert_raise(NoMethodError) { Topic.find_by_undertitle("The First Topic!") }
D
David Heinemeier Hansson 已提交
908
  end
909

910
  def test_find_by_invalid_method_syntax
911 912 913 914
    assert_raise(NoMethodError) { Topic.fail_to_find_by_title("The First Topic") }
    assert_raise(NoMethodError) { Topic.find_by_title?("The First Topic") }
    assert_raise(NoMethodError) { Topic.fail_to_find_or_create_by_title("Nonexistent Title") }
    assert_raise(NoMethodError) { Topic.find_or_create_by_title?("Nonexistent Title") }
915
  end
D
David Heinemeier Hansson 已提交
916 917

  def test_find_by_two_attributes
918
    assert_equal topics(:first), Topic.find_by_title_and_author_name("The First Topic", "David")
D
David Heinemeier Hansson 已提交
919 920 921
    assert_nil Topic.find_by_title_and_author_name("The First Topic", "Mary")
  end

922 923 924 925
  def test_find_by_two_attributes_but_passing_only_one
    assert_raise(ArgumentError) { Topic.find_by_title_and_author_name("The First Topic") }
  end

L
Lauro Caetano 已提交
926
  def test_find_last_with_offset
927
    devs = Developer.order('id')
L
Lauro Caetano 已提交
928 929 930 931 932 933 934

    assert_equal devs[2], Developer.offset(2).first
    assert_equal devs[-3], Developer.offset(2).last
    assert_equal devs[-3], Developer.offset(2).last
    assert_equal devs[-3], Developer.offset(2).order('id DESC').first
  end

D
David Heinemeier Hansson 已提交
935 936 937 938 939
  def test_find_by_nil_attribute
    topic = Topic.find_by_last_read nil
    assert_not_nil topic
    assert_nil topic.last_read
  end
940

D
David Heinemeier Hansson 已提交
941 942 943 944 945 946
  def test_find_by_nil_and_not_nil_attributes
    topic = Topic.find_by_last_read_and_author_name nil, "Mary"
    assert_equal "Mary", topic.author_name
  end

  def test_find_with_bad_sql
947
    assert_raise(ActiveRecord::StatementInvalid) { Topic.find_by_sql "select 1 from badtable" }
D
David Heinemeier Hansson 已提交
948 949
  end

950
  def test_find_all_with_join
951 952 953
    developers_on_project_one = Developer.
      joins('LEFT JOIN developers_projects ON developers.id = developers_projects.developer_id').
      where('project_id=1').to_a
954
    assert_equal 3, developers_on_project_one.length
955
    developer_names = developers_on_project_one.map(&:name)
956 957
    assert developer_names.include?('David')
    assert developer_names.include?('Jamis')
958
  end
959

960
  def test_joins_dont_clobber_id
961 962 963
    first = Firm.
      joins('INNER JOIN companies clients ON clients.firm_id = companies.id').
      where('companies.id = 1').first
964 965 966
    assert_equal 1, first.id
  end

967
  def test_joins_with_string_array
968 969 970 971
    person_with_reader_and_post = Post.
      joins(["INNER JOIN categorizations ON categorizations.post_id = posts.id",
             "INNER JOIN categories ON categories.id = categorizations.category_id AND categories.type = 'SpecialCategory'"
            ])
972 973 974
    assert_equal 1, person_with_reader_and_post.size
  end

975 976
  def test_find_by_id_with_conditions_with_or
    assert_nothing_raised do
J
Jon Leighton 已提交
977
      Post.where("posts.id <= 3 OR posts.#{QUOTED_TYPE} = 'Post'").find([1,2,3])
978 979
    end
  end
980

981
  def test_find_ignores_previously_inserted_record
A
Aaron Patterson 已提交
982
    Post.create!(:title => 'test', :body => 'it out')
J
Jon Leighton 已提交
983
    assert_equal [], Post.where(id: nil)
984 985
  end

986 987 988 989 990
  def test_find_by_empty_ids
    assert_equal [], Post.find([])
  end

  def test_find_by_empty_in_condition
991
    assert_equal [], Post.where('id in (?)', [])
992 993 994
  end

  def test_find_by_records
995 996 997
    p1, p2 = Post.limit(2).order('id asc').to_a
    assert_equal [p1, p2], Post.where(['id in (?)', [p1, p2]]).order('id asc')
    assert_equal [p1, p2], Post.where(['id in (?)', [p1, p2.id]]).order('id asc')
998 999
  end

1000 1001 1002 1003 1004 1005 1006 1007 1008
  def test_select_value
    assert_equal "37signals", Company.connection.select_value("SELECT name FROM companies WHERE id = 1")
    assert_nil Company.connection.select_value("SELECT name FROM companies WHERE id = -1")
    # make sure we didn't break count...
    assert_equal 0, Company.count_by_sql("SELECT COUNT(*) FROM companies WHERE name = 'Halliburton'")
    assert_equal 1, Company.count_by_sql("SELECT COUNT(*) FROM companies WHERE name = '37signals'")
  end

  def test_select_values
1009
    assert_equal ["1","2","3","4","5","6","7","8","9", "10", "11"], Company.connection.select_values("SELECT id FROM companies ORDER BY id").map!(&:to_s)
1010
    assert_equal ["37signals","Summit","Microsoft", "Flamboyant Software", "Ex Nihilo", "RailsCore", "Leetsoft", "Jadedpixel", "Odegy", "Ex Nihilo Part Deux", "Apex"], Company.connection.select_values("SELECT name FROM companies ORDER BY id")
1011 1012
  end

1013 1014
  def test_select_rows
    assert_equal(
1015
      [["1", "1", nil, "37signals"],
1016 1017
       ["2", "1", "2", "Summit"],
       ["3", "1", "1", "Microsoft"]],
1018
      Company.connection.select_rows("SELECT id, firm_id, client_of, name FROM companies WHERE id IN (1,2,3) ORDER BY id").map! {|i| i.map! {|j| j.to_s unless j.nil?}})
1019
    assert_equal [["1", "37signals"], ["2", "Summit"], ["3", "Microsoft"]],
1020
      Company.connection.select_rows("SELECT id, name FROM companies WHERE id IN (1,2,3) ORDER BY id").map! {|i| i.map! {|j| j.to_s unless j.nil?}}
1021 1022
  end

1023
  def test_find_with_order_on_included_associations_with_construct_finder_sql_for_association_limiting_and_is_distinct
R
Fix...  
Ryuta Kamizono 已提交
1024 1025 1026
    assert_equal 2, Post.includes(authors: :author_address).
      where.not(author_addresses: { id: nil }).
      order('author_addresses.id DESC').limit(2).to_a.size
1027

1028
    assert_equal 3, Post.includes(author: :author_address, authors: :author_address).
R
Fix...  
Ryuta Kamizono 已提交
1029 1030
      where.not(author_addresses_authors: { id: nil }).
      order('author_addresses_authors.id DESC').limit(3).to_a.size
1031 1032
  end

1033
  def test_find_with_nil_inside_set_passed_for_one_attribute
1034 1035 1036 1037
    client_of = Company.
      where(client_of: [2, 1, nil],
            name: ['37signals', 'Summit', 'Microsoft']).
      order('client_of DESC').
1038
      map(&:client_of)
1039

1040 1041
    assert client_of.include?(nil)
    assert_equal [2, 1].sort, client_of.compact.sort
1042 1043
  end

1044
  def test_find_with_nil_inside_set_passed_for_attribute
1045 1046 1047
    client_of = Company.
      where(client_of: [nil]).
      order('client_of DESC').
1048
      map(&:client_of)
1049 1050 1051 1052

    assert_equal [], client_of.compact
  end

1053
  def test_with_limiting_with_custom_select
1054
    posts = Post.references(:authors).merge(
1055
      :includes => :author, :select => 'posts.*, authors.id as "author_id"',
J
Jon Leighton 已提交
1056
      :limit => 3, :order => 'posts.id'
1057
    ).to_a
1058 1059
    assert_equal 3, posts.size
    assert_equal [0, 1, 1], posts.map(&:author_id).sort
1060
  end
1061

1062
  def test_find_one_message_with_custom_primary_key
1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078
    table_with_custom_primary_key do |model|
      model.primary_key = :name
      e = assert_raises(ActiveRecord::RecordNotFound) do
        model.find 'Hello World!'
      end
      assert_equal %Q{Couldn't find MercedesCar with 'name'=Hello World!}, e.message
    end
  end

  def test_find_some_message_with_custom_primary_key
    table_with_custom_primary_key do |model|
      model.primary_key = :name
      e = assert_raises(ActiveRecord::RecordNotFound) do
        model.find 'Hello', 'World!'
      end
      assert_equal %Q{Couldn't find all MercedesCars with 'name': (Hello, World!) (found 0 results, but was looking for 2)}, e.message
1079 1080 1081
    end
  end

1082 1083 1084 1085 1086 1087
  def test_find_without_primary_key
    assert_raises(ActiveRecord::UnknownPrimaryKey) do
      Matey.find(1)
    end
  end

1088
  def test_finder_with_offset_string
1089
    assert_nothing_raised(ActiveRecord::StatementInvalid) { Topic.offset("3").to_a }
1090 1091
  end

1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107
  test "find_by with hash conditions returns the first matching record" do
    assert_equal posts(:eager_other), Post.find_by(id: posts(:eager_other).id)
  end

  test "find_by with non-hash conditions returns the first matching record" do
    assert_equal posts(:eager_other), Post.find_by("id = #{posts(:eager_other).id}")
  end

  test "find_by with multi-arg conditions returns the first matching record" do
    assert_equal posts(:eager_other), Post.find_by('id = ?', posts(:eager_other).id)
  end

  test "find_by returns nil if the record is missing" do
    assert_equal nil, Post.find_by("1 = 0")
  end

1108 1109 1110 1111 1112
  test "find_by with associations" do
    assert_equal authors(:david), Post.find_by(author: authors(:david)).author
    assert_equal authors(:mary) , Post.find_by(author: authors(:mary) ).author
  end

1113 1114 1115 1116
  test "find_by doesn't have implicit ordering" do
    assert_sql(/^((?!ORDER).)*$/) { Post.find_by(id: posts(:eager_other).id) }
  end

1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138
  test "find_by! with hash conditions returns the first matching record" do
    assert_equal posts(:eager_other), Post.find_by!(id: posts(:eager_other).id)
  end

  test "find_by! with non-hash conditions returns the first matching record" do
    assert_equal posts(:eager_other), Post.find_by!("id = #{posts(:eager_other).id}")
  end

  test "find_by! with multi-arg conditions returns the first matching record" do
    assert_equal posts(:eager_other), Post.find_by!('id = ?', posts(:eager_other).id)
  end

  test "find_by! doesn't have implicit ordering" do
    assert_sql(/^((?!ORDER).)*$/) { Post.find_by!(id: posts(:eager_other).id) }
  end

  test "find_by! raises RecordNotFound if the record is missing" do
    assert_raises(ActiveRecord::RecordNotFound) do
      Post.find_by!("1 = 0")
    end
  end

1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158
  test "find on a scope does not perform statement caching" do
    honda = cars(:honda)
    zyke = cars(:zyke)
    tyre = honda.tyres.create!
    tyre2 = zyke.tyres.create!

    assert_equal tyre, honda.tyres.custom_find(tyre.id)
    assert_equal tyre2, zyke.tyres.custom_find(tyre2.id)
  end

  test "find_by on a scope does not perform statement caching" do
    honda = cars(:honda)
    zyke = cars(:zyke)
    tyre = honda.tyres.create!
    tyre2 = zyke.tyres.create!

    assert_equal tyre, honda.tyres.custom_find_by(id: tyre.id)
    assert_equal tyre2, zyke.tyres.custom_find_by(id: tyre2.id)
  end

D
David Heinemeier Hansson 已提交
1159
  protected
1160 1161 1162 1163 1164 1165 1166
    def table_with_custom_primary_key
      yield(Class.new(Toy) do
        def self.name
          'MercedesCar'
        end
      end)
    end
1167 1168 1169 1170 1171 1172

    def assert_raises_with_message(exception_class, message, &block)
      err = assert_raises(exception_class) { block.call }
      assert_match message, err.message
    end

D
David Heinemeier Hansson 已提交
1173
end