Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
b8418526
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
提交
b8418526
编写于
10月 04, 2019
作者:
R
Ryuta Kamizono
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Merge pull request #37360 from kamipo/deprecate_leaking_scope
Deprecate leaking scope in callback block for association relation
上级
65dba0a1
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
26 addition
and
3 deletion
+26
-3
activerecord/lib/active_record/association_relation.rb
activerecord/lib/active_record/association_relation.rb
+3
-0
activerecord/test/cases/associations/has_many_associations_test.rb
...ord/test/cases/associations/has_many_associations_test.rb
+22
-2
activerecord/test/models/bulb.rb
activerecord/test/models/bulb.rb
+1
-1
未找到文件。
activerecord/lib/active_record/association_relation.rb
浏览文件 @
b8418526
...
...
@@ -16,15 +16,18 @@ def ==(other)
end
def
build
(
*
args
,
&
block
)
block
=
_deprecated_scope_block
(
"new"
,
&
block
)
scoping
{
@association
.
build
(
*
args
,
&
block
)
}
end
alias
new
build
def
create
(
*
args
,
&
block
)
block
=
_deprecated_scope_block
(
"create"
,
&
block
)
scoping
{
@association
.
create
(
*
args
,
&
block
)
}
end
def
create!
(
*
args
,
&
block
)
block
=
_deprecated_scope_block
(
"create!"
,
&
block
)
scoping
{
@association
.
create!
(
*
args
,
&
block
)
}
end
...
...
activerecord/test/cases/associations/has_many_associations_test.rb
浏览文件 @
b8418526
...
...
@@ -2499,14 +2499,34 @@ def test_association_with_rewhere_doesnt_set_inverse_instance_key
test
"first_or_initialize adds the record to the association"
do
firm
=
Firm
.
create!
name:
"omg"
client
=
firm
.
clients_of_firm
.
first_or_initialize
client
=
firm
.
clients_of_firm
.
where
(
name:
"lol"
).
first_or_initialize
do
assert_deprecated
do
assert_equal
0
,
Client
.
count
end
end
assert_equal
[
client
],
firm
.
clients_of_firm
end
test
"first_or_create adds the record to the association"
do
firm
=
Firm
.
create!
name:
"omg"
firm
.
clients_of_firm
.
load_target
client
=
firm
.
clients_of_firm
.
first_or_create
name:
"lol"
client
=
firm
.
clients_of_firm
.
where
(
name:
"lol"
).
first_or_create
do
assert_deprecated
do
assert_equal
0
,
Client
.
count
end
end
assert_equal
[
client
],
firm
.
clients_of_firm
assert_equal
[
client
],
firm
.
reload
.
clients_of_firm
end
test
"first_or_create! adds the record to the association"
do
firm
=
Firm
.
create!
name:
"omg"
firm
.
clients_of_firm
.
load_target
client
=
firm
.
clients_of_firm
.
where
(
name:
"lol"
).
first_or_create!
do
assert_deprecated
do
assert_equal
0
,
Client
.
count
end
end
assert_equal
[
client
],
firm
.
clients_of_firm
assert_equal
[
client
],
firm
.
reload
.
clients_of_firm
end
...
...
activerecord/test/models/bulb.rb
浏览文件 @
b8418526
...
...
@@ -9,7 +9,7 @@ class Bulb < ActiveRecord::Base
after_initialize
:record_scope_after_initialize
def
record_scope_after_initialize
@scope_after_initialize
=
self
.
class
.
all
@scope_after_initialize
=
self
.
class
.
unscoped
.
all
end
after_initialize
:record_attributes_after_initialize
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录