1. 15 8月, 2019 1 次提交
  2. 09 8月, 2019 1 次提交
  3. 05 8月, 2019 1 次提交
  4. 29 7月, 2019 1 次提交
  5. 26 7月, 2019 1 次提交
  6. 25 7月, 2019 3 次提交
  7. 23 7月, 2019 3 次提交
  8. 11 7月, 2019 2 次提交
  9. 28 6月, 2019 1 次提交
  10. 17 6月, 2019 2 次提交
  11. 14 6月, 2019 5 次提交
  12. 13 6月, 2019 1 次提交
  13. 05 6月, 2019 1 次提交
    • M
      Preserve Bundle configuration during app generation (#34755) · b1464e34
      Marco Costa 提交于
      When generating a new rails application (rails new) using a custom template that
      includes gems from an authenticated source, the user has to provide credentials to
      bundler.
      
      One way to do this is by exporting environment variables, for example:
      
      export BUNDLE_GITHUB__COM=user:pass: provides credentials for bundler to fetch
      gems from github.com.
      
      The problem this PR addresses is that we are currently scrubs all /BUNDLE_.*/
      environment variables by wrapping our system calls in Bundler.with_clean_env.
      
      We do this because we don't want our commands executed against the generated project
      to use the generator's bundler environment (e.g. our gems): the generated project should
      use it's own configuration.
      
      The problem with Bundler.with_clean_env is that, on top of restoring environment
      variables to their original state, it also scrubs any /BUNDLE_.*/ variables, which is harmful for authenticated gem sources.
      
      This PR replaces Bundler.with_clean_env with Bundler.with_original_env, which only
      restores environment variables to their initial state, without additional scrubbing.
      b1464e34
  14. 15 5月, 2019 1 次提交
  15. 08 5月, 2019 4 次提交
  16. 18 4月, 2019 1 次提交
    • K
      Ignore artifacts from master · c617cc6b
      Kasper Timm Hansen 提交于
      If executing either `bin/test` in railties or `yarn build` in
      actioncable, some build artifacts are left over. The master branch
      git ignores those correctly.
      
      However, checking out 5-2-stable means I'll suddenly have to deal with
      them. Let's just ignore those artifacts here too.
      
      Proof:
      
      ```
      kaspth@kaspth-imac:~/code/rails (5-2-stable)$ git status
      On branch 5-2-stable
      Your branch is up to date with 'origin/5-2-stable'.
      
      Untracked files:
        (use "git add <file>..." to include in what will be committed)
      
              actioncable/app/javascript/
              railties/test/isolation/assets/
              tmp/
      ```
      c617cc6b
  17. 16 4月, 2019 1 次提交
  18. 10 4月, 2019 1 次提交
  19. 09 4月, 2019 1 次提交
  20. 31 3月, 2019 3 次提交
  21. 30 3月, 2019 1 次提交
  22. 29 3月, 2019 1 次提交
  23. 28 3月, 2019 3 次提交