Merge pull request #40219 from eileencodes/ensure-connects_to-is-always-called-on-base-or-abstract-classes

Ensure `connects_to` can only be called on base or abstract classes

`connectes_to` should only be called on `ActiveRecord::Base` or abstract
classes. This is recommended in the documentation but until now was not
enforced by the code. It's unsafe to open too many connections to mysql
(and probably other databases), so it's safest to have 1 class for the
connection and subclass from that.
Co-authored-by: NJohn Crepezzi <john.crepezzi@gmail.com>

This reverts commit 55d9e494, reversing
changes made to 03e987cd.

Legacy mysql adapter is already removed in #22642.

Translate Mysql2 errors in Mysql2Adapter#quote_string (take 2)

It will always be a hash since ee51b51b.

Remove unused @cache_hit Hash assignment

In 2abf6ca0 @cache_hit got introduced.
This was renamed to @cache_hits and revised in the subsequent commit
8240636b but it seems one assignment was
overlooked.

* Public services don’t respect `:disposition`, `:filename`, or `:content_type`.
* `:expires_in` is optional.

Rename Error#detail method as details

Plural is more expected.

Revert "Revert "Raise ConnectionNotEstablished rather than StatementInvalid in Mysql2Adapter#quote_string""

This reverts commit 6f92c40d.

Update Minitest to allow installation with Ruby 3.

https://github.com/seattlerb/minitest/commit/9713c5536287a028e3eeab04521b3dc22dc61724

Prior to this commit, when a translation key indicated that the
translation text was HTML, the value returned by `I18n.translate` would
always be marked as `html_safe`.  However, the value returned by
`I18n.translate` could be an untrusted value directly from
`options[:default]`.

This commit ensures values directly from `options[:default]` are not
marked as `html_safe`.

Prior to this commit, when a translation key indicated that the
translation text was HTML, the value returned by `I18n.translate` would
always be marked as `html_safe`.  However, the value returned by
`I18n.translate` could be an untrusted value directly from
`options[:default]`.

This commit ensures values directly from `options[:default]` are not
marked as `html_safe`.

Prior to this commit, when a translation key indicated that the
translation text was HTML, the value returned by `I18n.translate` would
always be marked as `html_safe`.  However, the value returned by
`I18n.translate` could be an untrusted value directly from
`options[:default]`.

This commit ensures values directly from `options[:default]` are not
marked as `html_safe`.

It is a common use case especially for MySQL users.

Revert #40178

Use a unique controller class per ActionView::TestCase

This reverts commit b8ab1f89, reversing
changes made to 73ae5655.

Properly support `reverse_order` on relations with `nulls_first` or `nulls_last` calls

If you're using the `nulls_first` or `nulls_last` functionality with an explicit ordering, then previously it wasn't properly handling calls to `#reverse` (called through `reverse_order`). This commit changes the behavior to match what would be expected.

It's faster on Ruby 2.7+ since it avoids rehashing the keys.

These methods are PostgreSQL-specific, and all supported versions of
PostgreSQL support validating constraints.

Add support for `NOT VALID` check constraints in PostgreSQL

Active Record already supports adding `NOT VALID` foreign key constraints in PostgreSQL, but back in #31323 when check constraint support was initially added, the ability to add a check constraint and validate it separately was not included. This adds that functionality!

Anchor BacktraceCleaner gem filter regexp

This ensures the default gem filter does not affect backtrace lines that
have a subpath incidentally matching a gem path.

Fixes #40196.

Closes #40187.

Update Gemfile.lock with rubocop-packaging

Load Rails tasks for each new Rake::Application

Follow-up to #40185.

Follow-up to #40143.

Rails Rake tasks are loaded for each new `Rake::Application` instance
via `Rails.application.load_tasks`.  However, under the hood,
`Rails.application.load_tasks` used `require` instead of `load`, which
caused Rails tasks to be loaded for only the first `Rake::Application`
instance.

This commit changes the relevant `require` to `load`.

Fixes #40184.

Update RuboCop to v0.90

Signed-off-by: NUtkarsh Gupta <utkarsh@debian.org>

Add explain to abstract database statements.

Support reversing of Arel expressions in reverse_order, last etc.

Shorten inspect on ActionDispatch::Request