1. 08 9月, 2018 7 次提交
  2. 07 9月, 2018 20 次提交
  3. 06 9月, 2018 7 次提交
  4. 05 9月, 2018 6 次提交
    • R
      Deprecate most methods which were never used in `DatabaseLimits` · e0a1235f
      Ryuta Kamizono 提交于
      `DatabaseLimits` and those methods were introduced at 3809c80c, but most
      methods were never used and never tested from the beginning (except
      `table_alias_length`, `index_name_length`, and `in_clause_length` (since
      66c09372)).
      
      There is no reason to maintain unused those methods for about 8 years.
      e0a1235f
    • I
      bcd11e07
    • E
      Merge pull request #33782 from mikhailov/patch-1 · bd932f5d
      Eileen M. Uchitelle 提交于
      Update documentation to ActionController::ConditionalGet
      bd932f5d
    • E
      Merge pull request #33781 from bogdanvlviv/fix-test-after-33637 · 5bd4a4c7
      Eileen M. Uchitelle 提交于
      Fix tests in `activerecord/test/cases/tasks/database_tasks_test.rb`
      5bd4a4c7
    • B
      Fix tests in `activerecord/test/cases/tasks/database_tasks_test.rb` · 5f244f6b
      bogdanvlviv 提交于
      After #33637 some tests in `activerecord/test/cases/tasks/database_tasks_test.rb`
      don't assert anything.
      We used to stub `ActiveRecord::Base::configurations` method in those
      tests like `ActiveRecord::Base.stub(:configurations, @configurations) {}`.
      Since #33637 `ActiveRecord::Base::configurations` is a `ActiveRecord::DatabaseConfigurations`
      object(not a Hash object) we can't do so anymore.
      `ActiveRecord::DatabaseConfigurations` object builds during `ActiveRecord::Base::configurations=`.
      We can replace `ActiveRecord::Base.stub(:configurations, @configurations) {}` to
      ```
      begin
        old_configurations = ActiveRecord::Base.configurations
        ActiveRecord::Base.configurations = @configurations
        # ...
      ensure
       ActiveRecord::Base.configurations = old_configurations
      end
      ```
      
      Also I fixed tests in `activerecord/test/cases/tasks/legacy_database_tasks_test.rb`
      But currently It looks like duplication of
      `activerecord/test/cases/tasks/database_tasks_test.rb`.
      We should improve those tests or remove them.
      
      I've tried (in `activerecord/test/cases/tasks/legacy_database_tasks_test.rb` file):
      ```
      def with_stubbed_configurations
        old_configurations = ActiveRecord::Base.configurations.to_h
        ActiveRecord::Base.configurations = @configurations
      
        ActiveRecord::Base.stub(:configurations, ActiveRecord::Base.configurations.to_h) do
          yield
        end
      ensure
        ActiveRecord::Base.configurations = old_configurations
      end
      ```
      but it causes erros in tests cases.
      
      After discussion we decided to remove
      `activerecord/test/cases/tasks/legacy_database_tasks_test.rb`
      
      Related to #33637
      5f244f6b
    • E
      Remove unused block · 35870148
      Eileen Uchitelle 提交于
      This method used to take a block, but that's no longer the case so we
      can delete the block from the method signature.
      35870148