- 30 3月, 2020 3 次提交
-
-
由 David Heinemeier Hansson 提交于
* require, require_relative, load by double quotes We're getting rid of all single quote usage, unless it serves a specific purpose, as per the general style guide.
-
由 Eugene Kenny 提交于
This test doesn't assert anything since e5a6f7ee.
-
由 Eugene Kenny 提交于
This was added in 9a27b297 to silence warnings about deprecated instance variables, see https://discuss.rubyonrails.org/t/internal-api-errors-in-edgerails/6082 for more details. The deprecations that it was silencing were removed in 83c8db98.
-
- 29 3月, 2020 10 次提交
-
-
由 eileencodes 提交于
-
由 Prathamesh Sonpatki 提交于
When we try to create a table which already exists which also adds indexes, then the `if_not_exists` option passed to `create_table` is not extended to indexes. So the migration results into an error if the table and indexes already exist. This change extends the `if_not_exists` support to `add_index` so that if the migration tries to create a table which also has existing indexes, error won't be raised. Also as a side-effect individual `add_index` calls will also accept `if_not_exists` option and respect it henceforth. [Prathamesh Sonpatki, Justin George]
-
由 Scott Blum 提交于
Base64 strict-encoded CSRF tokens are not inherently websafe, which makes them difficult to deal with. For example, the common practice of sending the CSRF token to a browser in a client-readable cookie does not work properly out of the box: the value has to be url-encoded and decoded to survive transport. Now, we generate Base64 urlsafe-encoded CSRF tokens, which are inherently safe to transport. Validation accepts both urlsafe tokens, and strict-encoded tokens for backwards compatibility.
-
由 Eugene Kenny 提交于
fix grammar - ci skip
-
由 londonoliver 提交于
-
由 Kasper Timm Hansen 提交于
-
由 Phil Ross 提交于
Co-authored-by: NJared Beck <jared@jaredbeck.com> Co-authored-by: NJonathan Hefner <jonathan@hefner.pro>
-
由 Kasper Timm Hansen 提交于
Introduce previously_new_record? on ActiveRecord::Base
-
由 Kasper Timm Hansen 提交于
-
- 28 3月, 2020 4 次提交
-
-
由 Eugene Kenny 提交于
Add rubocop group to Gemfile for use in CI
-
由 Eugene Kenny 提交于
Since c1e7268c we install the latest version of RuboCop in our GitHub Actions workflow for speed, but this sacrifices reproducibility; the results will change whenever RuboCop publishes a new version. Instead we can add a new group to our Gemfile that just contains the dependencies necessary to run RuboCop, and skip installing everything else in CI. Unfortunately it's not possible to tell Bundler to only install gems from a single group, so we have to tell it not to install every other group instead.
-
由 Rafael França 提交于
Simplify GitHub Action RuboCop by using globally installed gems
-
由 Olle Jonsson 提交于
-
- 27 3月, 2020 5 次提交
-
-
由 Ryuta Kamizono 提交于
[ci skip] Fix API documentation for link_to_if
-
由 Josua Schmid 提交于
-
由 Eugene Kenny 提交于
Handle paths with trailing slashes in rails test
-
由 Eugene Kenny 提交于
The `rails test` command scans its arguments for test paths to load before handing off option parsing to Minitest. To avoid incorrectly interpreting a `-n /regex/` pattern as an absolute path to a directory, it skips arguments that end with a slash. However a relative path ending in a slash is not ambiguous, so we can safely treat those as test paths. This is especially useful in bash, where tab completing a directory leaves a trailing slash in place.
-
由 eileencodes 提交于
This reverts commit f265e0dd, reversing changes made to 08dfa921. Reverted due to surprising behavior for applications. We need to deprecate this behavior first instead of raising by default.
-
- 25 3月, 2020 5 次提交
-
-
由 Eugene Kenny 提交于
Adds default message for :only_integer validation
-
由 Evan Brodie 提交于
This adds consistency to the documentation because all other options to the `:numericality` validator have their default error messages mentioned.
-
由 Ryuta Kamizono 提交于
Restore the `lookup_store` compatibility to accept config as a single object
-
由 Ryuta Kamizono 提交于
fa986ae0 broke the `lookup_store` compatibility. It's public API so deprecation cycle is required if we want to make a breaking change.
-
由 Alexey Vasiliev 提交于
-
- 24 3月, 2020 4 次提交
-
-
由 Rikki Pitt 提交于
Expose the Mailgun SMTP recipient to Action Mailbox as X-Original-To, like Postfix. Allows handling BCCed recipients who aren't listed in To/CC fields.
-
由 Aaron Patterson 提交于
Refactoring PartialRenderer
-
由 rmacklin 提交于
* Clean up leftover plural "gems" references as a follow-up to ab123a33 * Remove mention of generating CoffeeScript files in Preprocessing section * Clarify what sass-rails is used for * Link to the sass-rails repo and sass-lang.com * Remove mention of the deprecated `sass` gem to reflect the change from https://github.com/rails/sass-rails/commit/409d871c2a971691eac86c5a32e614e2941c72b8
-
由 Aaron Patterson 提交于
-
- 23 3月, 2020 7 次提交
-
-
由 Ryuta Kamizono 提交于
[Guides] line-height should be unitless
-
由 Ryuta Kamizono 提交于
[Guides] Remove unused fixes.css
-
由 Juanito Fatas 提交于
I checked generated guides‘s HTML and no one references .syntaxhighlighter.
-
由 Juanito Fatas 提交于
When line-height has unit, it will have unexpected results. Based on recommendations by MDN[1] and CSSTricks[2]. [1] MDN https://developer.mozilla.org/en-US/docs/Web/CSS/line-height#Prefer_unitless_numbers_for_line-height_values [2] CSS Tricks https://css-tricks.com/almanac/properties/l/line-height/#article-header-id-0
-
由 Kasper Timm Hansen 提交于
Removed unnecessary words from Getting Started docs
-
由 Carlos Antonio da Silva 提交于
-
由 Eugene Kenny 提交于
Sanitize and add missing docs on `ActiveJob::QueueAdapters` class. [ci skip]
-
- 22 3月, 2020 2 次提交
-
-
由 Dino Maric 提交于
I guess `NO` is pretty self-explanatory here. But, to be consistent, this commit describes what does **NO** mean in the context of: `retries, timeaout and priorities`.
-
由 Eugene Kenny 提交于
Update package.json to install fsevents on node >= 12
-