1. 05 12月, 2018 1 次提交
  2. 20 11月, 2018 1 次提交
  3. 08 11月, 2018 1 次提交
  4. 10 10月, 2018 1 次提交
    • E
      Add allocations to template renderer subscription · e8c1be4a
      Eileen Uchitelle 提交于
      This PR adds the allocations to the instrumentation for template and
      partial rendering.
      
      Before:
      
      ```
        Rendering posts/new.html.erb within layouts/application
        Rendered posts/_form.html.erb (9.7ms)
        Rendered posts/new.html.erb within layouts/application (10.9ms)
      Completed 200 OK in 902ms (Views: 890.8ms | ActiveRecord: 0.8ms)
      ```
      
      After:
      
      ```
        Rendering posts/new.html.erb within layouts/application
        Rendered posts/_form.html.erb (Duration: 7.1ms | Allocations: 6004)
        Rendered posts/new.html.erb within layouts/application (Duration: 8.3ms | Allocations: 6654)
      Completed 200 OK in 858ms (Views: 848.4ms | ActiveRecord: 0.4ms | Allocations: 1539564)
      ```
      e8c1be4a
  5. 02 10月, 2018 1 次提交
    • J
      respect path_only option when an array is passed into url_for · b48c2ade
      Joel Ambass 提交于
      The url_for method is now extracting the path_only option in order to determine if polymorphic_path or polymorphic_url should be called.
      
      If the path_only option is not set it will be set to true unless the host option is set. This behaviour is the same as when a Hash or Params object is passed.
      
      To support this unifying the code responsible for setting this default value has been extracted into a private method
      b48c2ade
  6. 07 9月, 2018 1 次提交
  7. 08 8月, 2018 2 次提交
  8. 07 8月, 2018 1 次提交
  9. 16 7月, 2018 1 次提交
    • G
      Fix issue with `button_to`'s `to_form_params` · 113d8a2b
      Georgi Georgiev 提交于
      `button_to` was throwing exception when invoked with `params` hash that
      contains symbol and string keys. The reason for the exception was that
      `to_form_params` was comparing the given symbol and string keys.
      
      The issue is fixed by turning all keys to strings inside
      `to_form_params` before comparing them.
      113d8a2b
  10. 04 7月, 2018 1 次提交
  11. 10 6月, 2018 1 次提交
    • K
      Add `year_format` option to date_select tag. This option makes it possible to customize year · 8f46a23d
      Koki Ryu 提交于
      names. Lambda should be passed to use this option. Example:
      
          date_select('user_birthday', '', start_year: 1998, end_year: 2000, year_format: ->year { "Heisei #{year - 1988}" })
      
      The HTML produced:
      
          <select id="user_birthday__1i" name="user_birthday[(1i)]">
          <option value="1998">Heisei 10</option>
          <option value="1999">Heisei 11</option>
          <option value="2000">Heisei 12</option>
          </select>
          /* The rest is omitted */
      8f46a23d
  12. 20 4月, 2018 1 次提交
  13. 18 4月, 2018 1 次提交
  14. 07 4月, 2018 2 次提交
    • B
      Fix `actionview/CHANGELOG.md` · f0bde016
      bogdanvlviv 提交于
      - Add missing dots at the end of sentences.
      - Wrap RecordTagHelper into `.
      - `RecordTagHelper` => `ActionView::Helpers::RecordTagHelper`.
      
      [ci skip]
      f0bde016
    • Y
      Remove RecordTagHelper · 5c5ddd69
      Yoshiyuki Hirano 提交于
      * Since #18411, we started to inform about extracted gem (record_tag_helper)
        to developers who use `ActionView::Helpers::RecordTagHelper` 's methods.
      
      * Currently, it seems no problem that we don't have to support no longer.
      5c5ddd69
  15. 03 4月, 2018 1 次提交
    • S
      Add `action_view.finalize_compiled_template_methods` config option · eede8d81
      Simon Coffey 提交于
      ActionView::Template instances compile their source to methods on the
      ActionView::CompiledTemplates module. To prevent leaks in development
      mode, where templates can frequently change, a finalizer is added that
      undefines these methods[1] when the templates are garbage-collected.
      
      This is undesirable in the test environment, however, as templates don't
      change during the life of the test. Moreover, the cost of undefining a
      method is proportional to the number of descendants a class or module
      has, since the method cache must be cleared for all descendant classes.
      
      As ActionView::CompiledTemplates is mixed into every
      ActionView::TestCase (or in RSpec suites, every view spec example
      group), it can end up with a very large number of descendants, and
      undefining its methods can become very expensive.
      
      In large test suites, this results in a long delay at the end of the
      test suite as all template finalizers are run, only for the process to
      then exit.
      
      To avoid this unnecessary cost, this change adds a config option,
      `action_view.finalize_compiled_template_methods`, defaulting to true,
      and sets it to false in the test environment only.
      
      [1] https://github.com/rails/rails/blob/09b2348f7fc8d4e7191e70e06608c5909067e2aa/actionview/lib/action_view/template.rb#L118-L126
      eede8d81
  16. 01 4月, 2018 1 次提交
  17. 14 3月, 2018 1 次提交
  18. 12 3月, 2018 1 次提交
    • B
      Fix CHANGELOGs [ci skip] · dd075657
      bogdanvlviv 提交于
      - Add missing dots.
      - Remove reference to itself on GitHub.
        Usually, we add references to fixed issues only in a changelog.
      
      Follow up #32223
      dd075657
  19. 28 2月, 2018 2 次提交
  20. 27 2月, 2018 2 次提交
  21. 18 2月, 2018 1 次提交
  22. 31 1月, 2018 1 次提交
  23. 28 12月, 2017 1 次提交
  24. 01 12月, 2017 1 次提交
  25. 29 11月, 2017 2 次提交
  26. 28 11月, 2017 1 次提交
  27. 26 11月, 2017 1 次提交
    • N
      Change `form_with` to generates ids by default · 260d6f11
      npezza93 提交于
      When `form_with` was introduced we disabled the automatic
      generation of ids that was enabled in `form_for`. This usually
      is not an good idea since labels don't work when the input
      doesn't have an id and it made harder to test with Capybara.
      
      You can still disable the automatic generation of ids setting
      `config.action_view.form_with_generates_ids` to `false.`
      260d6f11
  28. 10 11月, 2017 1 次提交
    • N
      Fix field_error_proc wrap form select optgroup and divider option tag · ead4776b
      neumayr 提交于
      ### Summary
      
      The [`:field_error_proc`](https://github.com/rails/rails/blob/master/actionview/lib/action_view/base.rb#L145) is responsible for decorating input tags that refer to attributes with errors. This default build-in rails feature wrap invalid form elements with additional markup: `<div class="field_with_errors">[…]</div>`.
      
      * Fix for `field_error_proc` wraps form select `optgroup`
      * Fix for `field_error_proc` wraps form select divider `option`
      * Add tests for uncovered elements with errors
      
      [Fixes #31088]
      
      #### Test coverage
      * `test_select_grouped_options_with_errors`
      * `test_time_zone_select_with_priority_zones_and_errors`
      
      #### Extend test coverage
      * `test_collection_select_with_errors`
      * `test_label_with_errors`
      * `test_check_box_with_errors`
      * `test_check_boxes_with_errors`
      * `test_radio_button_with_errors`
      * `test_radio_buttons_with_errors`
      * `test_collection_check_boxes_with_errors`
      * `test_collection_radio_buttons_with_errors`
      ead4776b
  29. 24 10月, 2017 1 次提交
  30. 18 8月, 2017 1 次提交
    • C
      Do not generate default alt text in image tags · 9a74c7b9
      Cameron Cundiff 提交于
      - Auto-generating content from the filename of an image is not suitable
        alternative text; alt text that isn't fully considered can be
        distracting and fatiguing for screen readers users (blind, low vision,
        dyslexic people).
      - Setting a filename fallback short circuits screen reader default
        behavior and configuration for blank descriptions.
      - Setting poor defaults also creates false negatives for accessibility
        linting and testing software, that makes it harder to improve
        application accessibility.
      
      ***
      
      - After this change, if authors leave images without alt text, screen
        readers will fallback to default behavior for missing alt text.
      - Also with this change, Automated linting and testing tools will
        correctly generate warnings.
      
      [Fixes #30096]
      9a74c7b9
  31. 29 6月, 2017 1 次提交
  32. 28 6月, 2017 1 次提交
  33. 20 6月, 2017 1 次提交
  34. 11 6月, 2017 1 次提交
  35. 20 5月, 2017 1 次提交