with change to ActiveSupport::Notifications::Instrumenter#instrument

  * Update #instrument to make passing a block optional. This will let users
    leverage #instrument for messaging in addition to instrumentation.

Add support for annotating queries generated by ActiveRecord::Relation with SQL comments

Prefer render template: over render file: in tests

This patch has two main portions:

1. Add SQL comment support to Arel via Arel::Nodes::Comment.
2. Implement a Relation#annotate method on top of that.

== Adding SQL comment support

Adds a new Arel::Nodes::Comment node that represents an optional SQL
comment and teachers the relevant visitors how to handle it.

Comment nodes may be added to the basic CRUD statement nodes and set
through any of the four (Select|Insert|Update|Delete)Manager objects.

For example:

    manager = Arel::UpdateManager.new
    manager.table table
    manager.comment("annotation")
    manager.to_sql # UPDATE "users" /* annotation */

This new node type will be used by ActiveRecord::Relation to enable
query annotation via SQL comments.

== Implementing the Relation#annotate method

Implements `ActiveRecord::Relation#annotate`, which accepts a comment
string that will be appeneded to any queries generated by the relation.

Some examples:

    relation = Post.where(id: 123).annotate("metadata string")
    relation.first
    # SELECT "posts".* FROM "posts" WHERE "posts"."id" = 123
    # LIMIT 1 /* metadata string */

    class Tag < ActiveRecord::Base
      scope :foo_annotated, -> { annotate("foo") }
    end
    Tag.foo_annotated.annotate("bar").first
    # SELECT "tags".* FROM "tags" LIMIT 1 /* foo */ /* bar */

Also wires up the plumbing so this works with `#update_all` and
`#delete_all` as well.

This feature is useful for instrumentation and general analysis of
queries generated at runtime.

Since https://github.com/puma/puma/pull/1700, the default host is
correctly used. So `localhost` is used instead of `0.0.0.0`.

As a result, the log output on restart is changed, and the restart test
fails on Puma 3.12.1.
https://travis-ci.org/rails/rails/jobs/509239592#L2303-L2305

Specify binding explicitly to avoid being affected by Puma changes.

Many tests were using `render file:`, but were only testing the
behaviour of `render template:` (file: just allows more paths/ is less
secure then template:).

The reason for so many `render file:` is probably that they were the old
default.

This commit replaces `render file:` with `render template:` anywhere the
test wasn't specifically interested in using `render file:`.

* Show options as list.
* Fix incorrect quoting.

Document option forwarding in ActiveRecord::Base.attribute

This has been supported for a while but we didn't have documentation
for it.

Bulk Insert: Reuse indexes for unique_by

Validate types assigned to LookupContext#formats=

I found `:unique_by` with `:columns` and `:where` inside it tough to
grasp. The documentation only mentioned indexes and partial indexes.
So why duplicate a model's indexes in an insert_all/upsert_all call
when we can just look it up?

This has the added benefit of raising if no index is found, such that
people can't insert thousands of records without relying on an index
of some form.

Add mention about `process_middleware.action_dispatch` in the guide [ci skip]

Make aliases of `database` option in generators work

Thor automatically adds `-` if aliases do not start with `-`.
https://github.com/erikhuda/thor/blob/0879c1773d188902d54f95174f33961ac33111f8/lib/thor/parser/options.rb#L53

But Thor follows a convention of one-dash-one-letter options.
So, even if `-` is added to `db`, it does not work.
https://github.com/erikhuda/thor/blob/0879c1773d188902d54f95174f33961ac33111f8/lib/thor/parser/options.rb#L4

Follow up #34021.

We added ActiveSupport::Notifications instrumentation of the processing of each middleware in the stack,
See 04ae0b0b.

Don't override @set_cookies on CookieJar#update_cookies_from_jar'

Give GeneratedAttributeMethods module a name

Merge pull request #35675 from larouxn/revert-35656-revert-34277-remove-javascripts-javascripts_engine-options-for-generators

Revert "Revert "Remove `javascripts` and `javascript_engine` options for generators""

This test was trying to set the exception_app in the wrapper proxy
instead in the middleware itself.

Re-add Template#updated_at as deprecated

Merge pull request #35656 from larouxn/revert-34277-remove-javascripts-javascripts_engine-options-for-generators

Revert "Remove `javascripts` and `javascript_engine` options for generators"

Remove roflscaling

Remove virtual_path from fallback templates

Extract `sanitize_as_sql_comment` from SQL visitor into connection

Update regular expression for checking valid MIME type

Adds ActiveSupport::Notifications instrumentation of the processing of
each middleware in the stack.

MIME Type validation regular expression does not allow for MIME types initialized with strings that contain parameters after the MIME type name.

Add documentation for the resource(s) :param option

* update_at/on note for ActiveRecord::Relation.update_all

* Verbatim updated_at/on