1. 28 5月, 2019 1 次提交
  2. 25 4月, 2019 2 次提交
  3. 20 4月, 2019 1 次提交
  4. 04 4月, 2019 1 次提交
  5. 02 4月, 2019 2 次提交
  6. 31 3月, 2019 1 次提交
  7. 23 3月, 2019 2 次提交
  8. 11 3月, 2019 1 次提交
    • E
      Prep release · 7c87fd56
      eileencodes 提交于
      * Update RAILS_VERSION
      * Bundle
      * rake update_versions
      * rake changelog:header
      7c87fd56
  9. 26 2月, 2019 1 次提交
  10. 07 2月, 2019 2 次提交
  11. 28 1月, 2019 1 次提交
  12. 26 1月, 2019 1 次提交
  13. 19 1月, 2019 2 次提交
  14. 18 1月, 2019 1 次提交
  15. 27 12月, 2018 1 次提交
    • G
      Don't expect defined protect_against_forgery? in {token,csrf_meta}_tag · a58db74c
      Genadi Samokovarov 提交于
      The `#csrf_meta_tags` and `#token_tag` Action View helper methods are
      expecting the class in which are included to explicitly define the
      method `#protect_against_forgery?` or else they will fail with
      `NoMethodError`.
      
      This is a problem if you want to use Action View outside of Rails
      applications. For example, in #34788 I used the `#button_to` helper
      inside of the error pages templates that have a custom
      `ActionView::Base` subclass, which did not defined
      `#protect_against_forgery?` and trying to call the button failed.
      
      I had to dig inside of Action View to find-out what's was going on. I
      think we should either set a default method implementation in the
      helpers or check for the method definition, but don't explicitly require
      the presence of `#protect_against_forgery?` in every `ActionViews::Base`
      subclass as the errors are hard to figure out.
      a58db74c
  16. 20 12月, 2018 1 次提交
  17. 06 12月, 2018 1 次提交
  18. 05 12月, 2018 1 次提交
  19. 20 11月, 2018 1 次提交
  20. 08 11月, 2018 1 次提交
  21. 10 10月, 2018 1 次提交
    • E
      Add allocations to template renderer subscription · e8c1be4a
      Eileen Uchitelle 提交于
      This PR adds the allocations to the instrumentation for template and
      partial rendering.
      
      Before:
      
      ```
        Rendering posts/new.html.erb within layouts/application
        Rendered posts/_form.html.erb (9.7ms)
        Rendered posts/new.html.erb within layouts/application (10.9ms)
      Completed 200 OK in 902ms (Views: 890.8ms | ActiveRecord: 0.8ms)
      ```
      
      After:
      
      ```
        Rendering posts/new.html.erb within layouts/application
        Rendered posts/_form.html.erb (Duration: 7.1ms | Allocations: 6004)
        Rendered posts/new.html.erb within layouts/application (Duration: 8.3ms | Allocations: 6654)
      Completed 200 OK in 858ms (Views: 848.4ms | ActiveRecord: 0.4ms | Allocations: 1539564)
      ```
      e8c1be4a
  22. 02 10月, 2018 1 次提交
    • J
      respect path_only option when an array is passed into url_for · b48c2ade
      Joel Ambass 提交于
      The url_for method is now extracting the path_only option in order to determine if polymorphic_path or polymorphic_url should be called.
      
      If the path_only option is not set it will be set to true unless the host option is set. This behaviour is the same as when a Hash or Params object is passed.
      
      To support this unifying the code responsible for setting this default value has been extracted into a private method
      b48c2ade
  23. 07 9月, 2018 1 次提交
  24. 08 8月, 2018 2 次提交
  25. 07 8月, 2018 1 次提交
  26. 16 7月, 2018 1 次提交
    • G
      Fix issue with `button_to`'s `to_form_params` · 113d8a2b
      Georgi Georgiev 提交于
      `button_to` was throwing exception when invoked with `params` hash that
      contains symbol and string keys. The reason for the exception was that
      `to_form_params` was comparing the given symbol and string keys.
      
      The issue is fixed by turning all keys to strings inside
      `to_form_params` before comparing them.
      113d8a2b
  27. 04 7月, 2018 1 次提交
  28. 10 6月, 2018 1 次提交
    • K
      Add `year_format` option to date_select tag. This option makes it possible to customize year · 8f46a23d
      Koki Ryu 提交于
      names. Lambda should be passed to use this option. Example:
      
          date_select('user_birthday', '', start_year: 1998, end_year: 2000, year_format: ->year { "Heisei #{year - 1988}" })
      
      The HTML produced:
      
          <select id="user_birthday__1i" name="user_birthday[(1i)]">
          <option value="1998">Heisei 10</option>
          <option value="1999">Heisei 11</option>
          <option value="2000">Heisei 12</option>
          </select>
          /* The rest is omitted */
      8f46a23d
  29. 20 4月, 2018 1 次提交
  30. 18 4月, 2018 1 次提交
  31. 07 4月, 2018 2 次提交
    • B
      Fix `actionview/CHANGELOG.md` · f0bde016
      bogdanvlviv 提交于
      - Add missing dots at the end of sentences.
      - Wrap RecordTagHelper into `.
      - `RecordTagHelper` => `ActionView::Helpers::RecordTagHelper`.
      
      [ci skip]
      f0bde016
    • Y
      Remove RecordTagHelper · 5c5ddd69
      Yoshiyuki Hirano 提交于
      * Since #18411, we started to inform about extracted gem (record_tag_helper)
        to developers who use `ActionView::Helpers::RecordTagHelper` 's methods.
      
      * Currently, it seems no problem that we don't have to support no longer.
      5c5ddd69
  32. 03 4月, 2018 1 次提交
    • S
      Add `action_view.finalize_compiled_template_methods` config option · eede8d81
      Simon Coffey 提交于
      ActionView::Template instances compile their source to methods on the
      ActionView::CompiledTemplates module. To prevent leaks in development
      mode, where templates can frequently change, a finalizer is added that
      undefines these methods[1] when the templates are garbage-collected.
      
      This is undesirable in the test environment, however, as templates don't
      change during the life of the test. Moreover, the cost of undefining a
      method is proportional to the number of descendants a class or module
      has, since the method cache must be cleared for all descendant classes.
      
      As ActionView::CompiledTemplates is mixed into every
      ActionView::TestCase (or in RSpec suites, every view spec example
      group), it can end up with a very large number of descendants, and
      undefining its methods can become very expensive.
      
      In large test suites, this results in a long delay at the end of the
      test suite as all template finalizers are run, only for the process to
      then exit.
      
      To avoid this unnecessary cost, this change adds a config option,
      `action_view.finalize_compiled_template_methods`, defaulting to true,
      and sets it to false in the test environment only.
      
      [1] https://github.com/rails/rails/blob/09b2348f7fc8d4e7191e70e06608c5909067e2aa/actionview/lib/action_view/template.rb#L118-L126
      eede8d81
  33. 01 4月, 2018 1 次提交