1. 13 12月, 2018 1 次提交
  2. 12 12月, 2018 8 次提交
  3. 11 12月, 2018 11 次提交
  4. 09 12月, 2018 1 次提交
  5. 08 12月, 2018 5 次提交
  6. 07 12月, 2018 5 次提交
    • E
      Rename error that occurs when writing on a read · db54afba
      Eileen Uchitelle 提交于
      I originally named this `StatementInvalid` because that's what we do in
      GitHub, but `@tenderlove` pointed out that this means apps can't test
      for or explitly rescue this error. `StatementInvalid` is pretty broad so
      I've renamed this to `ReadOnlyError`.
      db54afba
    • R
      Merge pull request #34643 from albertoalmagro/move-type-method-to-symbol · de06d767
      Ryuta Kamizono 提交于
      Move type method inside ActionDispatch::Journey::Nodes::Symbol
      de06d767
    • Y
      Make `deprecate` work for non-exists methods · 59ff1ba3
      yuuji.yaginuma 提交于
      Before #33325, `deprecate` works for non-exist methods.
      This is necessary, for example, if want to deprecate dynamically defined
      methods like attributes methods.
      
      Fixes #34646
      59ff1ba3
    • A
      Expand metaprogramming for Symbol, Slash and Dot. · 0086400d
      Alberto Almagro 提交于
      This first started with moving type method inside
      `ActionDispatch::Journey::Nodes::Symbol`.
      
      `AD::Journey::Nodes::Symbol#type` was generated dynamically with an
      `each` block. While this is OK for classes like `AD::Journey::Nodes::Slash`
      or `AD::Journey::Nodes::Dot` which don't have further implementation, all
      other classes containing more logic have this method defined in their class
      body. This patch does the same in this case.
      
      On code review process @kamipo suggested to fully expand over
      metaprogramming for Slash and Dot classes, a topic on which I agree with him.
      0086400d
    • D
      Abort early if generator command fails (#34420) · f173ec77
      David Rodríguez 提交于
      * No need to go through ruby
      
      * Abort early if a generator command fails
      
      * Reuse `rails_command` method
      
      * Bump thor minimum dependency to 0.20.3
      
      * Add some minimal docs
      
      * Add a changelog entry
      
      * Restore original logging
      f173ec77
  7. 06 12月, 2018 8 次提交
  8. 05 12月, 2018 1 次提交