See parent commit for more info.

Thor will show a deprecation if a command fails and this method is not
define. We should investigate which command we want to return a non-zero
status when it fails but for now I'm just disabling the warning and
keeping the old behavior.

Fix autosave validation context regression

Follow up #37303.

https://buildkite.com/rails/rails/builds/63957#dc16cd12-10a2-435c-9b64-b8332114d92a/981-1293

Use String#+@ before mutating the result of Symbol#to_s

Rollback in `after_commit` should not rollback state that already been succeeded

Fix "autosave: true" on belongs_to of join model causes invalid records to be saved

Add doc about I18n support for :placeholder option [ci skip]

Since 9c913116, if you run `rackup`
in a machine that doesn't have that folder, the server will not start.

This doesn't happen on `rails s` because we create that folder when
starting the server on
https://github.com/rails/rails/blob/8c8b02784a637570451d7810fd3dfed4eae9a77d/railties/lib/rails/commands/server/server_command.rb#L70-L74.

Remove lock from method model

Ruby 2.7 warning: creating a Proc without a block

Not needed. Since rails-html-sanitizer 1.2.0 removes the needless
deprecations.

This reverts commit 2cd4bce8.

- The sanitizer has been changed to safe_list_sanitizer.

The DATABASE_URL shouldn't change other environments when loaded. This
test verifies this behavior.
Co-Authored-By: NJohn Crepezzi <seejohnrun@github.com>

Fix index_exists? for PostgreSQL expression indexes

Make ActiveSupport::Logger Fiber-safe

Don't validate non dirty association targets

Add pidfile option to puma config template

Port caching documentation fix to stable-5.2

Fix host for ActiveStorage DiskService

Merge pull request #36647 from giraffate/fix_exists_with_distinct_and_offset_and_order_in_postgresql

Fix `relation.exists?` with giving `distinct`, `offset` and `order` for joined table

Fix query cache when using shared connections

PostgreSQL: Fix GROUP BY with ORDER BY virtual count attribute

This is also resolved in `arel_column`.

Fix sqlite3 collation parsing when using decimal columns.

Fix programmatic clicks with data-remote

[ci skip] Use default path in button_to documentation

* Make ActiveRecord `ConnectionPool.connections` thread-safe.

ConnectionPool documentation is clear on the need to synchronize
access to @connections but also states that public methods do not
require synchronization. Existing code exposed @connections
directly via attr_reader. The fix uses synchronize() to lock
@connections then returns a copy to the caller using Array.dup().

Includes comments on the connections method that thread-safe access
to the connections array does not imply thread-safety of accessing
methods on the actual connections.

Adds a test-case that modifies the pool using a supported method
in one thread  while a second thread accesses pool.connections.
The test fails without this patch.

Fixes #36465.

* Update activerecord/test/cases/connection_pool_test.rb

[jeffdoering + Rafael Mendonça França]

images/getting_started: Update screenshot for missing action

Add missing file to require digest/uuid on active_support core ext

When generating a new rails application (rails new) using a custom template that
includes gems from an authenticated source, the user has to provide credentials to
bundler.

One way to do this is by exporting environment variables, for example:

export BUNDLE_GITHUB__COM=user:pass: provides credentials for bundler to fetch
gems from github.com.

The problem this PR addresses is that we are currently scrubs all /BUNDLE_.*/
environment variables by wrapping our system calls in Bundler.with_clean_env.

We do this because we don't want our commands executed against the generated project
to use the generator's bundler environment (e.g. our gems): the generated project should
use it's own configuration.

The problem with Bundler.with_clean_env is that, on top of restoring environment
variables to their original state, it also scrubs any /BUNDLE_.*/ variables, which is harmful for authenticated gem sources.

This PR replaces Bundler.with_clean_env with Bundler.with_original_env, which only
restores environment variables to their initial state, without additional scrubbing.

Fix eager loading associations with string joins not to raise NoMethodError

This fixes a bug that the `foreign_key` and the `foreign_type` are
separated as different table conditions if a polymorphic association has
a scope that joins another tables.