1. 30 1月, 2019 1 次提交
  2. 19 1月, 2019 1 次提交
  3. 18 1月, 2019 2 次提交
  4. 10 1月, 2019 1 次提交
    • K
      Fix safe_constantize to not raise a LoadError. · a930f5ba
      Keenan Brock 提交于
      ### Summary
      
      There was an issues when using `safe_constantize` on a string that has
      the wrong case.
      
      File `em.rb` defines `EM`.
      `"Em".safe_constantize` causes a little confusion with the autoloader.
      The autoloader finds file "em.rb",
      expecting it to define `Em`, but `Em` is not defined.
      The autoloader raises a `LoadError`, which is good,
      But `safe_constantize` is defined to return `nil` when a class is not found.
      
      ### Before
      
      ```
      "Em".safe_constantize
      LoadError: Unable to autoload constant Em, \
      expected rails/activesupport/test/autoloading_fixtures/em.rb to define it
      ```
      
      ### After
      
      ```
      "Em".safe_constantize
      # => nil
      ```
      a930f5ba
  5. 27 12月, 2018 1 次提交
  6. 20 12月, 2018 1 次提交
  7. 30 11月, 2018 1 次提交
  8. 02 11月, 2018 1 次提交
    • N
      Make #to_options an alias for #symbolize_keys · 4ba5386e
      Nick Weiland 提交于
      Fixes #34359
      
      Prior to 5.2.0 (2cad8d71), HashWithIndifferentAccess#to_options acted as
      an alias to HashWithIndifferentAccess#symbolize_keys. Now, #to_options
      returns an instance of HashWithIndifferentAccess while #symbolize_keys
      returns and instance of Hash.
      
      This pr makes it so HashWithIndifferentAccess#to_options acts as an
      alias for HashWithIndifferentAccess#symbolize_keys once again.
      4ba5386e
  9. 29 10月, 2018 1 次提交
  10. 19 10月, 2018 1 次提交
  11. 16 10月, 2018 1 次提交
  12. 13 10月, 2018 1 次提交
    • E
      Fix issue where duration where always rounded up to a second: · c85e3f65
      Edouard CHIN 提交于
      - Adding a Float as a duration to a datetime would result in the Float
        being rounded. Doing something like would have no effect because the
        0.45 seconds would be rounded to 0 second.
      
        ```ruby
          time = DateTime.parse("2018-1-1")
          time += 0.45.seconds
        ```
      
        This behavior was intentionally added a very long time ago, the
        reason was because Ruby 1.8 was using `Integer#gcd` in the
        constructor of Rational which didn't accept a float value.
      
        That's no longer the case and doing `Rational(0.45, 86400)` would
        now perfectly work fine.
      
      - Fixes #34008
      c85e3f65
  13. 12 10月, 2018 2 次提交
  14. 08 10月, 2018 1 次提交
  15. 03 10月, 2018 2 次提交
  16. 29 9月, 2018 1 次提交
  17. 28 9月, 2018 2 次提交
  18. 11 9月, 2018 1 次提交
  19. 08 9月, 2018 1 次提交
  20. 07 9月, 2018 2 次提交
  21. 15 8月, 2018 1 次提交
    • B
      Add `Array#extract!` · 77b01260
      bogdanvlviv 提交于
      The method removes and returns the elements for which the block returns a true value.
      If no block is given, an Enumerator is returned instead.
      
      ```
      numbers = [0, 1, 2, 3, 4, 5, 6, 7, 8, 9]
      odd_numbers = numbers.extract! { |number| number.odd? } # => [1, 3, 5, 7, 9]
      numbers # => [0, 2, 4, 6, 8]
      ```
      77b01260
  22. 10 8月, 2018 1 次提交
  23. 06 8月, 2018 1 次提交
  24. 05 8月, 2018 1 次提交
    • M
      Support skip nil for cache fetch (#25437) · 47018a82
      Martin 提交于
      * test case for fetch cache miss with skip_nil
      
      * abondon nil cache if skip_nil specified
      
      * ensure not cache key for skip nil
      
      * add document with skip_nil for Store#fetch
      
      * add a new change log entry for #25437
      47018a82
  25. 27 7月, 2018 3 次提交
  26. 01 7月, 2018 1 次提交
    • K
      Refactor #33254. · 969577d9
      Kasper Timm Hansen 提交于
      Firstly, increment and decrement shouldn't care about the particulars of
      key expiry. They should only know that they have to pass that responsibility
      on to somewhere else.
      
      Secondly, it moves the key normalization back inside the instrumentation like
      it was originally. I think that matches the original design intention or at
      the very least it lets users catch haywire key truncation.
      
      Thirdly, it moves the changelog entry to the top of the file, where new entries
      go. I couldn't understand what the entry was saying so I tried to rewrite it.
      969577d9
  27. 29 6月, 2018 1 次提交
  28. 31 5月, 2018 1 次提交
  29. 22 5月, 2018 1 次提交
  30. 21 5月, 2018 1 次提交
  31. 22 4月, 2018 1 次提交
  32. 19 4月, 2018 2 次提交
    • G
      Redis cache store: avoid blocking the server in `#delete_matched` · ef2af628
      Gleb Mazovetskiy 提交于
      Fixes #32610. Closes #32614.
      
      Lua scripts in redis are *blocking*, meaning that no other client can
      execute any commands while the script is running. See
      https://redis.io/commands/eval#atomicity-of-scripts.
      
      This results in the following exceptions once the number of keys is
      sufficiently large:
      
          BUSY Redis is busy running a script.
          You can only call SCRIPT KILL or SHUTDOWN NOSAVE.
      
      This commit replaces the lua-based implementation with one that uses
      `SCAN` and `DEL` in batches. This doesn't block the server.
      
      The primary limitation of `SCAN`, i.e. potential duplicate keys, is of
      no consequence here, because `DEL` ignores keys that do not exist.
      ef2af628
    • D
      Fix exception in AS::Timezone.all when any tzinfo data is missing · 7d25b651
      Dominik Sander 提交于
      Before this change missing timezone data for any of the time zones
      defined in `ActiveSupport::Timezone::MAPPING` caused a `comparison of
      NilClass with ActiveSupport::TimeZone failed` exception.
      
      Attempting to get a timezone by passing a number/duration to `[]` or
      calling `all` directly will try to sort sort the values of `zones_map`.
      Those values are initialized by the return value of `create(zonename)`
      which returns `nil` if `TZInfo` is unable to find the timezone
      information.
      
      In our case the exception was triggered by an outdated tzdata package
      which did not include information for the "recently" added time zones.
      
      Before 078421ba `zones_map` only
      returned the information that have been loaded into `@lazy_zone_map`
      which ignored time zones for which the data could not be loaded, this
      change restores the previous behaviour.
      7d25b651