1. 15 9月, 2016 3 次提交
    • A
      bumping version · e4b0a5f6
      Aaron Patterson 提交于
      e4b0a5f6
    • R
      Merge pull request #26495 from johnnyshields/fix-3-2-specs · 4269f71f
      Rafael França 提交于
      [WIP] Fix tests for 3-2-stable
      4269f71f
    • J
      Fix failing tests on 3-2-stable branch: · f8e2fe43
      Johnny Shields 提交于
      - Set sudo: false in .travis.yml which uses latest travis engine and fixes some failing specs
      - Use older version of gems in Gemfile if RUBY_VERSION < '1.9.3' (no change to .gemspec)
      - Fix two cases of hash rockets in tests (required for Ruby 1.8.7)
      - Skip failing test "test_ensure_that_migration_tasks_work_with_mountable_option" which breaks due to Bundler no longer accepting the default generated .gemspec format.
      - Skip railties specs on Ruby 1.8.7 (mark as an allowed failure.)
      f8e2fe43
  2. 22 8月, 2016 1 次提交
  3. 12 8月, 2016 6 次提交
  4. 11 8月, 2016 2 次提交
    • A
      bumping version · ebc36391
      Aaron Patterson 提交于
      ebc36391
    • A
      ensure tag/content_tag escapes " in attribute vals · 4bcccf5e
      Andrew Carpenter 提交于
      Many helpers mark content as HTML-safe without escaping double quotes -- including `sanitize`. Regardless of whether or not the attribute values are HTML-escaped, we want to be sure they don't include double quotes, as that can cause XSS issues. For example: `content_tag(:div, "foo", title: sanitize('" onmouseover="alert(1);//'))`
      
      CVE-2016-6316
      4bcccf5e
  5. 21 5月, 2016 1 次提交
  6. 17 5月, 2016 1 次提交
  7. 15 3月, 2016 1 次提交
  8. 09 3月, 2016 1 次提交
  9. 02 3月, 2016 2 次提交
  10. 01 3月, 2016 4 次提交
    • R
      Preparing for 3.2.22.2 release · 1ac2ddbc
      Rafael Mendonça França 提交于
      1ac2ddbc
    • R
      Add bundle check to release task · 1b7d56c7
      Rafael Mendonça França 提交于
      1b7d56c7
    • A
      Don't allow render(params) in view/controller · 769b4d3f
      Arthur Neves 提交于
      `render(params)` is dangerous and could be a vector for attackers.
      
      Don't allow calls to render passing params on views or controllers.
      
      On a controller or view, we should not allow something like `render
      params[:id]` or `render params`.
      That could be problematic, because an attacker could pass input that
      could lead to a remote code execution attack.
      
      This patch is also compatible when using strong parameters.
      
      CVE-2016-2098
      769b4d3f
    • A
      Complete work on 3.2 for render_data_leak patch. · af9b9132
      Arthur Neves 提交于
      Render could leak access to external files before this patch.
      A previous patch(CVE-2016-0752), attempted to fix this. However the tests
      were miss-placed outside the TestCase subclass, so they were not running.
      
      We should allow :file to be outside rails root, but anything else must
      be inside the rails view directory.
      
      The implementation has changed a bit though. Now the patch is more
      similar with the 4.x series patches.
      Now `render 'foo/bar'`, will add a special key in the options
      hash, and not use the :file one, so when we look up that file, we
      don't set the fallbacks, and only lookup a template, to constraint the
      folders that can be accessed.
      
      CVE-2016-2097
      af9b9132
  11. 02 2月, 2016 1 次提交
    • A
      Generated engines should protect from forgery · 98926265
      Aaron Patterson 提交于
      Generated engines should call `protect_from_forgery`.  If this method
      isn't called, then the Engine could be susceptible to XSS attacks.
      Thanks @tomekr for reporting this to us!
      
      Conflicts:
      	railties/lib/rails/generators/rails/plugin/templates/app/controllers/%namespaced_name%/application_controller.rb.tt
      	railties/test/generators/plugin_generator_test.rb
      98926265
  12. 29 1月, 2016 3 次提交
    • E
      Run `file.close` before unlinking for travis · a7a376a6
      eileencodes 提交于
      This works on OSX but for some reason travis is throwing a
      ```
        1) Error:
      ExpiresInRenderTest#test_dynamic_render_with_absolute_path:
      NoMethodError: undefined method `unlink' for nil:NilClass
      ```
      Looking at other tests in Railties the file has a name and we close
      it before unlinking, so I'm going to try that.
      a7a376a6
    • E
      Fix hash syntax for 1.8.7 · 457de375
      eileencodes 提交于
      Rails 3.2 supports 1.8.7 but 1.8.7 does not support the new hash syntax.
      457de375
    • E
      Regression test for rendering file from absolute path · 81a44518
      eileencodes 提交于
      Test that we are not allowing you to grab a file with an absolute path
      outside of your application directory. This is dangerous because it
      could be used to retrieve files from the server like `/etc/passwd`.
      81a44518
  13. 26 1月, 2016 7 次提交
  14. 23 1月, 2016 4 次提交
  15. 16 1月, 2016 3 次提交