1. 08 3月, 2016 1 次提交
  2. 02 3月, 2016 1 次提交
  3. 01 3月, 2016 10 次提交
  4. 13 2月, 2016 1 次提交
  5. 02 2月, 2016 1 次提交
    • A
      Generated engines should protect from forgery · 331210df
      Aaron Patterson 提交于
      Generated engines should call `protect_from_forgery`.  If this method
      isn't called, then the Engine could be susceptible to XSS attacks.
      Thanks @tomekr for reporting this to us!
      
      Conflicts:
      	railties/lib/rails/generators/rails/plugin/templates/app/controllers/%namespaced_name%/application_controller.rb.tt
      	railties/test/generators/plugin_generator_test.rb
      331210df
  6. 29 1月, 2016 10 次提交
  7. 28 1月, 2016 1 次提交
  8. 27 1月, 2016 2 次提交
  9. 26 1月, 2016 2 次提交
    • A
      Merge branch '4-1-sec' into 4-1-stable · 7921ff8c
      Aaron Patterson 提交于
      * 4-1-sec:
        bumping version
        Remove unnecessary caching
        Eliminate instance level writers for class accessors
        allow :file to be outside rails root, but anything else must be inside the rails view directory
        Don't short-circuit reject_if proc
        stop caching mime types globally
        use secure string comparisons for basic auth username / password
      7921ff8c
    • A
      bumping version · 31ab3aa0
      Aaron Patterson 提交于
      31ab3aa0
  10. 23 1月, 2016 6 次提交
    • E
      Remove unnecessary caching · 98629dfc
      eileencodes 提交于
      `ActiveSupport::Dependencies.constantize(const_name)` calls
      `Reference.new` which is defined as
      `ActiveSupport::Dependencies.constantize(const_name)` meaning this call
      is already cached and we're doing caching that isn't necessary.
      
      Conflicts:
      	actionpack/lib/action_dispatch/routing/route_set.rb
      
      Conflicts:
      	actionpack/lib/action_dispatch/routing/route_set.rb
      
      CVE-2015-7581
      98629dfc
    • A
      Eliminate instance level writers for class accessors · 50d3d7d0
      Aaron Patterson 提交于
      Instance level writers can have an impact on how the Active Model /
      Record objects are saved.  Specifically, they can be used to bypass
      validations.  This is a problem if mass assignment protection is
      disabled and specific attributes are passed to the constructor.
      
      Conflicts:
      	activerecord/lib/active_record/scoping/default.rb
      	activesupport/lib/active_support/callbacks.rb
      
      CVE-2016-0753
      50d3d7d0
    • A
      allow :file to be outside rails root, but anything else must be inside the rails view directory · be543e8e
      Aaron Patterson 提交于
      Conflicts:
      	actionpack/test/controller/render_test.rb
      	actionview/lib/action_view/template/resolver.rb
      
      CVE-2016-0752
      be543e8e
    • A
      Don't short-circuit reject_if proc · 5875bc3a
      Andrew White 提交于
      When updating an associated record via nested attribute hashes the
      reject_if proc could be bypassed if the _destroy flag was set in the
      attribute hash and allow_destroy was set to false.
      
      The fix is to only short-circuit if the _destroy flag is set and the
      option allow_destroy is set to true. It also fixes an issue where
      a new record wasn't created if _destroy was set and the option
      allow_destroy was set to false.
      
      CVE-2015-7577
      5875bc3a
    • A
      stop caching mime types globally · 221937c8
      Aaron Patterson 提交于
      Unknown mime types should not be cached globally.  This global cache
      leads to a memory leak and a denial of service vulnerability.
      
      CVE-2016-0751
      221937c8
    • A
      use secure string comparisons for basic auth username / password · 859ca447
      Aaron Patterson 提交于
      this will avoid timing attacks against applications that use basic auth.
      
      Conflicts:
      	activesupport/lib/active_support/security_utils.rb
      
      CVE-2015-7576
      859ca447
  11. 16 1月, 2016 1 次提交
  12. 08 1月, 2016 1 次提交
  13. 26 12月, 2015 3 次提交
    • R
      Avoid relying on error messages when rescuing · 766a0cd7
      Robin Dupret 提交于
      When we are rescuing from an error, it's a brittle approach to do checks
      with regular expressions on the raised message because it may change in
      in the future and error messages are different across implementations.
      
      The NameError API could be improved at the MRI level but for now we need
      to rely on its #name. A #== check will only pass for top level constants
      or only when the last constant of the path is missing so we need to rely
      on #include? instead. For instance:
      
          begin
            Namespace::Foo
          rescue NameError => e
            e.name # => :Namespace
          end
      
      However, if the name-space already exists, only the name of the first
      missing constant in the path is returned (e.g. for Math::PHI, the name
      would be :PHI). JRuby will return a fully qualified name (:"Math::PHI").
      
      We need to keep the == check for 1.9 compatibility since const_get will
      raise a NameError with a name attribute set to the given string if it's
      one of "::" or "".
      
      See http://git.io/jnSN7g for further information.
      766a0cd7
    • A
      Dont check bundler output on plugin generator test · 7fd06ee2
      Arthur Neves 提交于
      7fd06ee2
    • R
      Bundle update · 1703dd70
      Rafael Mendonça França 提交于
      1703dd70