• T
    Unwrap vm_call_cfunc indirection on JIT · b9d3ceee
    Takashi Kokubun 提交于
    for VM_METHOD_TYPE_CFUNC.
    
    This has been known to decrease optcarrot fps:
    
    ```
    $ benchmark-driver -v --rbenv 'before --jit;after --jit' benchmark.yml --repeat-count=24 --output=all
    before --jit: ruby 2.8.0dev (2020-04-13T16:25:13Z master fb40495c) +JIT [x86_64-linux]
    after --jit: ruby 2.8.0dev (2020-04-13T23:23:11Z mjit-inline-c bdcd06d159) +JIT [x86_64-linux]
    Calculating -------------------------------------
                                     before --jit           after --jit
    Optcarrot Lan_Master.nes    66.38132676191719     67.41369177299630 fps
                                69.42728743772243     68.90327567263054
                                72.16028300263211     69.62605130880686
                                72.46631319102777     70.48818243767207
                                73.37078877002490     70.79522887347566
                                73.69422431217367     70.99021920193194
                                74.01471487018695     74.69931965402584
                                75.48685183295630     74.86714575949016
                                75.54445264507932     75.97864419721677
                                77.28089738169756     76.48908637569581
                                78.04183397891302     76.54320932488021
                                78.36807984096562     76.59407262898067
                                78.92898762543574     77.31316743361343
                                78.93576483233765     77.97153484180480
                                79.13754917503078     77.98478782102325
                                79.62648945850653     78.02263322726446
                                79.86334213878064     78.26333724045934
                                80.05100635898518     78.60056756355614
                                80.26186843769584     78.91082645644468
                                80.34205717020330     79.01226659142263
                                80.62286066044338     79.32733939423721
                                80.95883033058557     79.63793060542024
                                80.97376819251613     79.73108936622778
                                81.23050939202896     80.18280109433088
    ```
    
    and I deleted this capability in an early stage of YARV-MJIT development:
    https://github.com/k0kubun/yarv-mjit/commit/0ab130feeefc2b9078a1077e4fec93b3f5e45d07
    
    I suspect either of the following things could be the cause:
    
    * Directly calling vm_call_cfunc requires more optimization effort in GCC,
      resulting in 30ms-ish compilation time increase for such methods and
      decreasing the number of methods compiled in a benchmarked period.
    
    * Code size increase => icache miss hit
    
    These hypotheses could be verified by some methodologies. However, I'd
    like to introduce this regardless of the result because this blocks
    inlining C method's definition.
    
    I may revert this commit when I give up to implement inlining C method
    definition, which requires this change.
    
    Microbenchmark-wise, this gives slight performance improvement:
    
    ```
    $ benchmark-driver -v --rbenv 'before --jit;after --jit' benchmark/mjit_send_cfunc.yml --repeat-count=4
    before --jit: ruby 2.8.0dev (2020-04-13T16:25:13Z master fb40495c) +JIT [x86_64-linux]
    after --jit: ruby 2.8.0dev (2020-04-13T23:23:11Z mjit-inline-c bdcd06d159) +JIT [x86_64-linux]
    Calculating -------------------------------------
                         before --jit  after --jit
         mjit_send_cfunc      41.961M      56.489M i/s -    100.000M times in 2.383143s 1.770244s
    
    Comparison:
                      mjit_send_cfunc
             after --jit:  56489372.5 i/s
            before --jit:  41961388.1 i/s - 1.35x  slower
    ```
    b9d3ceee
_mjit_compile_send.erb 6.0 KB