Merge pull request #110 from bostin/fixbug/php_strtolower_changed_original_string

replace php_strtolower with zend_str_tolower_dup

skywalking.c

@@ -156,7 +156,7 @@ static char *pcre_match(char *pattern, int len, char *subject) {
 static char *sky_redis_fnamewall(const char *function_name) {
     char *fnamewall = (char *) emalloc(strlen(function_name) + 3);
     sprintf(fnamewall, "|%s|", function_name);
-    fnamewall = php_strtolower(fnamewall, strlen(fnamewall));
+    fnamewall = zend_str_tolower_dup(fnamewall, strlen(fnamewall));
     return fnamewall;
 }
 
@@ -255,7 +255,7 @@ ZEND_API void sky_execute_ex(zend_execute_data *execute_data) {
                                 case IS_ARRAY:
                                     break;
                                 default:
-                                    convert_to_string(entry)
+                                    convert_to_string(entry);
                                     smart_str_appends(&command, Z_STRVAL_P(entry));
                                     smart_str_appends(&command, " ");
                                     break;
@@ -551,7 +551,7 @@ ZEND_API void sky_execute_internal(zend_execute_data *execute_data, zval *return
             uint32_t arg_count = ZEND_CALL_NUM_ARGS(execute_data);
 
             smart_str command = {0};
-            smart_str_appends(&command, php_strtolower((char *) function_name, strlen((char *) function_name)));
+            smart_str_appends(&command, zend_str_tolower_dup((char *) function_name, strlen((char *) function_name)));
             smart_str_appends(&command, " ");
 
             int is_string_command = 1;
@@ -568,7 +568,7 @@ ZEND_API void sky_execute_internal(zend_execute_data *execute_data, zval *return
                 if (i == 1) {
                     add_assoc_string(&tags, "redis.key", Z_STRVAL_P(p));
                 }
-                smart_str_appends(&command, php_strtolower(Z_STRVAL_P(p), Z_STRLEN_P(p)));
+                smart_str_appends(&command, zend_str_tolower_dup(Z_STRVAL_P(p), Z_STRLEN_P(p)));
                 smart_str_appends(&command, " ");
             }
             // store command to tags