Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
2dot5
ClickHouse
提交
a6959584
C
ClickHouse
项目概览
2dot5
/
ClickHouse
通知
3
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
C
ClickHouse
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
未验证
提交
a6959584
编写于
3月 30, 2021
作者:
A
alexey-milovidov
提交者:
GitHub
3月 30, 2021
浏览文件
操作
浏览文件
下载
差异文件
Merge pull request #22235 from ClickHouse/quantile-deterministic-msan
Fix MSan report in `quantileDeterministic`
上级
b7b55ce6
f7662df0
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
26 addition
and
1 deletion
+26
-1
src/AggregateFunctions/ReservoirSamplerDeterministic.h
src/AggregateFunctions/ReservoirSamplerDeterministic.h
+24
-1
tests/queries/0_stateless/01779_quantile_deterministic_msan.reference
...s/0_stateless/01779_quantile_deterministic_msan.reference
+1
-0
tests/queries/0_stateless/01779_quantile_deterministic_msan.sql
...queries/0_stateless/01779_quantile_deterministic_msan.sql
+1
-0
未找到文件。
src/AggregateFunctions/ReservoirSamplerDeterministic.h
浏览文件 @
a6959584
...
...
@@ -13,6 +13,7 @@
#include <Common/NaNUtils.h>
#include <Poco/Exception.h>
namespace
DB
{
namespace
ErrorCodes
...
...
@@ -162,6 +163,11 @@ public:
sorted
=
false
;
}
#if !__clang__
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wclass-memaccess"
#endif
void
write
(
DB
::
WriteBuffer
&
buf
)
const
{
size_t
size
=
samples
.
size
();
...
...
@@ -169,9 +175,26 @@ public:
DB
::
writeIntBinary
<
size_t
>
(
total_values
,
buf
);
for
(
size_t
i
=
0
;
i
<
size
;
++
i
)
DB
::
writePODBinary
(
samples
[
i
],
buf
);
{
/// There was a mistake in this function.
/// Instead of correctly serializing the elements,
/// it was writing them with uninitialized padding.
/// Here we ensure that padding is zero without changing the protocol.
/// TODO: After implementation of "versioning aggregate function state",
/// change the serialization format.
Element
elem
;
memset
(
&
elem
,
0
,
sizeof
(
elem
));
elem
=
samples
[
i
];
DB
::
writePODBinary
(
elem
,
buf
);
}
}
#if !__clang__
#pragma GCC diagnostic pop
#endif
private:
/// We allocate some memory on the stack to avoid allocations when there are many objects with a small number of elements.
using
Element
=
std
::
pair
<
T
,
UInt32
>
;
...
...
tests/queries/0_stateless/01779_quantile_deterministic_msan.reference
0 → 100644
浏览文件 @
a6959584
11447494982455782708
tests/queries/0_stateless/01779_quantile_deterministic_msan.sql
0 → 100644
浏览文件 @
a6959584
SELECT
cityHash64
(
toString
(
quantileDeterministicState
(
number
,
sipHash64
(
number
))))
FROM
numbers
(
8193
);
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录